Write tour integration for Field UI module

Just a couple language suggestions, use them if they help.

+++ b/core/modules/field_ui/config/tour.tour.field-ui-display.yml
@@ -0,0 +1,38 @@
+    body: <p>The following page is used for managing the display of fields declared in 'Manage fields'.</p><p>Tasks that can be performed include:</p><ul><li>Change settings for field display.</li><li>Arranging the order in which fields are displayed.</li><li>Hide and show fields via dragging.</li><li>Enable additional field displays and settings.</li></ul>

"This page is used to manage how the fields from 'Manage fields' will be displayed on different parts of your site."

"Show and hide fields."

"Configure additional field displays and its settings."

+++ b/core/modules/field_ui/config/tour.tour.field-ui-fields.yml
@@ -0,0 +1,44 @@
+    body: <p>The widget type is a reference to how the data will appear for both content entry and display.</p><p>eg. Select list or checkboxes.</p>

You can remove extra language: "... a reference to ..." to make these sentences more clear. And a 'widget' is more towards content entry than display. Field formatters provide the display but they are tied to the widget so maybe...

"The type of widget will control how the data will be entered and also provide options to how it will eventually be formatted on a page."
eg. Date field type, date popup widget, countdown formatter. or something...

Hope that helps a bit, cheers.

It's a tough balance between technically accurate and user friendly:)

+++ b/core/modules/field_ui/config/tour.tour.field-ui-display.ymlundefined
@@ -0,0 +1,38 @@
+    body: <p>Display modes allow for content to be viewed in many different ways.</p><p>eg. The content type's content on a page will different to a smaller subset of content displayed in a list.</p> ¶

Trailing whitespace

+++ b/core/modules/field_ui/config/tour.tour.field-ui-display.ymlundefined
@@ -0,0 +1,38 @@
+    body: <p>Formats are used to display field information in different ways.</p><p>eg. Tags can be display in plain text or link form.</p> ¶

Same

+++ b/core/modules/field_ui/config/tour.tour.field-ui-display.ymlundefined
@@ -0,0 +1,38 @@
+    body: <p>Allow for addition settings that other modules use to extend field display functionality.</p><p>Core provides the ability to enable additional view modes.</p> ¶

Same

+++ b/core/modules/field_ui/config/tour.tour.field-ui-fields.ymlundefined
@@ -0,0 +1,44 @@
+    body: <p>The field type is the type of data that this field will store.</p><p>eg. A list of items.</p> ¶

Same

I advise you to find a plugin for your editor that strips away those trailing whitespaces.
Will make your contrib life much easier! :)

Rerolled

+++ b/core/modules/field_ui/config/tour.tour.field-ui-display.ymlundefined
@@ -0,0 +1,38 @@
+  - admin/structure/types/manage/*/display

This now only shows on content types, just wondering whether we want to add this to taxonomy, user and comments paths too ?

Also, the widget stuff is gone from the 'Manage fields' screen :)

#7: 1960824-7-field-ui-tour.patch queued for re-testing.

Working on this

This is a re-roll of #7, plus added a tour test and fixed incorrect selector in tour.tour.field-ui-fields.yml

Still need tests for display page.

1. +++ b/core/modules/field_ui/config/tour.tour.field-ui-display.yml
   @@ -0,0 +1,38 @@
   +label: Field UI display
   +langcode: en
   

   module is missing. I'm not sure that's required (Tour UI #2072649: module is not set for new tour.)

2. +++ b/core/modules/field_ui/config/tour.tour.field-ui-display.yml
   @@ -0,0 +1,38 @@
   +    body: <p>This page is used to manage how the fields from 'Manage fields' will be displayed on different parts of your site.</p><p>Tasks that can be performed include:</p><ul><li>Change settings for field display.</li><li>Arranging the order in which fields are displayed.</li><li>Show and hide fields.</li><li>Enable additional field displays and display options.</li></ul>
   

   attributes is missing according to test result.

   I noted on http://tour.drutch.nl/admin/config/user-interface/tour-builder/field-ui-... that it has the attribute but it is an empty string.

   attributes: ''

Not sure this helps :-/

The attributes issue is being fixed in #2073875: TourTestBase needs to allow for list elements in the body

#18: 1960824-field-ui-tour-18.patch queued for re-testing.

Needs re-roll

Updated issue summary.

Re-rolled

Updated some API changes, reflected in interdiff

This patch:

• Removes a couple of field settings which are no longer there: e.g. add existing field
• Fixes selectors for a few that were broken
• Adds a new tour for form display page

Missing interdiff.

Updated patch with interdiff. A bunch of text changes, nothing else. Spoke to Nick about the need to get some consistency in how these are written, so going to start here.

Awesome. Thanks pameeela!

We should start putting together guidelines for how to write a tip.

27: 1960824-field-ui-tour-27.patch queued for re-testing.

27: 1960824-field-ui-tour-27.patch queued for re-testing.

A re-roll attempt.

+++ b/core/modules/filter/tests/filter_test/lib/Drupal/filter_test/Plugin/Filter/FilterTestReplace.php
@@ -29,7 +29,7 @@ class FilterTestReplace extends FilterBase {
-    $text[] = 'Filter: ' . $this->getLabel() . ' (' . $this->getPluginId() . ')';
+    $text[] = 'Filter: ' . $this->getLabel() . ' (' . $this->getPluginID() . ')';

I assumed this was a type so ignored this.

32: 1960824-field-ui-tour-32.patch queued for re-testing.

This one seems like a good thing to do, but postponed on #1921152-109: META: Start providing tour tips for other core modules. for now.

Normalising title.

This tour module is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

Implemented Field UI tour integration attached the screenshots, working on test coverage so currently move to NW.

I have tried to add test coverage, apart from it, nothing seems to be left., Please review. moving NR