Problem/Motivation

Track the steps needed to remove extension Tour from core to contrib. See Remove a core module and move it to a contributed project of the deprecation policy.

The contrib project is Tour

The removal of extension Tour was approved in #3325445: [Policy] Remove tour module from core

Remaining tasks

  1. ✅ Begin finding someone to maintain the contrib version of the extension. The contrib Tour project is ready with smustgrave as maintainer.
  2. ✅ Move integrations implemented by other modules to the extension.
    Create child issues or child meta issues, as needed, to address the following points. Not all points will apply to all extensions.
  3. ✅ Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then create issues to remove the references.
  4. ✅ Create the contrib project with a stable release. Follow the process in Create the contrib project with a stable release for creating the sub tree split. https://www.drupal.org/project/tour/releases/1.0.0
  5. Deprecate the core extension. #3405672: Deprecate Tour module

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes

Add test issue and remove tasks for migrations,

quietone’s picture

quietone commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Postponed
Related issues: +#3325445: [Policy] Remove tour module from core

Postponing on #3325445: [Policy] Remove tour module from core, since removing Tour does not have consensus and signoff yet.

xjm’s picture

xjm
she/her
Primary language English
commented
Parent issue: #3265680: Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 11 core »

Also un-parenting until there is signoff.

quietone’s picture

quietone commented

Yea, don't know how/why I missed that.

@xjm, thanks for the cleanup.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Parent issue: » #3265680: Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 11 core

There is now signoff on the removal.

quietone’s picture

quietone commented
Status: Postponed » Active
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented

Got #3336050: Move tour tests to the tour module up for review

Didn't put #3387163: Decouple tour from ConfigInstallProfileOverrideTest in review as I got some questions.

quietone’s picture

quietone commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented

Can work on some of these next week if anyone will be free to review

smustgrave’s picture

smustgrave commented

Got an early start on a few of them.

Will take a look at the others later.

quietone’s picture

quietone commented
Issue summary: View changes

Add the deprecation issue.

smustgrave’s picture

smustgrave commented
Issue summary: View changes

All child issues are up for review.

quietone’s picture

quietone commented
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

#3405726: Move all tour config to tour module also landed thanks to @quietone! 🚀

catch’s picture

catch
he/him
Primary language English
commented
Related issues: +#3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Now #3405664: Remove Tour module from tests landed thanks to @larowlan — go Down Under! 😄

Last one: #3405660: Remove tour from themes.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Last one is RTBC.

By the way, where can I read about why this decision was made? I think functionality like the Tour module still is very valuable for both Drupal core and the ecosystem. I'm curious what the intended successor is?

poker10’s picture

poker10 commented

I think that the removal was discussed in this issue: #3325445: [Policy] Remove tour module from core

quietone’s picture

quietone commented

Yes, I make a point of adding the policy issue to the issue summary of the deprecation and removal metas for extension removal. It is included in the templates used to make these issues, which are in the deprecation policy docs.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

🙈

Sorry for missing it in the issue summary. Read that. I get it now 👍

Let's finish this! 🤝

quietone’s picture

quietone commented
Issue summary: View changes
Related issues: +#3376099: [11.x] [Meta] Tasks to remove Tour
smustgrave’s picture

smustgrave commented

The theme removal was discussed in slack https://drupal.slack.com/archives/C04CHUX484T/p1708034907274609

It was agreed upon that leaving the CSS is fine and when we remove tour we can remove the css from the themes

Repurposing #3405660: Remove tour from themes for the css removal.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

Per #27, removed this from the list of tasks.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Status: Active » Reviewed & tested by the community

AFAICT the only thing left is to create a contrib module? Nope, that's already done too thanks to @smustgrave: https://www.drupal.org/project/tour/releases/1.0.0

That means we're down to the very last thing: #3405672: Deprecate Tour module. And I see that ~5 hours ago @quietone was pushing that forward! 🎉

Updating issue status to indicate we're at the very end here 😊

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I think this can officially be closed, and we can move onto #3376099: [11.x] [Meta] Tasks to remove Tour now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

quietone commented
Version: 11.x-dev » 10.3.x-dev