Problem/Motivation

Preparation for deprecation.

Steps to reproduce

Proposed resolution

Move help topics to Tour module.

Remaining tasks

Decide what to do with the Tour section in help_topics.api.php

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 interdiff_2-6.txt4.77 KBspokje
#6 3336065-6.patch3.33 KBspokje
#2 3336065-2.patch2.6 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Version: 11.0.x-dev » 10.1.x-dev
Status: Active » Needs review
StatusFileSize
new 3336065-2.patch2.6 KB

The moves tour.overview.html.twig. It also deletes tour references from help_topics.api.php and core.ui_components.html.twig. There are not moved because I am not sure where they would go.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Postponed

Postponing as the policy does not have consensus yet.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Postponed » Active

The removal has been approved.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new 3336065-6.patch3.33 KB
new interdiff_2-6.txt4.77 KB

Rerolled patch #2 against 11.x.

Interdiff looks a bit wonky, but basically all is the same except:
- /core/modules/help_topics/ moved to /core/modules/help/help_topics/ somewhere between patch #2 and patch #6.
- I opted to add the tour section from /core/modules/help/help.api.php to /core/modules/tour/tour.api.php

Status: Needs review » Needs work

The last submitted patch, 6: 3336065-6.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Think it will be good to have that info in just the Tour module.

  • lauriii committed 8fece068 on 11.x 
    Issue #3336065 by Spokje, quietone: Move help topics to tour module
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 8fece06 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.