Problem/Motivation

\Drupal\Tests\help\Functional\HelpPageOrderTest uses the Tour module, which is being deprecated.
Also, \Drupal\Tests\toolbar\Functional\ToolbarCacheContextsTest.

There are other tests using tour but they are related to profiles or update tests. They are better done in a separate issue.

Steps to reproduce

Proposed resolution

HelpPageOrderTest - Use a test module instead of Tour.
\Drupal\Tests\toolbar\Functional\ToolbarCacheContextsTest - TBD

Remaining tasks

Decide what to do about Tour in \Drupal\Tests\toolbar\Functional\ToolbarCacheContextsTest
Review
Commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 3376340-7.patch1.53 KBquietone
#7 diff-5-7.txt595 bytesquietone
#5 3376340-5.patch1.79 KBquietone
#2 3376340-2.patch992 bytesquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 3376340-2.patch992 bytes
quietone’s picture

quietone commented
Title: Remove use of tour in HelpPageOrderTest » Remove use of tour in non profile and update tests
Issue summary: View changes

Oops. There is another one.

There is usage in \Drupal\Tests\toolbar\Functional\ToolbarCacheContextsTest. I am not sure how to handle that one.

Status: Needs review » Needs work

The last submitted patch, 2: 3376340-2.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 3376340-5.patch1.79 KB
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Shouldn't we remove tour from HelpPageReverseOrderTest?

Discussion please no one implement.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new diff-5-7.txt595 bytes
new 3376340-7.patch1.53 KB

Yes, we should. That was an oversite on my part.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • lauriii committed 5ac5a2b6 on 11.x 
    Issue #3376340 by quietone, smustgrave: Remove use of tour in non...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 5ac5a2b and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.