Follow up for #1809352: Write tour.module and add it to core
Part of the META: #1921152: META: Start providing tour tips for other core modules.
Problem/Motivation
The original issue added the infrastructure for being able to add tours, and an example that shows in views edit. Another tour is needed to show basic things about drupal, like using Extend to add modules.
Proposed resolution
Add a tour for the front page, add a link to the front page tour to the main help page.
Remaining tasks
TBD.
User interface changes
Yes, adding a tour to the ui.
API changes
No api changes anticipated.
Technical pointers when creating tour tips
See: https://drupal.org/node/1921152#tour-tips-tech-note for tech notes on making tour tips.
Comment | File | Size | Author |
---|---|---|---|
#73 | 1920468-73.patch | 7.06 KB | smustgrave |
#73 | interdiff-72-73.txt | 613 bytes | smustgrave |
#69 | 1920468-69-tests-only.patch | 1.82 KB | smustgrave |
Comments
Comment #1
nick_schuch CreditAttribution: nick_schuch commentedComment #2
YesCT CreditAttribution: YesCT commentedsee related point 4 and 16 in user testing: http://groups.drupal.org/node/285978#comment-894708
Comment #3
Bojhan CreditAttribution: Bojhan commentedThis is definitely almost a "postponed" we should have a strategy for tour module, randomly adding tours is not what we should do - its likely we will start trowing usability problems under the rug.
Comment #4
LeeHunter CreditAttribution: LeeHunter commentedComment #5
YesCT CreditAttribution: YesCT commentedupdating the issue title to go with other tour writing issues listed in the meta.
Updating summary too.
Comment #6
YesCT CreditAttribution: YesCT commented#3 @Bojhan
Good point. We dont want to cover up usability issues that we should actually be *fixing*. Lets discuss general guidelines in the META issue: #1921152: META: Start providing tour tips for other core modules.
Comment #7
LewisNymanIt would be really nice if we had a tour for brand new users and users who are new to Drupal 8, showing them what's changed. I'm not sure at what point we identify they are new to Drupal 8 only.
Comment #8
LeeHunter CreditAttribution: LeeHunter commentedAs a first step, I've made this screen capture of a new D8 site and put squares around everything that could possibly be included. Since there are too many elements for one tour and many of them are relatively self-explanatory, I've used thick green boxes to highlight the elements that I'm guessing would be good candidates for a tour. My thinking is that we should focus on those areas where the user says "What is this widget?" or "How do I change this content/structure/colour etc?"
To mark up the screen capture I'm using Adobe Acrobat and enabled the file so that others can mark it up and add comments. I realize that a PDF is not ideal for many reasons, but for the moment it seems like a practical way for myself to add editable text, comments etc in a graphical setting. If you have Adobe Reader, you should be able to edit the markup and add comments by visiting the file in my public Dropbox folder https://www.dropbox.com/sh/in81k4tgg73woba/ZuHc_eufwS/Drupal However, it would generally be more useful to post comments here in the queue.
As I work on this some more over the next couple of days, I'll post new versions but in the interim I'd also like to get feedback on whether I'm on the right track (e.g. addressing the right elements on the page) and any other insights you might have into things like the sequence of the tour etc.
One thing I'm curious about re Tours is how they are displayed. Specifically, how does Drupal know whether the user wants to see the tour or not: does it only display one time or does it keep popping up until the user takes some action to stop it being displayed (and if that's the case, is there any way for the user to bring it back again).
Comment #9
nick_schuch CreditAttribution: nick_schuch commentedI completely agree with the proposed elements.
In regards to how the tour elements are displayed....
We have a permission called "View tour tips". Users who have this permission will be provided a "Tour" item in the right of the toolbar. This toggles tips on and off. By default the tips are not shown. However, for something like "This initial experience" we have the following being worked on that will enable the tour to be fired right away on page load http://drupal.org/node/1942576 based on a query string. We just need to provide the pages that we want this tour to be displayed on. I imagine this would just be after first install or just the front page?
A good example of this can be found on the views edit page or a screencast can be found here: http://previousnext.com.au/blog/tour-module-part-1-journey-adding-drupal...
Comment #10
LeeHunter CreditAttribution: LeeHunter commentedHere's a first crack at the tour. In trying to give it a logical flow I played with a few sequences, but in the end went for a straightforward top down/left to right flow. Aside from being (I believe) fairly predictable to the user it has the advantage of subtly grouping the two admin UI widgets (items 1 and 2) and then 3 to 7 are all things you can change on the actual site. But it might actually might make sense to put those two widgets at the end of the tour since they're probably not the priority for a new user and they're off in a corner by themselves anyway. I'm not sure if you can do bold text in a tour but if you can, it would be helpful as a way of differentiating text that is actually the title of a UI item.
I was also wondering whether it needs an introductory tip (e.g. Welcome to your new site. This brief tour will help you understand your home page and how to start making changes.) and possibly an ending tip (e.g. For more information, see the Drupal documentation).
Comment #11
tstoecklerThis looks pretty awesome already. I would suggest we get a version of this in to put it in people's faces so we can refine in a second step. I think two or three reviews should suffice and then we can set this RTBC, IMHO.
A couple suggestions:
. 7. Would then still be the "Add custom block" link.
I would make 6. (which I would put at 8.) more explicit. Suggestion:
Comment #12
Bojhan CreditAttribution: Bojhan commentedWoooo, this is waaay to much. It should be a tour of the most important things, not of everything. Doing this much is the best way to get people to skip it.
The most important thing, I have found people struggle with when they land on Drupal is knowing what is in structure, extend and configuration. All the other items tend to be pretty self-explanatory.
Comment #13
LeeHunter CreditAttribution: LeeHunter commentedI'm surprised that the Structure, Extend and Configuration menu items would be things that people have problems with.
For myself, if I didn't already know something about how Drupal worked I would never have guessed that the "Home" tab was actually a menu item or that the "Welcome to ..." text was something generated by Views.
Has anyone done tests of the D8 interface yet? If so, are the results available online?
Comment #14
Bojhan CreditAttribution: Bojhan commented@LeeHunter We actually have done quite a number of tests, http://drupal.org/node/1166656 (Drupal 7, but really just after release so still close to D8), http://drupal.org/node/1427940, http://groups.drupal.org/node/277458 and http://groups.drupal.org/node/260203. Probally a few more that I am missing.
I think one of the things you are overestimating is the depth that is needed, just after install we want people to understand the bare fundamentals. Showing them how Vies generates the welcome to.. part is very advanced. What people really want to know is where things can be found, what navigational "hubs" exist.
Comment #15
LeeHunter CreditAttribution: LeeHunter commentedHow about this then:
1. Configure content types, menus, blocks, taxonomies, etc.
2. Change the functionality of your site by enabling, disabling or updating modules
3. Configure site information and other options such as language, region, file locations etc.
I noticed that when I installed Drupal 8 just now, this menu didn't actually display until I clicked Menu. Do we need another item for the Menu button, something like "Click here to see the Administration menu"?
Comment #16
Bojhan CreditAttribution: Bojhan commented@LeeHunter that is a bug, and yes I think what you are describing there should be a good first pointer. The tour can't move through pages, can it?
Comment #17
klonos#1942576: Tour tips to be able to link to other pages and start tour's automatically.
Comment #18
nick_schuch CreditAttribution: nick_schuch commentedOne issue I can see is that the toolbars submenu has multiple states eg. Opened, closed, below the toolbar and to the left of the page.
Im not sure if we can account for all these states.
Comment #18.0
nick_schuch CreditAttribution: nick_schuch commentedUpdated issue summary, added link to meta
Comment #19
clemens.tolboomSome technical remarks.
- what module provides this front page tour? The current sketch is about the toolbar. So the patch do the same.
- What if more then one module claims the same path?
- The z-index for the tour is was lower then that of the tour.
- On small screen the tour cannot point to the correct element
Comment #20
clemens.tolboomI forgot the reply to #15 #16 and #18
Step contains instruction to open the menu. What more can we do?
What is the 'postponed' status mentioned in #3?
Should we rename this issues title into something like 'toolbar tour on frontpage'?
Comment #21
clemens.tolboomThis is not about language module.
Should have different titles. Attached patch fixes this.
Comment #22
clemens.tolboomI split off #19 (z-index) to #2021361: tour should be in front of toolbar (z-index)
Comment #22.0
clemens.tolboomUpdated issue summary.
Comment #23
LeeHunter CreditAttribution: LeeHunter commentedPerhaps the initial tour should also introduce the user to how Drupal conceives of the page structure.
See for example #1164702: “Block” has no meaning. (New users challenged by use of the term 'block')
There could be a tip that says something simple like "This is a block. You can configure it in the Structure settings."
Comment #24
lisarex CreditAttribution: lisarex commentedAttached is a yml file that I renamed to .txt extension.
The approach is to introduce them to the toolbar as well as the major parts of their home page. I plan to have a colleague review the text, so feel free to concentrate on the section labels and the flow for now; we can wordsmith the contents later. Am I missing anything?
Comment #25
larowlan@lisarex, any chance of a screencast for ease of review?
Comment #26
lisarex CreditAttribution: lisarex commentedScreencast: http://screencast.com/t/WRWGyCK8usC
Attached is a patch (thanks to xjm to reminded me I needed to to git add first ;)
Comment #27
larowlanPretty sure there are event listeners in the tour library that trigger before moving to the next tip, we could use that to make sure the menu was open when next was clicked on this item. Beyond my JavaScript skills though :)
typo
Do you think it is worth having a 'Continue this tour' modal tooltip at the end that lists other tours?
I think this tour should live in core/profiles/standard/config instead of toolbar.
It is referring to items (eg the search block) that are only available in standard.
This also allows other distros to ship their own front page tour and have toolbar enabled.
Thoughts?
Truly awesome to see this all coming into place!
Comment #28
larowlanCan tip 12 (edit) target the icon in the toolbar?
Comment #29
larowlanyou want data-class: 'contextual-toolbar-tab .icon-edit' here to target it
Comment #31
klonosThe z-index of the tips needs to be higher than the element revealed by the next tip. So that for example the 3rd tip does not go under the menu as shown at around 0:08 in that screencast.
Comment #32
clemens.tolboom@klonos see #2021361: tour should be in front of toolbar (z-index)
Comment #33
klonosThanx mate ;)
Comment #34
nick_schuch CreditAttribution: nick_schuch commentedTour needs tests since we now have #2028535
Comment #35
clemens.tolboomid must match file name id. In this case "id: toolbar" or change the file name to tour.tour.frontpage.yml"
This problem only arise when trying to edit a tour through Tour UI: #2072899: A mismatch between file name and tour ID fails to EDIT the file.
I suspect a bug in core tour module.
Comment #36
xtfer CreditAttribution: xtfer commented@nick_schuch and I reviewed the current toolbar tour patch provided by lisarex and agreed that is was far too detailed and too long for an initial user experience.
I'm going to investigate a slightly different approach that covers the main features in 5 or 6 steps, with each step linking to new tours of that feature.
Comment #37
nick_schuch CreditAttribution: nick_schuch commentedThanks @xtfer!
Some details for the query string can be found here (for the original work, it's also in the changelog):
https://drupal.org/node/1942576
This one is the for the token support:
https://drupal.org/node/2019469
I think the token [site:url] might be enough.
Comment #38
xtfer CreditAttribution: xtfer commentedCurrently partly blocked by #2073891: Customise tour loading by URL.
Comment #38.0
xtfer CreditAttribution: xtfer commentedUpdated issue summary.
Comment #38.1
pameeela CreditAttribution: pameeela commentedRemoves #2021361: tour should be in front of toolbar (z-index) from TODO (closed)
Comment #38.2
klonos...we do not remove issues from the todo lists unless they prove to be irrelevant to the issue. We already have issue status colors to indicate that issues are done or not.
Comment #38.3
klonos...never mind me. #2021361: tour should be in front of toolbar (z-index) was actually closed as "cannot reproduce".
Comment #39
alex.xequals CreditAttribution: alex.xequals commentedHad to fix a lot of the data-id's, replace paths with routes, made a few text changes, deleted some broken tour elements, and otherwise tested this to make sure it was working. Could still do with a few new inclusions, but is a good template for going forwards with.
Comment #40
wiifmtagging and removing old assignee.
Comment #41
wiifmRe-rolled this patch, changes include:
toolbar-
for consitancyTourTestBasic
, this proved to be quite challenging as the menu links in the tour required a lot fo modules and permissions to be setup, which took a long while to get right. I still cannot figure out how to place the search block in the sidebar, so 1 test continues to elude me (help please!). Marking as needs review just to verify there is actually 1 failing test and it's not just my dev box.Running the tests:
sudo -u www-data php core/scripts/run-tests.sh --verbose --url http://d8.localhost/ --file core/modules/toolbar/lib/Drupal/toolbar/Tests/Tour/FrontpageTourTest.php
Test results:
Comment #43
webchickThis one seems like a good thing to do, but postponed on #1921152-109: META: Start providing tour tips for other core modules. for now.
Comment #44
mgiffordComment #50
DrupalMattS CreditAttribution: DrupalMattS at Maricopa Community Colleges commented#nashville2018 Reopening as part of the core sprints in Nashville DrupalCon
Comment #52
clemens.tolboom- Normalising the title "Write tour integration"
- Added dependency section to tour yml
- moved tour into toolbarconfig/optional dir.
- Only 5/13 tips are shown on my frontpage.
Comment #54
clemens.tolboomLet's swap parent relation
Comment #55
clemens.tolboomAnd now with a none empty patch file.
- Added dependency section to tour yml
- moved tour into toolbarconfig/optional dir.
- Only 5/13 tips are shown on my frontpage.
Comment #56
clemens.tolboomComment #61
ridhimaabrol24 CreditAttribution: ridhimaabrol24 at Srijan | A Material+ Company for Drupal India Association commentedRerolling the patch for 9.1.x
Fixing failed test cases.
And adding a proper test method for frontend tour page.
All the 13 tips are now visible on the frontpage.
Comment #62
ridhimaabrol24 CreditAttribution: ridhimaabrol24 at Srijan | A Material+ Company for Drupal India Association commentedAdding @group annotation to test.
Comment #68
smustgrave CreditAttribution: smustgrave at Mobomo commentedPatch or MR doesn't apply anymore
The last patch or MR doesn't apply to the target branch, please reroll the code so that it can be reviewed by the automated testbot.
Comment #69
smustgrave CreditAttribution: smustgrave at Mobomo commentedRerolled and updated for 10.1.x
Adding a tests-only patch for the FrontPageTourTest file.
Comment #71
smustgrave CreditAttribution: smustgrave at Mobomo commentedBelieve existing test is covered
But NW for the nightwatch failures.
Comment #72
smustgrave CreditAttribution: smustgrave at Mobomo commentedBelieve the tour config was outdated so updated.
Comment #73
smustgrave CreditAttribution: smustgrave at Mobomo commentedFixed build error
Comment #76
quietone CreditAttribution: quietone at PreviousNext commentedThis extension is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
Comment #77
smustgrave CreditAttribution: smustgrave at Mobomo commentedDefinitely want to include