imho there should be a way to change the constants defined for the system requirements
as 'DRUPAL_MINIMUM_PHP' or 'DRUPAL_MINIMUM_PHP_MEMORY_LIMIT'.
there could be some complex install profiles that requires "more power" from the system.
for example there's a Commerce Kickstart issue about this : #1763632: The install needs to check Kickstart requirements before starting.

CommentFileSizeAuthor
#34 1772316-34.patch3.81 KBrpayanm
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,062 pass(es). View
#28 drupal-7.x-allow_profile_change_sys_req-1772316-28.patch3.83 KBxtfer
PASSED: [[SimpleTest]]: [MySQL] 40,272 pass(es). View
#23 drupal-7.x-allow_profile_change_sys_req-1772316-21.patch4.25 KBhswong3i
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-7.x-allow_profile_change_sys_req-1772316-21.patch. Unable to apply patch. See the log in the details link for more information. View
#23 drupal-8.x-allow_profile_change_sys_req-1772316-21.patch4.29 KBhswong3i
PASSED: [[SimpleTest]]: [MySQL] 57,993 pass(es). View
#18 drupal7-allow_change_system-requirements-1772316-18.patch3.8 KBjsacksick
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal7-allow_change_system-requirements-1772316-18.patch. Unable to apply patch. See the log in the details link for more information. View
#16 1772316_15-allow-profiles-to-override-php-requirements.patch5.11 KBtobyontour
PASSED: [[SimpleTest]]: [MySQL] 55,418 pass(es). View
#12 1772316_12-allow-profiles-to-override-php-requirements.patch4.98 KBcweagans
FAILED: [[SimpleTest]]: [MySQL] 54,160 pass(es), 0 fail(s), and 35 exception(s). View
#5 allow_change_system-requirements-1772316-5.patch3.83 KBvasike
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch allow_change_system-requirements-1772316-5.patch. Unable to apply patch. See the log in the details link for more information. View
#4 allow_change_system-requirements-1772316-4.patch3.88 KBvasike
PASSED: [[SimpleTest]]: [MySQL] 39,384 pass(es). View
#2 allow_change_system-requirements-1772316-2.patch3.8 KBvasike
FAILED: [[SimpleTest]]: [MySQL] 39,564 pass(es), 0 fail(s), and 423 exception(s). View
#1 allow_change_system-requirements_constants-1772316-1.patch605 bytesvasike
PASSED: [[SimpleTest]]: [MySQL] 39,391 pass(es). View
Membership dollars fund testing for the Drupal project. Drupal Association Learn more

Comments

vasike’s picture

Status: Active » Needs review
FileSize
605 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,391 pass(es). View

here is a patch that allows that
bad approach

are there other system requirements constants that could be changed?

vasike’s picture

Title: Allow install profiles to change the system requirements constants » Allow install profiles to change the system requirements
FileSize
3.8 KB
FAILED: [[SimpleTest]]: [MySQL] 39,564 pass(es), 0 fail(s), and 423 exception(s). View

here is a new approach for changing the php system requirements.
it uses the install_profile_info definition.

so what it's needed it's to specify new values in the info file of the profile

php = 5.3.12
php_memory_limit = 1234M

Status: Needs review » Needs work

The last submitted patch, allow_change_system-requirements-1772316-2.patch, failed testing.

vasike’s picture

Status: Needs work » Needs review
FileSize
3.88 KB
PASSED: [[SimpleTest]]: [MySQL] 39,384 pass(es). View

rebuilt the patch, i hope it's the right one

vasike’s picture

Version: 7.x-dev » 8.x-dev
FileSize
3.83 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch allow_change_system-requirements-1772316-5.patch. Unable to apply patch. See the log in the details link for more information. View

and here is the patch for Drupal 8

sun’s picture

Component: configuration system » install system
brantwynn’s picture

Issue tags: +Needs reroll

Looks like some D7 install profiles have been using #4 and it no longer applies to HEAD as of 7.22. :(

Added tags Needs reroll but there's no way to specify thats a D7 reroll since this is also being tracked as an 8.x issue - sorry.

cweagans’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll

The last submitted patch, allow_change_system-requirements-1772316-5.patch, failed testing.

cweagans’s picture

Status: Needs work » Needs review

We need to get this into D8 before we worry about D7. I requeued the patch in #5 (I doubt it'll pass - last test run was in September). If that fails, lets reroll that, get it committed, then deal with D7.

cweagans’s picture

Status: Needs review » Needs work

Ah, cross posted with the bot. So yeah, need to reroll that patch.

cweagans’s picture

FileSize
4.98 KB
FAILED: [[SimpleTest]]: [MySQL] 54,160 pass(es), 0 fail(s), and 35 exception(s). View

Let's give this a try. I moved around your new block of code in system.install so that we're not calling drupal_get_profile() multiple times - now it's just called once at the beginning of the function and used throughout.

cweagans’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1772316_12-allow-profiles-to-override-php-requirements.patch, failed testing.

tobyontour’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll

Made system.install default to DRUPAL_MINIMUM_PHP_MEMORY_LIMIT if it's not set in the profile (this is what caused the previous patch to fail).

tobyontour’s picture

FileSize
5.11 KB
PASSED: [[SimpleTest]]: [MySQL] 55,418 pass(es). View

Patch failed to attach to last post.

Tor Arne Thune’s picture

I'm not sure about "Drupal requires at least PHP %version.", as this is not true if the profile uses a different max version than Drupal. Drupal with [name of profile] requires this version, yes. Also the same issue in the message about the memory limit.

jsacksick’s picture

FileSize
3.8 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal7-allow_change_system-requirements-1772316-18.patch. Unable to apply patch. See the log in the details link for more information. View

Here's the rerolled patch for d7, against the latest dev

Status: Needs review » Needs work

The last submitted patch, drupal7-allow_change_system-requirements-1772316-18.patch, failed testing.

hswong3i’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal7-allow_change_system-requirements-1772316-18.patch, failed testing.

jsacksick’s picture

The issue is tagged with the 8.x version which means that the patch will obviously fail..., that's why I didn't change the status earlier... I rerolled the patch for Commerce Kickstart

hswong3i’s picture

FileSize
4.29 KB
PASSED: [[SimpleTest]]: [MySQL] 57,993 pass(es). View
4.25 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-7.x-allow_profile_change_sys_req-1772316-21.patch. Unable to apply patch. See the log in the details link for more information. View

Patch(es) reroll via all latest dev.

hswong3i’s picture

Status: Needs work » Needs review
David_Rothstein’s picture

Note: #309040: Add hook_requirements_alter() is another way to do this that should be a lot more flexible.

David_Rothstein’s picture

manuelBS’s picture

In some installations we have problems with mysql max_allowed_packet size set to low. Wouldn't ist make sense to set this settings also as requirement if needed?

xtfer’s picture

Issue summary: View changes
FileSize
3.83 KB
PASSED: [[SimpleTest]]: [MySQL] 40,272 pass(es). View

Updated for D7, as the patch was not applying.

Status: Needs review » Needs work

The last submitted patch, 28: drupal-7.x-allow_profile_change_sys_req-1772316-28.patch, failed testing.

xtfer’s picture

Version: 8.x-dev » 7.x-dev
Status: Needs work » Needs review

Switching to 7 to run the test.

xtfer’s picture

xtfer’s picture

Version: 7.x-dev » 8.x-dev

Back to 8.x

jhedstrom’s picture

Status: Needs review » Needs work
Issue tags: +Needs reroll
rpayanm’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
3.81 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,062 pass(es). View

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.