Fix grammar 'a' to 'an' when necessary

I applied the patch and it worked cleanly.

I set it to needs work because of your #5 comment.

Also, how can a reviewer know that all of them are fixed in a given patch? If you have a repeatable way you used to find them it will help to mention that in the issue summary.

Oh sorry for #6 - I meant "needs review". 'a EntityType object' should be 'an'.

GoZ: please share the regex you used, so reviewers can evaluate that all files and all possible cases were hit.

See my comment on #2574981-79: Fix grammar ("an URL" should be "a URL") and consistent use of URL (not "url" / "Url") in documentation only, part 1

Are you catching multiline instances like?:

//this is an
//cat

Plus this issue should also do the opposite: 'an' to 'a'.

Edited: patch/issue

+++ b/core/lib/Drupal/Core/DependencyInjection/ClassResolverInterface.php
@@ -3,7 +3,7 @@
+ * Provides an interface to get an instance of a class with dependency injection.

This change makes the comment longer than 80 chars ... you should break the last work to a new line

Other than that, this is RTBC from me

Applying correction from #20

Interdiff attached

Looks good. Reviewed it manually.

Good sleuthing and thanks for documenting how you created and reviewed the patch. #25 is especially helpful.

I thought about whether we could create a coder rule to detect this (in order to meet https://www.drupal.org/core/scope#coding-standards) but since it depends on the pronunciation and on whether the following word is an acronym, any rule would have false positives.

Since this is a grammar fix that can disrupt a lot of other patches, it's the sort of change we make during our release candidate phases. So, I'm postponing it for now and marking it as an RC target. The RC phase begins after March 1.

Okay, we can look at this again during RC. I'll send a retest. The patch will probably need to be recreated.

Yep. Let's recreate a new patch using the instructions in #25, rather than trying to reroll the current one. Thanks!

Should we make the changes in #25 or do the whole thing again i.e each and every change.

+++ b/core/tests/Drupal/KernelTests/Core/Entity/EntityAutocompleteTest.php
@@ -79,13 +79,13 @@ function testEntityReferenceAutocompletion() {
+    // Try to autocomplete an entity label with both a comma, a slash and markup.

Line exceeding 80 characters.

as #38 failed

Re-rolled.

@boaloysius I'm afraid you can't set to RTBC because you have contributed a patch to this issue.

Checked, everything seems ok.

Rerolled #43
Simple rebase fixed it.

Applied the patch in #50. Worked fine for 8.3.x

For 8.4.x I got this error

error: while searching for:
    }

    // add_condition determines whether a single expression is enough(FALSE) or the
    // conditions should be added via an db_or()/db_and() (TRUE).
    $add_condition = TRUE;
    if ($operator == 'not') {
      $value = NULL;

error: patch failed: core/modules/views/src/ManyToOneHelper.php:269

Rerolled from changes in 8.4, should work on 8.4 now.

Reroll Patch redone, previous one had one thing missing also, this must be tested against 8.4.x but it's option isn't here to test with.
Might fail with 8.3.x

Test against 8.4.x

Tested on 8.4.x, got an error please see the screen.

@lomasr I tried to replicate the error, however using "git apply" all looks good for me and I can not reproduce that.

Patch #56 works fine for me too.

Since the previous patch was changing a few file which is not included in a basic Drupal core site, so removed them and re-rolled with a new patch.

Works fine for me. Let the bot give it a try now.

To make sure that I would be able to get all 'a [aeiou]' occurrences in comments I used the following command:

find . -type f \( -name '*.inc' -or -name '*.module' -or -name '*.php' \) -exec grep -e '\(\*\|\/\/\).*\b\(A\|a\) \$\?\([AEIOU]\|[aeiou]\)' {} \+ | wc -l

It show me that before applying the 'fix_grammar_a_to_an-2851394-63.patch' patch there were 1298 occurrences.
After applying the patch, it was reduced to 1162.

To help us find where these mistakes are we could use the following command.

find . -type f \( -name '*.inc' -or -name '*.module' -or -name '*.php' \) -exec grep --color=auto -e '\(\*\|\/\/\).*\b\(A\|a\) \$\?\([AEIOU]\|[aeiou]\)' {} \+

hgunicamp, keeping things you shared, I have corrected those wrong statements. Thanks for your review. I have created a new patch with new changes as well.

I tried to solve this problem as "dropping down dominoes pieces" using the 'sed' command, but I was able to reduce to 963 occurrences. The chain reaction was not so explosive as I thought.
The command I used was:

sed -i 's/\(\*\|\/\/\)\(.*\) \(A\|\a\) \([AEIOU]\|[aeiou]\)/\1\2 \3n \4/g' $(find . -type f \( -name '*.inc' -or -name '*.module' -or -name '*.php' \) -exec grep -e '\(\*\|\/\/\).*\b\(A\|a\) \$\?\([AEIOU]\|[aeiou]\)' {} \+ | cut -f1 -d':' | uniq )

This command bring back things like 'an url' or 'module An and B' that I fixed by hand.

Work is still need.

I'm sorry @akashkrishnan. I had not updated my page and used the same name you used for a patch (fix_grammar_a_to_an-2851394-66.patch). Let's upload again.

I'm using 'fix_grammar_a_to_an-2851394-70.patch'.

Following the "dropping down dominoes" strategy, I used a command to replace "an " for "a ". The command also avoids replacing expressions like "an (html|http|xml|xss)".

sed -i 's/\(\*\|\/\/\)\(.*\) \(A\|a\)n \([B-DF-HJ-NP-TV-Z]\|[b-df-hj-np-tv-z]\)/\1\2 \3 \4/;s/ \(A\|a\) \([Hh][Tt][Mm][Ll]\|[Xx][Mm][Ll]\|[Hh][Tt][Tt][Pp]\|[Xx][Ss][Ss]\)/ \1n \2/g' $(find . -type f \( -name '*.inc' -or -name '*.module' -or -name '*.php' \) -exec grep -e '\(\*\|\/\/\).* \(A\|a\)n \([B-DF-HJ-NP-TV-Z]\|[b-df-hj-np-tv-z]\)' {} \+ | cut -f1 -d':' | uniq)

The command
find . -type f \( -name '*.inc' -or -name '*.module' -or -name '*.php' \) -exec grep -e '\(\*\|//\).* \(A\|a\) \([AEIOU]\|[aeiou]\)' {} \+ | grep -v -e '\(A\|a\) [Uu][Rr][Ll]' | wc -l

Shown me the there are 646 "a " remaining occurrences.

I've just done a very quick skim review of the first couple of changes in the patch in #73, and it includes a lot of unnecessary changes that actually change the sentence from correct to incorrect. For example:

1. +++ b/core/core.api.php
   @@ -1692,7 +1692,7 @@
   - * documentation. A user of your API can usually name their callback function
   + * documentation. An user of your API can usually name their callback function
   

   "A user" is correct.

2. +++ b/core/core.api.php
   @@ -2241,7 +2241,7 @@ function hook_rebuild() {
   - *   A one-dimensional array of \Drupal\Core\Config\ConfigImporter method names
   + *   An one-dimensional array of \Drupal\Core\Config\ConfigImporter method names
   

   "A one-dimensional" is correct.

3. +++ b/core/includes/common.inc
   @@ -289,7 +289,7 @@ function format_size($size, $langcode = NULL) {
   - *   A UNIX timestamp to format.
   + *   An UNIX timestamp to format.
   

   "A UNIX timestamp" is correct

Thanks @nicrodgers.

I found and corrected the mistakes you pointed.

I made another search excluding expressions like "a user, a url, a one, a unix, an html, an xml, an http, an xss".

Let me know if there are any more collateral damages from my approach.

Thanks @gaurav.kapoor for trying to fix my mess.
Actually the mistakes are in the commentaries of functions 'module_a_post_update_a' and 'module_a_post_update_b', where my patch replaced 'Module A update' for 'Module An update'.

Sending a patch to fix this collateral damage.

I'll queue this up for this weekend's Drupalcamp Colorado and see about having somebody look at it on Sunday.

@vegantriathlete great! I think this would really benefit from a manual review and manual fix - the automated/bulk solutions seem to be creating more bugs than they are fixing.

Could not apply patch #79 on Drupal 8.5.x, throws some errors while applying the patch.

Hello Venkatesh Rajan.J:

Thank you for helping. In order that your support can be even more useful let me suggest the following. When a patch does not apply it is not necessary to post evidence (code screenshots are seldom needed). Instead add the tag "Needs reroll". It is even more helpful to reroll it, if you are comfortable doing so.

Thank you!

Re-rolled. Including correcting from "an user", "an unique" and "an UID".

Fixed a couple of coding standards errors.

EDIT: Unable to replicate the test failure locally (appears to have been a testbot fault).

@Jo Fitzgerald,

Thanks for the patch. It works well. PFA for the same.

@Venkatesh Rajan.J I think that we have to check again these occurrences.
The last patch before @cilefen categorized this issue as "Needs reroll" is from May 4.

Attempting a patch reroll against 8.6.x...

Seems I left some code during conflict resolution in ConfirmDeleteMultiple.php. That was the only file with conflicts during rebase.

Thanks for this. Upon reviewing, I found a few items that need some more work eg the ones below. If you could fix these it would be much appreciated.

--- a/core/includes/common.inc
+++ b/core/includes/common.inc
@@ -198,15 +198,15 @@ function valid_email_address($mail) {
- * Strips dangerous protocols from a URI and encodes it for output to HTML.
+ * Strips dangerous protocols from an URI and encodes it for output to HTML.

"A URI" is correct

--- a/core/includes/database.inc
+++ b/core/includes/database.inc
@@ -522,7 +522,7 @@ function db_and() {
- *   a \Drupal\Core\Database\Query\Condition object, specifying an XOR
+ *   a \Drupal\Core\Database\Query\Condition object, specifying a XOR

Presuming it's pronounced "ex-or", then "an XOR" is correct

--- a/core/includes/file.inc
+++ b/core/includes/file.inc
@@ -77,7 +77,7 @@
- * Returns the scheme of a URI (e.g. a stream).
+ * Returns the scheme of an URI (e.g. a stream).

"A URI" is correct. This change has been made 8 times in this file, all are incorrect.

--- a/core/includes/install.core.inc
+++ b/core/includes/install.core.inc
@@ -2048,7 +2048,7 @@ function install_check_requirements($install_state) {
-        // security risk. It would also cause a usability problem, since site
+        // security risk. It would also cause an usability problem, since site

"A usability problem" is correct.

diff --git a/core/lib/Drupal.php b/core/lib/Drupal.php
index 61982c3885..c676aac3f3 100644
--- a/core/lib/Drupal.php
+++ b/core/lib/Drupal.php
@@ -16,7 +16,7 @@
- * class acts as a unified global accessor to arbitrary services within the
+ * class acts as an unified global accessor to arbitrary services within the

"A unified" is correct

--- a/core/lib/Drupal/Component/ClassFinder/ClassFinder.php
+++ b/core/lib/Drupal/Component/ClassFinder/ClassFinder.php
@@ -5,7 +5,7 @@
 use Doctrine\Common\Reflection\ClassFinderInterface;
 
 /**
- * A Utility class that uses active autoloaders to find a file for a class.
+ * An Utility class that uses active autoloaders to find a file for a class.

"A Utility class" is correct

Hi! I applied the fix mentioned in #98. Upon applying the patch to the latest 8.6.x code, `git apply` didn't work so I used `patch -p1` and had two rejects which are for core/lib/Drupal/Component/Gettext/PoStreamReader.php and core/modules/simpletest/src/AssertContentTrait.php. For core/lib/Drupal/Component/Gettext/PoStreamReader.php, I just manually added the changes from the patch while core/modules/simpletest/src/AssertContentTrait.php didn't need to be changed because a recent commit removed all the code inside this file as stated in it's docblock.

Hope everything is in order.

@ leolando.tan I also faced same issue of apply patch but after applying it's working fine

NOTE: This comment should in no way derail, bikeshed, delay, conflate, blow up, distract from this effort...

Once this is committed I wonder if there a way to add a build check to D.O. so that future patches are checked using similar REGEXes as were used here to warn (break build?) people about making the same mistake. It would be a shame to do this work so thoroughly only to have a future patch introduce the same mistakes a week later.

... If not, then isn't possible we are being overly thorough here? Why not just commit what we have and move on?

Just thinkin' about a possible followup

1. +++ b/core/includes/bootstrap.inc
   @@ -363,7 +363,7 @@ function format_string($string, array $args) {
   + * end up in locations that are potentially unsafe; A onerror attribute that
   

   There wasn't any change required here. "An onerror" is the right usage. Please change it back

2. +++ b/core/includes/install.core.inc
   @@ -1372,7 +1372,7 @@ function install_download_translation(&$install_state) {
   + * Attempts to get a file using an HTTP request and to store it locally.
   

   This should be "a HTTP request". Please make the required changes.

3. +++ b/core/lib/Drupal/Component/Gettext/PoStreamReader.php
   @@ -251,7 +251,7 @@ private function readLine() {
   +        // The first line might come with an UTF-8 BOM, which should be removed.
   

   "a UTF-8 BOM" is the right usage. Please change this back.

4. +++ b/core/lib/Drupal/Component/Transliteration/PhpTransliteration.php
   @@ -169,7 +169,7 @@ protected static function ordUTF8($character) {
   -   *   The character code of a Unicode character.
   

   This should be "a unicode" character. Please change this back

5. +++ b/core/lib/Drupal/Component/Utility/Html.php
   @@ -445,7 +445,7 @@ public static function escape($text) {
   +   *   The root URL, which has an URI scheme, host and optional port.
   

   This should be changed to "The root URL, which has a URI scheme,host and an optional port"

6. +++ b/core/lib/Drupal/Component/Utility/Unicode.php
   @@ -272,7 +272,7 @@ public static function truncateBytes($string, $len) {
   -   * Counts the number of characters in a UTF-8 string.
   

   "a UTF-8 string" is the right usage. Please change it back.

7. +++ b/core/lib/Drupal/Component/Utility/Unicode.php
   @@ -293,7 +293,7 @@ public static function strlen($text) {
   +   * Converts an UTF-8 string to uppercase.
   

   Please change this back to "a UTF-8 string"

8. +++ b/core/lib/Drupal/Component/Utility/Unicode.php
   @@ -315,7 +315,7 @@ public static function strtoupper($text) {
       *
   

   Please change this to "a UTF-8 string" back. This would be the right usage.

9. +++ b/core/includes/common.inc
   @@ -204,9 +204,9 @@ function valid_email_address($mail) {
     * @return string
   ...
     *   attribute value. Because it is already encoded, it should not be set as a
   

   This should be "A URI". Please change it back.

10. +++ b/core/lib/Drupal/Component/Utility/Unicode.php
    @@ -350,7 +350,7 @@ public static function ucfirst($text) {
    -   * Converts the first character of a UTF-8 string to lowercase.
    

    Please change this back to "a UTF-8 string".

11. +++ b/core/lib/Drupal/Component/Utility/Unicode.php
    @@ -488,7 +488,7 @@ public static function substr($text, $start, $length = NULL) {
    -   * Truncates a UTF-8-encoded string safely to a number of characters.
    

    Please change this back to "truncates a UTF-8-encoded" string

12. +++ b/core/lib/Drupal/Component/Utility/Unicode.php
    @@ -677,7 +677,7 @@ public static function caseFlip($matches) {
    +   * end up in locations that are potentially unsafe; A onerror attribute that
    

    Please change this back to "An onerror attribute"

13. +++ b/core/lib/Drupal/Component/Utility/UrlHelper.php
    @@ -304,7 +304,7 @@ public static function setAllowedProtocols(array $protocols = []) {
    +   * Strips dangerous protocols (for example, 'javascript:') from an URI.
    

    Please change this to "a URI"

14. +++ b/core/lib/Drupal/Component/Uuid/Com.php
    @@ -3,7 +3,7 @@
    + * Generates an UUID using the Windows internal GUID extension.
    

    Please change this back to "a UUID"

15. +++ b/core/lib/Drupal/Component/Uuid/Pecl.php
    @@ -3,7 +3,7 @@
    - * Generates a UUID using the PECL extension.
    

    Please change this back to "a UUID"

16. +++ b/core/lib/Drupal/Component/Uuid/UuidInterface.php
    @@ -8,7 +8,7 @@
    +   * Generates an Universally Unique IDentifier (UUID).
    
    +++ b/core/lib/Drupal/Core/Access/AccessManager.php
    @@ -55,7 +55,7 @@ class AccessManager implements AccessManagerInterface {
    -   * Constructs a AccessManager instance.
    

    This should be changed back to "a AccessManager instance"

17. +++ b/core/lib/Drupal/Component/Utility/Unicode.php
    @@ -337,7 +337,7 @@ public static function strtolower($text) {
    +   * Capitalizes the first character of an UTF-8 string.
    ...
        * @param string $text
    

    "a UTF-8 string" would be the right usage. Please change it back.

Fixed all items from #103
8.6 has many changes since the last patch so I have not added the interdiff file.

8.6 has many changes since the #100 patch, so #104 patch had fallen.
I recreated patch for current 8.6 and added all notes from #103

Patch #107 failed

One more time the patch no longer applies.
Rerolled #107

There is a recurring problem with the correct usage of 'a/an' before 'http' because the pronunciation of the letter 'H' is disputed. Although many people do consider it to be pronounced /heɪtʃ/ (which would necessitate the article 'a'), the standard and far more widespread pronunciation is /eɪtʃ/ (requiring the article 'an'). Source: https://en.wikipedia.org/wiki/H#Name_in_English

Thus there are problems with this patch (as well as various other false positives), and with the list in #103. I'll reroll it...

Rerolled 110, which reverts several things related to false positive 'a'/'an' issues, a few other wording problems and some comment line length issues (but only those line length issues that I spotted easily, possibly not a complete list).

(For the record, I'm a mother tongue (British) English speaker.)

Thanks @martin_q!

1.

@@ -8,7 +8,7 @@
 class PluginNotFoundException extends PluginException {
 
   /**
-   * Construct an PluginNotFoundException exception.
+   * Construct a PluginNotFoundException exception.

--> should be constructs, no?

2.

--- a/core/modules/config/tests/src/Functional/ConfigExportImportUITest.php
+++ b/core/modules/config/tests/src/Functional/ConfigExportImportUITest.php
@@ -167,7 +167,7 @@ public function testExportImport() {
     $this->assertText($this->contentType->label());
 
     $this->drupalPostForm(NULL, [], 'Import all');
-    // After importing the snapshot has been updated an there are no warnings.
+    // After importing the snapshot has been updated there are no warnings.

--> I believe this should have been corrected to 'has been updated *and* there are no warnings'.

3.

--- a/core/modules/dblog/tests/src/Functional/ConnectionFailureTest.php
+++ b/core/modules/dblog/tests/src/Functional/ConnectionFailureTest.php
@@ -23,7 +23,7 @@ public function testConnectionFailureLogging() {
     // MySQL errors like "1153 - Got a packet bigger than 'max_allowed_packet'
     // bytes" or "1100 - Table 'xyz' was not locked with LOCK TABLES" lead to a
     // database connection unusable for further requests. All further request
-    // will result in an "2006 - MySQL server had gone away" error. As a
+    // will result in a "2006 - MySQL server had gone away" error. As a

--> while not exactly within the scope of this round of corrections, the error reads 'MySQL server has gone away', not 'had'.

4.

--- a/core/modules/file/src/Tests/FileFieldWidgetTest.php
+++ b/core/modules/file/src/Tests/FileFieldWidgetTest.php
@@ -479,7 +479,7 @@ public function testWidgetElement() {
 
     $elements = $this->xpath($xpath);
 
-    // If the field has at least a item, the table should be visible.
+    // If the field has at least an item, the table should be visible.

--> Should this not have been corrected to 'at least *one* item'?

5.

@@ -131,7 +131,7 @@ public function testDefaultLangcode() {
 
     // Check the default value of a language field when authors preferred option
     // is selected.
-    // Create first an user and assign a preferred langcode to him.
+    // Create first a user and assign a preferred langcode to him.

--> again strictly out of scope, but: incorrect word order, and pronoun issue.
--> suggestion: 'First create a user, then assign them a langcode'.

6.

--- a/core/modules/system/tests/src/Functional/Database/SelectPagerDefaultTest.php
+++ b/core/modules/system/tests/src/Functional/Database/SelectPagerDefaultTest.php
@@ -14,7 +14,7 @@ class SelectPagerDefaultTest extends DatabaseTestBase {
   /**
    * Confirms that a pager query returns the correct results.
    *
-   * Note that we have to make an HTTP request to a test page handler
-   * because the pager depends on GET parameters.
+   * Note that we have to make a HTTP request to a test page handler because the
+   * pager depends on GET parameters.
    */
   public function testEvenPagerQuery() {
@@ -48,7 +48,7 @@ public function testEvenPagerQuery() {
   /**
    * Confirms that a pager query returns the correct results.
    *
-   * Note that we have to make an HTTP request to a test page handler
-   * because the pager depends on GET parameters.
+   * Note that we have to make a HTTP request to a test page handler because the
+   * pager depends on GET parameters.

--> As you indicated in comment #111, use 'an' before 'HTTP', so the above correction should be undone.

7.

--- a/core/tests/Drupal/KernelTests/Core/Entity/Element/EntityAutocompleteElementFormTest.php
+++ b/core/tests/Drupal/KernelTests/Core/Entity/Element/EntityAutocompleteElementFormTest.php
@@ -274,7 +274,7 @@ public function testValidEntityAutocompleteElement() {
   public function testInvalidEntityAutocompleteElement() {
     $form_builder = $this->container->get('form_builder');
 
-    // Test 'single' with a entity label that doesn't exist
+    // Test 'single' with an entity label that doesn't exist

--> Missing period at the end.

8.

--- a/core/tests/Drupal/Tests/Core/Form/FormStateTest.php
+++ b/core/tests/Drupal/Tests/Core/Form/FormStateTest.php
@@ -120,7 +120,7 @@ public function providerTestSetErrorByName() {
     return [
       // Only validate the 'options' element.
       [[['options']], ['options' => '']],
-      // Do not limit an validation, and, ensuring the first error is returned
-      // for the 'test' element.
+      // Do not limit a validation, and ensuring the first error is returned for
+      // the 'test' element.

--> should either be ', and ensure [...]' or ', ensuring [...]'
--> 'Do not limit *a* validation' sounds strange but might be correct if we are talking about individual, discrete validations, rather than 'all/any validation' to be skipped.

I tried applying the patch mentioned in #113. It throws an error.
We need reroll. Added the needs reroll tag.
Here is the error msg screenshot attached.

Here is a re-roll of #113, not including the changes suggested by @jpoesen.

There were a few changed file paths:

core/modules/editor/src/Tests/EditorAdminTest.php -> core/modules/editor/tests/src/Functional/EditorAdminTest.php
core/modules/editor/src/Tests/EditorLoadingTest.php -> core/modules/editor/tests/src/Functional/EditorLoadingTest.php
core/modules/system/src/Tests/System/HtaccessTest.php -> core/modules/system/tests/src/Functional/System/HtaccessTest.php
core/modules/system/src/Tests/System/ThemeTest.php -> core/modules/system/tests/src/Functional/System/ThemeTest.php

The text changes in core/tests/Drupal/Tests/BrowserTestBase.php did not apply and no longer exist (so not included in this patch).

The rest of the changes were line numbers.

Includes suggested changes from @jpoesen in #115

Thanks, all. I agree with all of @jpoesen's points - these were all either due to me being too cautious about changing meaning of things I don't know about, or me reading the texts too quickly. And in the case of that "a HTML" I must just have been confused. Definitely 'an HTML"! :)

Retesting the patch in #120 in 8.7.x

Couldn't apply the patch provided in #120

Since the patch no longer applies, tagging for reroll

Re-rolled

The drupal bot tester says the patch adds nine additional coding standard messages

@oknate is correct, there are coding standard errors that need to be fixed. Setting to NW.

It also looks like there's some unintentional changes/reversions in core/modules/tour/js/tour.es6.js and core/modules/quickedit/js/models/EntityModel.es6.js in #127.

Reroll with two small fixes (comments longer than 80 characters).

Adding some more indefinite article fixes.

Latest patch has all coding standards fixed, Thanks oknate.

Tagging for upcoming contribution days.

Patch applies cleanly and changes look good.

RTBC +1

I have tested this patch#133 and working fine along with the coding standards.

Patch Looks good

+++ b/core/modules/simpletest/src/Exception/MissingGroupException.php
@@ -3,7 +3,7 @@
- * Exception thrown when a simpletest class is missing an @group annotation.
+ * Exception thrown when a simpletest class is missing a @group annotation.

For me - at least according to the rules this conversion is wrong. When saying this out loud I would say "at-group annotation" so following the general rule from https://english.blogoverflow.com/2011/11/articles-a-vs-an/ - @group starts with a vowel sound and so should be an @group annotation. This why it is an HTML because saying H you say "aitch" which is starts with a vowel sound.

Note in core we have stuff like

 * EntityType, look for class files that have an @ annotation section using the

 *   with \Drupal\Component\Render\FormattableMarkup and an @variable

And

 *   a @group annotation, which gives information about the test.

So we're not consistent and this patch doesn't adjust any of this to be consistent.

Updated, I searched the codebase for "a @" and found a few that I think should be changed, based on Alex Pott's comment.

Adding a few more changes. Not sure why I missed these in the last patch.

+++ b/core/tests/Drupal/Tests/Component/Render/FormattableMarkupTest.php
@@ -51,7 +51,7 @@ public function testCount() {
    * Custom error handler that saves the last error.
-   *
+   * an @group
    * We need this custom error handler because we cannot rely on the error to
    * exception conversion as __toString is never allowed to leak any kind of

Looks like something crept in by mistake.

Fixing the "butterfingers" typo in #146, also making a change

- an (array of) SelectInterface(s)
+ a SelectInterface or an array of SelectInterfaces

I think the second way is clearer.

Review and can confirm that the patch applies. One patch adds an where appropriate and the diff can show this appropriately.

Patch looks good.
RTBC +1

Random testbot fail.

Patch in #147 no longer applies, needs a reroll.

Reviewing patch in #157 and everything seemed fine but looking at:

--- a/core/tests/Drupal/KernelTests/Core/Lock/LockTest.php
+++ b/core/tests/Drupal/KernelTests/Core/Lock/LockTest.php
@@ -48,7 +48,7 @@ public function testBackendLockRelease() {
 
     $this->lock->release('lock_b');
 
-    // Test acquiring an releasing a lock with a long key (over 255 chars).
+    // Test acquiring a releasing a lock with a long key (over 255 chars).

I think "Test acquiring a releasing lock with a long key (over 255 chars)." would be correct grammar? (I am not an english native speaker)

Patch in #157 no longer applies, needs a reroll along with the suggestion in #158.