Problem/Motivation

Wording is wrong in attributes documentation. 'a' should be 'an'.

/**
   * The url which is used for the image in this Tip.
   *
   * @var string
   *   A url used for the image.
   */
  protected $url;

  /**
   * The alt text which is used for the image in this Tip.
   *
   * @var string
   *   A alt text used for the image.
   */
  protected $alt;
CommentFileSizeAuthor
#4 wrong_wording_in-2851063-4.patch985 bytesgoz
#2 wrong_wording_in-2851063-2.patch1.2 KBgoz

Comments

GoZ created an issue. See original summary.

goz’s picture

goz commented
Status: Active » Needs review
Issue tags: +Quick fix, +Quickfix, +Documentation
StatusFileSize
new wrong_wording_in-2851063-2.patch1.2 KB
shadcn’s picture

shadcn commented 
+++ b/core/modules/tour/tests/tour_test/src/Plugin/tour/tip/TipPluginImage.php
@@ -19,7 +19,7 @@ class TipPluginImage extends TipPluginBase {
+   *   An url used for the image.

Hmm, I believe "A url" is correct here.

Here's a related issue: #2574981: Fix grammar ("an URL" should be "a URL") and consistent use of URL (not "url" / "Url") in documentation only, part 1.

goz’s picture

goz commented
StatusFileSize
new wrong_wording_in-2851063-4.patch985 bytes

Right arshadcn, i had missed this grammar rule for url.
Still stay the alt one

goz’s picture

goz commented
Title: Wrong wording in tour_test TipPluginImage doc » Fix grammar 'a alt' in tour_test TipPluginImage doc
riddhi.addweb’s picture

riddhi.addweb commented
Assigned: Unassigned » riddhi.addweb
shadcn’s picture

shadcn commented
Status: Needs review » Reviewed & tested by the community

Thanks @GoZ. Looking good.

riddhi.addweb’s picture

riddhi.addweb commented
Assigned: riddhi.addweb » Unassigned
th_tushar’s picture

th_tushar commented

Looks good. +1

cilefen’s picture

cilefen commented
Status: Reviewed & tested by the community » Closed (duplicate)

We are not going to commit this and #2851394: Fix grammar 'a' to 'an' when necessary