Problem/Motivation

core/themes/claro/css/components/form.css does not inline with core/themes/claro/css/components/form.pcss.css

Proposed resolution

Run cd core && npm run build:css to generate a new .css file from the .pcss.css file

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3122663-5.gif2.32 MBjungle
#4 3122663-4.gif35.03 KBjungle
#2 3122663-2.patch364 bytesjungle

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Assigned: jungle » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3122663-2.patch364 bytes
kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented

On my side i can't reproduce this issue

drupal $ git status
On branch 8.9.x
Your branch is up-to-date with 'origin/8.9.x'.
nothing to commit, working directory clean

drupal $ git pull --rebase
Current branch 8.9.x is up to date.

drupal $ cd core/

core $ yarn && yarn build:css

core $ git status
On branch 8.9.x
Your branch is up-to-date with 'origin/8.9.x'.
nothing to commit, working directory clean
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
StatusFileSize
new 3122663-4.gif35.03 KB

@kostyashupenko. thanks for reviewing!

It happens to me, see the gif (wrong gif, edited, reupload next)

not sure whether removing core/node_modules and reinstall node_modules helps reproducing on your local.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
StatusFileSize
new 3122663-5.gif2.32 MB

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

Aha, found it

It only happens using npm to install packages.

gyp: No Xcode or CLT version detected!
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1

It is an issue of my local env. using yarn, it's ok.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

Fixed the gyp error by reinstall the command line tools.

Confirmed that using npm to install the packages -> reproduced. However, using yarn to install the packages, everything is ok.

As yarn is preferred with core development, "Drupal core using PostCSS for development" https://www.drupal.org/node/3084859

Closing this issue is ok for me.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Closed (works as designed)

yarn follows yarn.lock, which pins specific versions of packages (like composer.lock does). We don't have a lockfile for npm so you will get the latest versions of packages, at least one of which must be newer and causes the different behaviour.

Closing as suggested in #7.