Problem/Motivation

A followup of #2851394: Fix grammar 'a' to 'an' when necessary, pointed by @longwave in #259, as there is a UI change, tagging "Needs usability review"

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3182122-applied_patch-2.png29.56 KBabhijith s
#2 3182122-2.patch5.8 KBjungle

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Active » Needs review
StatusFileSize
new 3182122-2.patch5.8 KB
abhijith s’s picture

abhijith s commented
StatusFileSize
new 3182122-applied_patch-2.png29.56 KB

Applied patch #2 and it worked successfully. All the "in a frame" is changed to "in an iframe" after this patch.

Checking patch core/modules/media/media.install...
Checking patch core/modules/media/src/Form/MediaSettingsForm.php...
Checking patch core/modules/media/src/Plugin/media/Source/OEmbed.php...
Checking patch core/modules/media/tests/src/Functional/MediaSettingsTest.php...
Checking patch core/modules/media/tests/src/FunctionalJavascript/MediaSourceOEmbedVideoTest.php...
Applied patch core/modules/media/media.install cleanly.
Applied patch core/modules/media/src/Form/MediaSettingsForm.php cleanly.
Applied patch core/modules/media/src/Plugin/media/Source/OEmbed.php cleanly.
Applied patch core/modules/media/tests/src/Functional/MediaSettingsTest.php cleanly.
Applied patch core/modules/media/tests/src/FunctionalJavascript/MediaSourceOEmbedVideoTest.php cleanly.

Adding screenshots for searching "in a frame" in the module folder, the result shows no remaining instances.
after

abhijith s’s picture

abhijith s commented
Status: Needs review » Reviewed & tested by the community
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

This is tagged for a usability review and I don't see that that has happened.

And this will need an IS update when the review is complete.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

vikashsoni’s picture

vikashsoni commented

#2 patch applied in durpal-9.3.x-dev successfully
After patch 'in a frame ' changed to ' in an iframe '
Thanks for the patch

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

chris matthews’s picture

chris matthews commented
Issue tags: -Needs usability review

Personally, I don't think this really needs usability review for this type change but please correct me if I'm wrong.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.