Problem/Motivation

The Commerce Payment module allows you to translate the display title but does not allow you to override the original source language display title (EN version).

This module provides a configuration UI where you can define the display title for each language, including the possibility to override the source language display title.

https://www.drupal.org/sandbox/nicoknaepen/2684959

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/nicoknaepen/2684959.git commerce_payment_alter
cd commerce_payment_alter

Manual reviews of other project applications

https://www.drupal.org/node/2407833#comment-11235391
https://www.drupal.org/node/2702713#comment-11227579
https://www.drupal.org/node/2696141#comment-11227591
https://www.drupal.org/node/2688692#comment-11227645

Comments

nico.knaepen created an issue. See original summary.

PA robot’s picture

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2684987

Project 2: https://www.drupal.org/node/2673638

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

Status: Needs review » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2673638

Project 2: https://www.drupal.org/node/2684987

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

nico.knaepen’s picture

Status: Closed (duplicate) » Needs review
nico.knaepen’s picture

Issue summary: View changes
klausi’s picture

Status: Needs review » Closed (duplicate)

As the bot says please only keep one application open.

nico.knaepen’s picture

Status: Closed (duplicate) » Needs review

I will close the other project.

nico.knaepen’s picture

Issue summary: View changes
nico.knaepen’s picture

Issue summary: View changes
novitsh’s picture

Status: Needs review » Reviewed & tested by the community

Automated Review

Pareview.sh has found one issue: Duplicate entry for "configure" in info file

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.

This review uses the Project Application Review Template.

novitsh’s picture

Status: Reviewed & tested by the community » Needs work

Setting to NW because the duplicate configure in .info file should be removed.

nico.knaepen’s picture

Status: Needs work » Needs review

Novitsh,

Thanks for reviewing. The Issue regarding the duplicate configure rule is solved.

vipul.patil7888’s picture

Hi nico.knaepen,

I reviewed your module but it seems hook_help() is not there. Please add hook_help().

Thanks,
Vipul

nico.knaepen’s picture

Status: Needs review » Needs work
nico.knaepen’s picture

Status: Needs work » Needs review

@vipul.patil7888,

Thanks for reviewing. I added hook_help to the module.

novitsh’s picture

Status: Needs review » Reviewed & tested by the community

Seems to be OK now. Setting to RTBC.

kattekrab’s picture

Priority: Normal » Major
klausi’s picture

Issue summary: View changes
Issue tags: -PAreview: review bonus

Removing review bonus tag, you have not done any reviews of other project applications. Make sure to read the review bonus page.

nico.knaepen’s picture

Issue summary: View changes
Issue tags: -PAreview: single application approval +PAReview: Single project promote; PAReview: review bonus
klausi’s picture

Issue summary: View changes
Issue tags: -PAReview: Single project promote; PAReview: review bonus

Again: Removing review bonus tag, you have not done any reviews of other project applications. Make sure to read the review bonus page.

nico.knaepen’s picture

Issue summary: View changes
nico.knaepen’s picture

Issue summary: View changes
nico.knaepen’s picture

Issue summary: View changes
Issue tags: +PAreview: review bonus
nico.knaepen’s picture

Issue summary: View changes
mlncn’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.