[D7] Email notification developer

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

You provide wrong git link, the correct is: http://git.drupal.org/sandbox/pifagor87/2419285.git

Maybe you should put administrating pages as admin/config/development subpages?
Code looks like OK, but I suggest you to use more empty lines in functions to improve code readability.

@pifagor87,

Automated Review

From pareview.sh you can check http://pareview.sh/pareview/httpgitdrupalorgsandboxpifagor872419285git

Manual Code Review

1. Function email_notification_developer_form_alter(): Since you are using only one form to alter then its always better to use hook_form_FORM_ID_alter(). This will save 2 function calls while altering a form.

2. $period_domain = variable_get(
         'email_notification_developer_period_domain',
         0
       );
   

   Why use line brakes in variable_get() ? This can be written in the same line.

3. Why do you need to use global variable $base_root? If you are using url() or l() functions then only passing "admin/config/system/cron" will generate the CRON form URL, unless you are using one external URL. But not in this case I suppose.
4. There are quite a few functions that don't have any comments regarding what they do and for what they are used. Like email_notification_developer_validate_email(), email_notification_developer_validate_domain() etc.

I hope these reviews make sense. Please let me know if you have any doubts regarding these.

You need to provide the git clone command so we can clone your code and so a manual test.
- You can find the correct git clone command for your sandbox by clicking on the Version control tab, removing the checkbox in front of "Maintainer", and clicking Show. You can then copy-paste the git clone command

We are very close!
Manual Check - just a few typos:

README.txt:
LINE 16 - Cheksboks -> Did you mean Checkboxes ??
LINE 20 & 30 - danyho -> did you mean Day?
LINE 22 - adresses -> addresses

email_notification_developer.module:
LINE 155, 187, 215, - adresses -> addresses

@jcontreras: some spelling errors are surely not application blockers, anything else that you found or should this be RTBC instead?

You are right klausi. just a final touch.
Thank you Pifagor87 for your time on this module!

from pareview.sh

Review of the 7.x-1.x branch (commit a8867f0):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: ...w/drupal-7-pareview/pareview_temp/email_notification_developer.module
  ---------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  ---------------------------------------------------------------------------
   318 | WARNING | Only string literals should be passed to t() where
       |         | possible
  ---------------------------------------------------------------------------
  
  Time: 169ms; Memory: 9.5Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Source: http://pareview.sh/ - PAReview.sh online service

That issue alone is surely not an application blocker, please do a real manual review.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.