On the modules page (http://example.com/admin/modules), the action link to add new modules to system reads "Install new module" (see attachment).

The word "install" is synonymous to "enable". At least in the Drupal context : hook_install, .install file all relate to the action of enabling a module.

A better wording here might be "Add new module", with add meaning downloading and adding the module to your Drupal. (then installing it). :)

CommentFileSizeAuthor
#14 drupal-add_new_module-1207354-14.patch2.48 KBpk188
#5 drupal-add_new_module-1207354-5.patch3.37 KBdisasm
#5 interdiff.txt2.54 KBdisasm
#3 1207354-3-add-new-module-theme.patch1.02 KBbrianV
#1 add-new-module-1207354-001.patch1 KBkarschsp
#1 add-new-module.png13.5 KBkarschsp
#1 add-new-theme.png19.75 KBkarschsp
#1 add-new-module-or-theme.png14.46 KBkarschsp
install-new-module.png18.86 KBshadcn

Comments

karschsp’s picture

karschsp commented
StatusFileSize
new add-new-module-or-theme.png14.46 KB
new add-new-theme.png19.75 KB
new add-new-module.png13.5 KB
new add-new-module-1207354-001.patch1 KB

To keep things consistent, I updated the text to:

"Add new module"

Only local images are allowed.

"Add new theme"

Only local images are allowed.

"Add new module or theme"

Only local images are allowed.

Patch and screens attached.

karschsp’s picture

karschsp commented
Status: Active » Needs review
brianV’s picture

brianV commented
StatusFileSize
new 1207354-3-add-new-module-theme.patch1.02 KB

Re-rolled against HEAD.

yoroy’s picture

yoroy commented

All other 'Add x' actions in core (content, user, menu item) simply 'just work'. You go to a page, fill out a form and your item is added. Is it really that simple for modules? Consistency is good, but is the UX similar enough to label this the same as the other 'add' links?

disasm’s picture

disasm commented
StatusFileSize
new interdiff.txt2.54 KB
new drupal-add_new_module-1207354-5.patch3.37 KB

One more match in help text that needed replaced.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented

@yoroy:
While I get your point, this is not only about consistency.

We're currently having a major WTF with module (un)install:

  1. Adding a module to our site is called "install". It then appears on the module list but doesn't really get installed.
  2. It's only installed when we're "enabling" the module for the first time.
  3. When we "disable" the module, it's not getting uninstalled, though.
  4. When we "uninstall" the module, it's finally getting uninstalled, but not removed.
  5. Once added, it isn't possible to remove the module again, except via filesystem.

While we can't completely clean up this terminology, we should try to improve on the wording of corresponding actions. It seems quite some improvement to settle with:

  1. Adding a module to our site is called "add". It then appears on the module list.
  2. It's only installed when we're "enabling" the module for the first time.
  3. When we "disable" the module, it's not getting uninstalled, though.
  4. When we "uninstall" the module, it's finally getting uninstalled, but not removed.
  5. We come up with a way to remove the module from the list, so it doesn't further clutter up our module page.
yoroy’s picture

yoroy commented

Good points Pancho, thanks for explaining. Go ahead!

alansaviolobo queued 5: drupal-add_new_module-1207354-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: drupal-add_new_module-1207354-5.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

charles belov’s picture

charles belov
he/him
Primary language English
Location San Francisco, CA, US
commented
Issue summary: View changes
Parent issue: » #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update
pk188’s picture

pk188 commented
Status: Needs work » Needs review
StatusFileSize
new drupal-add_new_module-1207354-14.patch2.48 KB

Not find all the changes. Re rolled.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Related issues: +#976232: "Install" button at admin/*/install should be labeled "Continue", +#2577407: Action of uploading module/theme files should consistently be called "Add", not "Install"

This is really a duplicate of #2577407: Action of uploading module/theme files should consistently be called "Add", not "Install" and probably #976232: "Install" button at admin/*/install should be labeled "Continue" too? Not sure which one(s) we should keep open but probably not all 3. I will comment on the other 2 issues too.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Closed (duplicate)

The other issue has a lot more discussion so I am going to go ahead and close this as a duplicate.