Originally pointed out by carlos8f at #686060-22: Explain that the Update manager only works if you have FTP or SSH access to your server but this is really unrelated to the rest of what that issue is trying to address...

The "Install" button at admin/reports/updates/install, admin/modules/install and admin/appearance/install (all of which point to the same menu callback -- update_manager_install_form()) should really be labeled "Continue".

Clicking the button doesn't necessarily trigger installation. Although it does (or at least tries to) when all the files are owned by the same user. So, maybe the button should be renamed conditionally based on the file ownership stuff? I guess it doesn't really hurt that much to always call it "Continue"...

Comments

dww’s picture

Status: Active » Needs review
Issue tags: +Update manager
StatusFileSize
new728 bytes

Here's the trivial always-rename-the-button approach. Also I forgot to tag...

Status: Needs review » Needs work

The last submitted patch, 976232-1.update-manager-install-continue-button.patch, failed testing.

dww’s picture

Status: Needs work » Needs review
StatusFileSize
new2.12 KB

Oh right, some tests are trying to press that button. ;)

Bojhan’s picture

Status: Needs review » Needs work

It does hurt too much just calling it "Continue", this because people will be constantly looking for that button.

dww’s picture

@Bojhan: Thanks for the review, although I don't know exactly what you're talking about. ;) You're saying that if the text of the button says "Continue" instead of "Install", even though it's the only button on the page, that it's going to disappear from view and no one will be able to proceed? I know you're a usability expert, but that seems to be a rather far-fetched assertion. Can you please explain your concerns?

Sounds like "needs work" is the wrong status from your perspective. If you want it to just stay "Install" we should set this to "won't fix". If you're okay with changing "Install" (since that's not what the button does) to something else, can you propose an alternative? I can't really imagine another option that anyone would be happy with, but maybe you can come up with something.

Thanks,
-Derek

Bojhan’s picture

Sorry for being so short, but of course I don't think that people will just give up and navigate away. My point was, that people are looking for the word "install" - this is the trigger word here.

The problem is; by saying "Continue" we indicate there is a next step, but give the user no clue what is next (even by common sense). This to the contrary of other uses of "Continue" (the most usable one in the installer) which are part of a flow, and thereby list out the steps - where you are in the process.

So by removing the word install (which is a clear word), we are moving it to "Continue" which will leave the user wondering for a second what is happening next. So now that we are choosing between surprise the user and confuse the user, I am opting for not choosing at all, because its all bad choices - and fixing it properly in D8 (e.g. we need an in-overlay wizard indicator).

dww’s picture

Thanks for clarifying. So now what, won't fix?

Bojhan’s picture

Version: 7.x-dev » 8.x-dev

I think push it to D8, we can fix this by introducing a wizard indicator for the overlay.

carlos8f’s picture

Version: 8.x-dev » 7.x-dev

The problem is; by saying "Continue" we indicate there is a next step, but give the user no clue what is next (even by common sense).

Then, in that case, we should explain what's going to happen. Part of that is already slated for #686060: Explain that the Update manager only works if you have FTP or SSH access to your server. So based on whether the user needs to be redirected to authorize.php, the button should say "Continue", or "Install". D8 is nonsense for this issue; update manager may not even make it to D8.

EvanDonovan’s picture

I agree with @carlos8f on this:

based on whether the user needs to be redirected to authorize.php, the button should say "Continue", or "Install"

bfroehle’s picture

The logic here would need to be:

if (fileowner(_update_manager_extract_directory()) == fileowner(conf_path())) {
  // Show "Install" button
}
else {
  // Show "Continue" button
}

Workflow will still remain problematic on shared hosts though until #1008328: Uniqueify update-cache and update-extraction directories to prevent "Permission denied" errors or similar is solved, as another user's Drupal installation might create the update_extract directory causing us to select the wrong branch of the if statement.

jhodgdon’s picture

Issue summary: View changes

This is really a duplicate of #1207354: Install new module v/s Add new module and probably #2577407: Action of uploading module/theme files should consistently be called "Add", not "Install" too? Not sure which one(s) we should keep open but probably not all 3. I will comment on the other 2 issues too.

dww’s picture

This was the earliest, so we should probably keep this one, right? 6 digit nid FTW. ;)

jhodgdon’s picture

Perhaps, but we should make sure it covers all the ground of the others, and includes the info about why this is such a usability SNAFU, etc. Plus, which has a good patch?

The issue title here has an opinion of how to solve the usability problem; the others may have a different opinion about how to solve the same problem?

jhodgdon’s picture

Actually I think this one is not a straight duplicate of the other two. The other two issues are about what you see on admin/modules. This one is about what you see after you click the button that currently says "Install new module" and should probably say "Add new module".

Also, the other two issues have had a lot more comments and usability team involvement. If anything, we should close this one, and incorporate it into the others. We don't always choose to close the newer ones as duplicates.

dww’s picture

Version: 7.x-dev » 8.9.x-dev

Fair points, @jhodgdon, thanks. Re-reading this now (and skimming the others), I agree it's not a duplicate. For scope, we should keep this separate. It'd be easier to deal with this as a stand-alone fix, instead of getting embroiled in all the changes on admin/modules itself, which are only tangentially related to this since they also involve the word "install".

Bumping to at least 8.9.x for now. TBD.

We've only got 4 months before this becomes a decade-old bug. ;) Thanks for resurfacing it!

Cheers,
-Derek

jhodgdon’s picture

See #3158126-5: Change text to "You must manually enable newly added modules, here. Steps here." -- Upon further reflection, I really think we should consolidate these 3 issues into 1, because they're all steps of the same process. See also #2577407-173: Action of uploading module/theme files should consistently be called "Add", not "Install" (which is the issue I think we should consolidate on) -- I think the next step would be to bring this process in to a Usability group meeting, get the group to decide what to do.

The patch to fix all 3 of these will only affect a few lines of code -- it's just UI text -- and I really think thinking of it as the usability of the whole process is the way to go.

jhodgdon’s picture

There's a meta issue that should be this issue's parent.

jhodgdon’s picture

FYI -- on the parent issue #2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update the Usability team is discussing the UI text for this and about 10 other issues. Until decisions are made, making another patch here would probably be premature.

jhodgdon’s picture

We now have a plan to fix this on #2577407: Action of uploading module/theme files should consistently be called "Add", not "Install", so marking this issue as a duplicate. I've asked people on this issue to be credited there.