Hi,
I have a problem with this module and the terms that contain / and - inside the name, es. foo/bar or foo-bar.

In this case, views return Page not found.
I tried to change the IndexNameDepth->query() method but the display does not even enter this method.

Anyone can help me?
Thx
I.

CommentFileSizeAuthor
#9 interdiff-2908865-7-9.txt733 bytesrakesh.gectcr
#9 2908865-9.patch753 bytesrakesh.gectcr
#7 interdiff-2908865-4-7.txt1 KBrakesh.gectcr
#7 2908865-7.patch747 bytesrakesh.gectcr
#3 term-name-with-special-chars-2908865-8.x.patch710 bytesPaladyn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Yoris00 created an issue. See original summary.

Paladyn’s picture

Paladyn CreditAttribution: Paladyn commented

Problem is in pathauto part of IndexNameDepth.php (lines 130-144) query function.

if (\Drupal::service('pathauto.alias_cleaner')->cleanString($row->name) == $tids) {

This condition don`t match when special characters are there.

For example: Sports, Fun & Football
\Drupal::service('pathauto.alias_cleaner')->cleanString($row->name) returns "sports-fun-football"
$tids equels "Sports, Fun & Football"

My solution is to change condition to:
if (\Drupal::service('pathauto.alias_cleaner')->cleanString($row->name) == \Drupal::service('pathauto.alias_cleaner')->cleanString($tids)) {

Paladyn’s picture

Paladyn CreditAttribution: Paladyn commented
FileSize
term-name-with-special-chars-2908865-8.x.patch710 bytes

I`ve made patch for above changes. Please test, if it`s working for you also.

Paladyn’s picture

Paladyn CreditAttribution: Paladyn commented
Status: Active » Needs review
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at CTI Digital commented
Status: Needs review » Needs work

Can we add in dependency injection?

jnycz’s picture

jnycz CreditAttribution: jnycz as a volunteer commented

Duplicate? https://www.drupal.org/project/drupal/issues/672606

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at CTI Digital commented
Status: Needs work » Needs review
FileSize
2908865-7.patch747 bytes
interdiff-2908865-4-7.txt1 KB

Adding into a variable, So that it will be under 80 characters on a single line.

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at CTI Digital commented
Status: Needs review » Needs work

Oops, Still its more than 80

rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at CTI Digital commented
Status: Needs work » Needs review
FileSize
2908865-9.patch753 bytes
interdiff-2908865-7-9.txt733 bytes
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at CTI Digital commented

  • rakesh.gectcr committed ab84587 on 8.x-1.x 
    Issue #2908865 by rakesh.gectcr, Paladyn, Yoris00, jnycz: Term name with...
rakesh.gectcr’s picture

rakesh.gectcr
he/him
Primary language Malayalam
Location Manchester
CreditAttribution: rakesh.gectcr as a volunteer and at CTI Digital commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.