Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#27 drupal-check-json.txt1008 bytesChandra Gowsalya Kannan
#12 Drupal-10-upgrade-status-94 (4).png28.74 KByashingole
#12 Module-Permissions-10.png68.29 KByashingole
#11 view_unpublished_d10readiness-11.patch5.34 KBjames.williams
#11 interdiff-3299433-7-11.txt613 bytesjames.williams
#7 Screenshot 2022-11-19 at 12.21.28.png75.62 KBfathima.asmat
#7 Screenshot 2022-11-19 at 12.21.12.png33.79 KBfathima.asmat
#7 Screenshot 2022-11-19 at 12.04.48.png21.03 KBfathima.asmat
#7 interdiff_4-7.txt930 bytesfathima.asmat
#7 view_unpublished_d10readiness-7.patch5.34 KBfathima.asmat
#4 view_unpublished.1.x-dev.rector.patch4.27 KBProject Update Bot
#4 interdiff-last-bot.6675944.txt1.06 KBProject Update Bot
#3 view_unpublished.1.x-dev.rector.patch3.5 KBProject Update Bot
#3 interdiff-last-bot.6664526.txt470 bytesProject Update Bot
#2 view_unpublished.1.x-dev.rector.patch3.92 KBProject Update Bot

Issue fork view_unpublished-3299433

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Project Update Bot created an issue. See original summary.

Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Status: Active » Needs review
FileSize
view_unpublished.1.x-dev.rector.patch3.92 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
FileSize
interdiff-last-bot.6664526.txt470 bytes
view_unpublished.1.x-dev.rector.patch3.5 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
FileSize
interdiff-last-bot.6675944.txt1.06 KB
view_unpublished.1.x-dev.rector.patch4.27 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
Project Update Bot’s picture

Project Update Bot CreditAttribution: Project Update Bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

fathima.asmat’s picture

fathima.asmat CreditAttribution: fathima.asmat as a volunteer commented
Assigned: Unassigned » fathima.asmat
Issue summary: View changes
Issue tags: +Drupal 10 porting day

I'm going to test this and review as part of D10 porting day Nov.

fathima.asmat’s picture

fathima.asmat CreditAttribution: fathima.asmat as a volunteer commented
FileSize
view_unpublished_d10readiness-7.patch5.34 KB
interdiff_4-7.txt930 bytes
Screenshot 2022-11-19 at 12.04.48.png21.03 KB
Screenshot 2022-11-19 at 12.21.12.png33.79 KB
Screenshot 2022-11-19 at 12.21.28.png75.62 KB
  • Applied rector patch from #4 but had some issues in D10 beta.
  • Amended the patch to include the version compatibility in info yml and added the access check to entity query. Patch attached below.
  • Upgrade status doesn't flag any more issues
 [notice] Processing /var/www/html/web/modules/contrib/view_unpublished.

================================================================================
View Unpublished, --
Scanned on Sat, 11/19/2022 - 12:03

No known issues found.
  • Manually tested the module on both D10 beta and D9.5. On D10.
  • I was successfully able to rebuild the permissions on both D9 and D10.
  • I could successfully tick the permissions for content editor user role to view unpublished content on both D9 and D10.
  • I was successfully able to see the unpublished content when logging in as content editor on both D9 and D10.
  • I have attached screenshots of my test results.
fathima.asmat’s picture

fathima.asmat CreditAttribution: fathima.asmat as a volunteer commented
Assigned: fathima.asmat » Unassigned
vinaymahale’s picture

vinaymahale CreditAttribution: vinaymahale as a volunteer and at SJ Innovation LLC commented
Status: Needs review » Reviewed & tested by the community

Reviewed the code from patch provided in #7
Code looks good!
Module works as expected on D10.
Setting to RTBC

james.williams’s picture

james.williams CreditAttribution: james.williams at ComputerMinds commented

Fixes for the access check in the entity query were also provided over in #3281519: Install helper entity query without access check specified results in deprecation warning. I recommend that user (richard.thomas) be given issue credit here too, as & when this is committed.

james.williams’s picture

james.williams CreditAttribution: james.williams at ComputerMinds commented
Status: Reviewed & tested by the community » Needs review
FileSize
interdiff-3299433-7-11.txt613 bytes
view_unpublished_d10readiness-11.patch5.34 KB

In fact... the fix from #3281519: Install helper entity query without access check specified results in deprecation warning looks much better - it explicitly skips the access check, which makes far more sense, given that this code is quite deliberately there to find unpublished content!

Here's an updated patch.

yashingole’s picture

yashingole CreditAttribution: yashingole at QED42 for Drupal India Association commented
FileSize
Module-Permissions-10.png68.29 KB
Drupal-10-upgrade-status-94 (4).png28.74 KB

I have reviewed and checked Patch #11 this works for drupal 9.4 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.4 and the Permission page on 10 have been attached for reference:

vinaymahale’s picture

vinaymahale CreditAttribution: vinaymahale as a volunteer and at SJ Innovation LLC commented

Please change the status to RTBC if the patch works properly and there are no more errors

AaronBauman made their first commit to this issue’s fork.

AaronBauman opened merge request !4

AaronBauman’s picture

AaronBauman
he/him
CreditAttribution: AaronBauman commented
Status: Needs review » Reviewed & tested by the community

Created an issue fork so that i can test the install / require and it works.

j-vee’s picture

j-vee CreditAttribution: j-vee as a volunteer commented

+1 works.

Can this be published now that D10 has been out for a while?

xeM8VfDh’s picture

xeM8VfDh CreditAttribution: xeM8VfDh commented

thanks so much for the work here, would love a release :)

stijnhau’s picture

stijnhau CreditAttribution: stijnhau at Open Up Media commented

A New release of this module would be so nice

xeM8VfDh’s picture

xeM8VfDh CreditAttribution: xeM8VfDh commented

I messaged the maintainers, hopefully someone will have time in the near future. Thanks again to everyone involved :)

KlemenDEV’s picture

KlemenDEV CreditAttribution: KlemenDEV as a volunteer and at Pylo commented

RTBC (tested, seems to work fine) from my side too, hoping for the release

xeM8VfDh’s picture

xeM8VfDh CreditAttribution: xeM8VfDh commented

I just wanted to check in on this, would love to see it merged and released! Thanks everyone for the help!

Victonator’s picture

Victonator CreditAttribution: Victonator at iO commented

+1
Merge request #21 works!

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Related issues: +#3345720: Offering to co-maintain view_unpublished

Adding related issue #3345720: Offering to co-maintain view_unpublished, hopefully the module can soon be Drupal 10 ready :)

ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Title: Automated Drupal 10 compatibility fixes » Automated Drupal 10 compatibility fixes for view_unpublished

Adding project name in title.

xeM8VfDh’s picture

xeM8VfDh CreditAttribution: xeM8VfDh commented

I've just tested upgrading my site to drupal 10 with this module installed running the latest patch (using these instructions) and everything seems to be working fine

Chandra Gowsalya Kannan’s picture

Chandra Gowsalya Kannan CreditAttribution: Chandra Gowsalya Kannan as a volunteer and at TATA Consultancy Services for Pfizer, Inc. commented
FileSize
drupal-check-json.txt1008 bytes

Tested patch #12 and it is works fine. That patch makes the module D10 compatible and Drupal check errors are ignorable which I attached here.

tobiasb made their first commit to this issue’s fork.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb as a volunteer commented
Status: Reviewed & tested by the community » Fixed

<3

xeM8VfDh’s picture

xeM8VfDh CreditAttribution: xeM8VfDh commented

🥳

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.