[D8] Open Search: Tab to Search

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxAntoninSlejska284757...

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Antonín,

Automated Review

Please correct the pareview.sh issues here https://pareview.sh/node/1005

1. Branch should be named 8.x-1.x
2. Update your documentation in opensearchtab.module on line 9 to * Implements hook_page_attachments().

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

No: Does not follow the guidelines for master branch. Rename default branch to 8.x-1.x

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

See above.

@scott.allison : Looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

Hi @visabhishek sorry about that. Yes, this needs work.

@Antonín

Automatic application review tool found so many major issues in your application.

https://pareview.sh/node/1005

There are still many coding standard violations at https://pareview.sh/node/1005,
Use dependency injection in classes. Use $this->t(), instead of t() in OpenSearchSettingsForm.php

Automated Review

FILE: /root/repos/pareviewsh/pareview_temp/opensearchtab.routing.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
8 | WARNING | Open page callback found, please add a comment before the
| | line why there is no access restriction
17 | WARNING | Open page callback found, please add a comment before the
| | line why there is no access restriction
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/opensearchtab.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
9 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"

FILE: /root/repos/pareviewsh/pareview_temp/opensearchtab.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------

FILE: ...t/repos/pareviewsh/pareview_temp/src/Form/OpenSearchSettingsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
34 | ERROR | [x] Short array syntax must be used to define arrays
40 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
README.txt/README.md
Yes: Follows the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Follows the security requirements.
Coding style & Drupal API usage
* Please fix code style according to issues above.
* Just a friendly bit of advice. You should add some description of this module to .module file using hook_help. It may be really useful.

Hi,

Automated Review

Remove the LICENSE, drupal.org packaging will add a LICENSE.txt file automatically.

Manuel review

I installed your module locally and I test with your demo site (https://drupal.slejska.de), but I can't make it work, I have not the site in the settings of google chrome (chrome://settings/searchEngines).

http://i.imgur.com/Hi71FTa.png

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.