[D8] Open Search Tab

@Antonin,

If there is any dependency of any core/contrib module, Please specify in your info.yml file.

currently dependencies: (there is a blank value for dependency).

Attached Screenshot.

Thank you for applying!
Check the Git settings you are using; in particular, verify the email Git is using is an email Drupal.org knows. Your commits aren't associated to your account, and that is because Git is not using an email registered within your Drupal.org account.

@Antonin

So remove blank dependencies: key from info file.

I have reviewed manually and found below concerns :

1. src/Controller/OpenSearchDescriptionController.php - Code extended more then 80 column. Recommended to break smaller chunks to more readable.
2. Use dependency injection

Example of using:

$messenger= \Drupal::messenger();
$messenger->addMessage($message, 'statut');

First, use the namespace:

use Drupal\Core\Messenger\MessengerInterface;

Than add protected variable to your class:

protected $messenger;

In your constructor:

 public function __construct(MessengerInterface $messenger) {
    $this->messenger = $messenger;
  }

and then:

public static function create(ContainerInterface $container) {
    return new static(
      $container->get('messenger')
    );
  }

Then you can use

$this->messenger->addMessage($message, $message_status);

in your code.

Thank you for your contribution.

@vernit,

For point 2 You're talking about the same controller file? Becoz I didn't find anything related to drupal messages.

Message is for example point of view.
In file Drupal request is used.,

ok @vernit

@Antonín Slejška is there any case for not extending controller base class in OpenSearchDescriptionController.php file.

$config = \Drupal::config('system.site');

you can also do it by extending controller base class :

Eg: $config = $this->config('system.site'); (This should avoid direct drupal calls)

Hi, I have one issue. Maybe better idea would be put part of code from controller to any service beacuse this controller is too big, method content should be share.
I don't think so that contoller's role is creating xml. In my opinion you should put all creating xml functionality to another service. In controller you should only call:

$this->response->setContent($this->myOpenTagService->getXml());

Putting the part for generating the XML content into a service would make the code more modular, and allow a third-party module to alter the XML content, but since the task of controllers is generating content, this is not something we can judge on these applications.
It's a great suggestion, though.

In my opinion everything is good here. Maybe one thing yet but it's only suggestion. if I were you I would move raw numeric values to const in validateForm in your config form here but like I told before it is only suggestion.

@Antonín Slejška

You can try use Drupal\Component\Render\FormattableMarkup

Refer https://drupal.stackexchange.com/questions/220874/passing-variables-that...

Thanks for you contribution!

1. OpenSearchSettingsForm::buildForm(): $this->t('@title') is not useful for translation. You should send the string literals through t() for translation. So const FIELDS should be a private or protected method that translates the user facing string literals instead.
2. OpenSearchSettingsForm::buildForm(): "this->t('See the XML of the open search tab:') . ' ' . $opensearchdescription_link;": do not concatenate variables to translatable strings, use placeholders with t() instead.
3. OpenSearchDescriptionController: class comment only repeats the class name. Please describe what the class is used for and what it does instead. Please check all your class comments.

Otherwise looks good to me, did not see any security issues.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.