Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Test runner no longer running patches.
Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Test runner no longer running patches.
Top Drupal contributor Acquia would like to thank their partners for their contributions to Drupal.
Drupal is a registered trademark of Dries Buytaert.
Comments
Comment #2
joseph.olstadsee test runner result here:
#2970929-2: [D7] Support X-Forwarded-* HTTP headers alternates
Comment #3
joseph.olstadI think the problem started here:
#2968630-2: Send phpversion to the composer command
Comment #4
joseph.olstaddifferent patch, different issue, same error
#2759197-64: [D7] Improve WebTestCase performance by 50%
Comment #5
rooby CreditAttribution: rooby commentedAlso happening at #2847484: Support boolean attributes in drupal_attributes()
https://www.drupal.org/pift-ci-job/959480
Comment #6
joseph.olstadthese other issues are also failing same error:
#1982810-20: Core entity_get_controller gets a NULL controller class
and
#1835754-20: Add last 'changed' property to user entity
Comment #7
hestenetThanks for the heads up - we're taking a look at this on the DA side (mixologic is out this week).
Comment #8
joseph.olstadalso affects:
#2086335: Bootstrap issue with theme initialization causes hook_custom_theme() never to be invoked
and
#2777955: [D7] Enable error logging to log a backtrace string
Comment #9
joseph.olstadthis is blocking more and more issues, here's a few more, there's others too.
Comment #10
joseph.olstadComment #11
joseph.olstadWhy are we using composer for D7 ? I don't use composer for any of my D7 projects.
Comment #14
joseph.olstadI just re-triggered a bunch of tests to see if this helps, same issue:
[D7] Enable error logging to log a backtrace string
Issue changes:
- Status: Needs review
+ Status: Needs work
The last submitted patch, 18: 2777955-18.patch [1], failed testing. View
results
Add last 'changed' property to user entity
Issue changes:
- Status: Needs review
+ Status: Needs work
The last submitted patch, 20: drupal-user-changed-property-1835754-19.patch
[1], failed testing. View results [2]
valid_email_address() should be easily overridable
Issue changes:
- Status: Needs review
+ Status: Needs work
The last submitted patch, 8: hook_valid_email_address_alter-2966195-8.patch
[1], failed testing. View results [2]
[D7] Improve WebTestCase performance by 50%
#71 -- 16 May 2018 at 01:17 UTC : System Message
https://www.drupal.org/project/drupal/issues/2759197#comment-12616006
The last submitted patch, 63: 2759197-simpletest-perf-63.patch [1], failed
testing. View results [2]
Comment #15
MixologicThe testbots have been using composer to build out the d7 sites because some d7 modules actually do have composer requirements and the only way to test those is by using composer.
This was a bug only for d7 core testing, because we dont actually use any composer for that because it only needed to be a git clone, so it was erroneously creating an additional composer install step. I've added a check and it should no longer do this.
In any case, testing isn't really blocking progress here. The truth is that there isn't really anybody actively maintaining D7. David Rothstein, I believe, is stepping down from his committer role now that he's working for Automattic (https://www.linkedin.com/in/david-mark-rothstein), Stefan.r hasnt made a commit since the community issue with crell happened, and Fabian hasnt made a commit in a year and a half.
So once these tests are green and RTBC, whats truly blocking progress is that there isnt anybody actively maintaining drupal 7 as a committer.
I mention this mostly to help explain why a bug like this gets such a low priority.
Comment #16
MixologicI think you may have jumped the gun.
This is one that I retested after I had deployed the changes to drupal.org, and it appears to be running successfully:
https://dispatcher.drupalci.org/job/drupal_d7/77595/console
Comment #17
joseph.olstadok I requeued those, we shall see this time
Comment #18
joseph.olstadFabianX is actively maintaining D7 and there are others.
Comment #19
joseph.olstadFabianX recently flagged 5 issues for pending Drupal 7 commit
Many people have pushed hard to get php 7.2 compatibility working, this testrunner issue is blocking progress.
Comment #20
joseph.olstadI reran the testbot,
still broken
01:17:59 Composer Command Failed
exact same error as before.
Comment #21
MixologicNo, you reran those issues before I pushed the change, just like I said in #16
Comment #22
joseph.olstadThanks Mixologic, looks like the issue is resolved.