We need the version of php we plan on executing to be added to the configuration array for the composer install command.

Comments

Mixologic created an issue. See original summary.

  • 3b7b47f committed on 7.x-3.x 
    Issue #2968630: adds phpversion to pift, and sends it to drupalci
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Assigned: Mixologic » Unassigned
Status: Active » Fixed

This was implemented and deployed as a new variable in settings.php that contains a mapping of drupalci containers to approximate php versions. They may slightly mismatch from time to time, but that will only be particluarly relevant if some dependency relies on the very latest and greatest version of php, which we really ought not to have.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#2970929: [D7] Support X-Forwarded-* HTTP headers alternates

I think this change might have caused a problem with the testrunner for 7.x

Today I ran a patch vs core that passed not long ago, seeing this error "Composer Command Failed"

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Fixed » Needs work

I think this change may have caused a regression.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

different patch, different issue, same error:
#2759197-64: [D7] Improve WebTestCase performance by 50%

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@mixologic, please see #2970950: D7 test runner not working since may 4th 2018 'Composer command failed'
I marked it as critical,

Thanks

hestenet’s picture

hestenet
He/Him
Location Portland, OR 🇺🇸
commented

Thanks for the heads up - we're taking a look at this on the DA side (mixologic is out this week).

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@mixologic, can you please have a look at this?
this is a blocker for about 10 active D7 core issues with patches for review that are falsely failing.

#2970950: D7 test runner not working since may 4th 2018 'Composer command failed'

I've added a few of the related fails to that issue

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

Back from vacation, yesterday was all meetings and email catchup. I'm looking into this now.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Needs work » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

composer not found still happening. follow up in:
#2970950: D7 test runner not working since may 4th 2018 'Composer command failed'

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

yep. I just marked this one fixed because I was planning on using the other issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Thanks again! the testbot seems to be working well aside from occasional glitch but ya, works great.