Problem/Motivation
The tags in the version selector cause a couple of issues:
1. The select gets very long.
2. Especially core, but also the vast majority of contrib projects, never work on issues against tags - since the tag has already been tagged and can't be merged against. However I often see new users change the version of issues to the specific tag they happen to have installed.
3. A search on a branch won't show issues against the tag, so potentially some things get lost/duplicated due to this.
Proposed resolution
Only show branches and meta-branches in the version selector.
Related to this, it would be good to also remove unsupported branches as well - might open separate issue for that. Right now the version selector on this form goes all the way back to 4.7.x-1.0
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#17 | Screen Shot 2017-01-10 at 6.48.51 PM.png | 141.1 KB | drumm |
Comments
Comment #2
xjmComment #3
catchComment #4
catchComment #5
drummI think this should be optional, probably an option for the whole site. (Not a per-project option.) I'm not sure if there is anyone out there using this in project module, but I don't want to take this out from under them. I do think we should keep this standard across all projects on Drupal.org.
For Drupal.org, we'll want to check the feasability:
Comment #6
drummThe issue version field is added by project_release, a submodule of project.
Comment #8
drummTo do:
- The stats from #5. Do we move issues on tagged releases or make them less-findable?
- Show issue counts/warning on edit, so contrib projects know the trade-offs?
- Hide the new field if releases are not enabled for the project node.
- The actual functionality.
This should also speed up issue page loads for logged in users.
Comment #9
drummAll open core issues for non-dev versions do have corresponding dev versions, so we would not be making any issues less accessible. We’ll need to draft a message for the auto update to move the tagged issues.
There are various closed issues that would be affected, but I don’t think they are important.
Comment #13
drummThis should be okay to deploy as-is, since it is a configuration. For core, we’ll want to write a script to sweep up all the tag version issues into their dev versions.
Comment #14
drummThe versions list on issue listing pages needs a followup, #2842544: Move ProjectIssueHandlerFilterSearchApiVersion into release/views/handlers. So even if this is enabled right away for core, issues still filed under the tagged versions will still be accessible. If people update those issues, only the remaining options will be available.
Comment #16
drummComment #17
drummDeployed on Drupal.org and configured this project to use it:
Tagged releases in unchecked in the last form element.
Comment #19
dwwI guess this train already left the station, but I'm not necessarily a huge fan of this change. Part of the point of having official releases is to make it easier to reproduce bugs, since everyone can know what version of the code is showing the problem. Yes, feature requests should always be tied to a branch, not a release. However, I think there's still value in bug reports being reported against a specific version, not just a branch.
Also, point #3 from the summary is what the "meta version" options were supposed to help solve. People shouldn't be searching for issues via 8.x-1.x-dev, they should be using "8.x issues". The meta version options are already at the top of the list when filtering/searching for issues.
That said, I can see that having dozens of stable releases on each branch makes the version selector unwieldy.
If everyone thinks this is an improvement, maybe we could at least update the issue summary template to encourage people to include information about the specific version of the code they're using when reporting bugs?
Thanks,
-Derek
Comment #20
xjmIt is optional, so for projects where maintainers especially need this information, it can remain checked.
This is definitely going to make it easier to file and find core issues. Thanks @drumm!
Comment #21
xjm@drumm, I tested this for core, and it looks like issues that were filed against a version (some 17k) will be moved to 9.x by default as soon as someone updates them. I don't think we want that. So probably we should do the bulk update, at least for open issues. Disabling again for now until we can do that.
Comment #22
xjmShould we file a separate issue for migrating open core issues to their branch?
Comment #23
drummYes, since that's not something for project module. Either drupal or infrastructure project. Like the core minor version updates, main thing I need is a second draft of “Core issues are now filed against dev versions.” for the comment to go with the bulk version update.
Comment #24
drumm#2847734: Bulk update core issues from tagged releases to dev versions is the followup issue.