Work for this is ongoing in the 8.x-1.x branch.

Please add issues you are working on to the list below.

TODO

#2639020: provide good documentation for setting up the module from npm

Done

#2199509: Call to undefined function drupal_add_js
#2277641: Update httpRequest function for latest Drupal 8
#2277565: Call to undefined method Drupal\Core\Path\AliasManager::getPathAlias()
#2223491: Replace hook_library_info
#2277985: Port nodejs_watchdog submodule
#2289543: Move all module code from …/lib/Drupal/… to …/src/… for PSR-4
#2631118: Decide what to do with submodules (nodejs_buddylist, nodejs_subscribe, nodejs_actions)
#2631226: Renovate config handling for D8
#2634908: Organize node.js server into submodules
#2634920: Register the Nodejs class as a service
#2634928: Use POST requests for actions
#2634894: Remove path configuration in server.js

CommentFileSizeAuthor
#7 2277997-nodejs-d8-port-7.patch17.53 KBjaperry

Comments

Anonymous’s picture

Anonymous (not verified) commented
Title: [META] Port nodejs for Drupal. » [META] Port nodejs for Drupal 8.

Title fix

Anonymous’s picture

Anonymous (not verified) commented

mrfelton - would you like a commit bit so it's easier for you to do this work?

mrfelton’s picture

mrfelton commented

@beejeebus - that would be great. I have several other follow up fixes sitting in my local too.

Anonymous’s picture

Anonymous (not verified) commented

done, you now have a write access to the repo, and 'Maintain issues' permission.

please stick to the D8 port for the time being, and create issues for each of the commits.

if i don't get to reviewing them within a few days, go ahead and commit. thanks for all the patches!

mrfelton’s picture

mrfelton commented

I've created a new 8.x-1.x-head branch to work against Drupal 8 HEAD (leaving 8.x-1.x to be compatible with the latest D8 release).

mrfelton’s picture

mrfelton commented
Issue summary: View changes
japerry’s picture

japerry
Location KOMK
commented
Status: Active » Needs review
StatusFileSize
new 2277997-nodejs-d8-port-7.patch17.53 KB

Here is a patch against Beta15. It doesn't hit everything, I've added a few TODOs for things that need a bit more re-writing. Most of this probably can be committed. but the issue shouldn't be closed.

Anonymous’s picture

Anonymous (not verified) commented

japerry - thanks.

this patch gets us from not installing at all to installing, so i went ahead and committed it to 8.x-1.x-head.

japerry - i've given you commit access to the repo, please feel free to push work to the 8.x-1.x-head branch.

no sssweat’s picture

no sssweat commented

Hello, just wanted to let you guys know that there is a Drupal Module Upgrader (upgrades module code from 7 to 8) not sure if you knew about it already, but if not, then check it out!!! might help make porting life easier.

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented

i've moved the 8.x-1.x-head code over to 8.x-1.x - please create any new patches against that branch.

glekli’s picture

glekli commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
glekli’s picture

glekli commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented

Gergely, Howard - do you have any objections to me rolling an alpha1 from the current state of the module?

seems to be in good enough shape for that, might help to get some early adopters trying it out.

related question - how much tech debt work should we do on the server.js side of the house before releasing a D8 version? i tend to favour releasing D8 sooner, and continuing the work with subsequent versions, but i'm open to suggestion on that.

glekli’s picture

glekli commented

Sure, I agree.

Regarding server.js, I have made progress with organizing the app into submodules (see #1261066: pull the actual node.js code itself out into a separate npm module, instead of shipping it with drupal module). What I currently have is functionally equivalent to the server.js in the Drupal module. If you are committed to shipping the node.js app separately, I'd say let's remove server.js from 8.x before rolling an alpha.

Anonymous’s picture

Anonymous (not verified) commented

yep, #17 seems right. we should remove server.js, nodejs.config.js.example and nodejs.server.extension.js.example, and add some instructions to the README.txt.

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented

okie dokie, i think it's time to roll an alpha1 :-)

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

we shipped 8.x-1.1 by now :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.