httpRequest() needs to be updated to work with the latest Drupal 8 to use Drupal::httpClient() properly.

CommentFileSizeAuthor
#3 nodejs-httpClient-2277641.3.patch2.05 KBmrfelton
#2 nodejs-httpClient-2277641.2.patch2.13 KBmrfelton
#1 nodejs-httpClient-2277641.patch2.03 KBmrfelton

Comments

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
StatusFileSize
new nodejs-httpClient-2277641.patch2.03 KB

Patch attached makes some updates that seems to get things working again (along with the patches from #2199509: Call to undefined function drupal_add_js #2277565: Call to undefined method Drupal\Core\Path\AliasManager::getPathAlias() and #2223491: Replace hook_library_info). I'm not 100% about all the changes in this patch, especially the removal of the drupal_session_start(); call in nodejs_auth_get_token_callback. I tried updating that to use the new Drupal 8 session handling system but it didn't seem to work but I'm not sure I understand the need for it at all so I ended up removing it to get things working.

mrfelton’s picture

mrfelton commented
StatusFileSize
new nodejs-httpClient-2277641.2.patch2.13 KB

Patch updated slightly to resolve issues for requests with an empty body or undefined method. I'm not comfortable committing this until I understand why the call to drupal_session_start() was in nodejs_auth_get_token_callback() previously.

mrfelton’s picture

mrfelton commented
StatusFileSize
new nodejs-httpClient-2277641.3.patch2.05 KB

Patch updated for d8 head.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

i think i fixed this with a recent commit.

please re-open if it's still busted.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.