I'm seeing test failures when running tests using Message Digest on instances that run PHP 7.2 and PHP 7.3. It is caused by the use of assert() using the old PHP 5 style string. This has been deprecated starting with PHP 7.2.0 (ref. https://www.php.net/manual/en/function.assert.php#refsect1-function.asse...).

CommentFileSizeAuthor
#2 3055362-2.patch741 bytespfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Issue tags: +PHP 7.2
FileSize
3055362-2.patch741 bytes

Here is a patch. Note that this will make this assertion no longer work when running tests on PHP 5. This should not be a problem, since they are already two other instances of the PHP 7-only assert() calls in the Message Digest code base (in DigestManager::processSingleUserDigest() and DigestActionsTest::setUp()).

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review

  • jhedstrom committed 665d4a8 on 8.x-1.x authored by pfrenssen 
    Issue #3055362 by pfrenssen: Test failures on PHP 7.2 and higher
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.