The URL embed module is going with an approach for using a PHP library to support many different embeddable video, image, and audio. I see the tech goals of this module very similar to that, and the goal is to avoid several different modules that need to have a 'support multiple providers' code that just duplicates each other. Should we somehow collaborate between the two modules?

Comments

Dave Reid created an issue. See original summary.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm as a volunteer commented
Priority: Normal » Major

Sure! Any collaboration we can achieve is a big win.

Had a short chat about this with Dave on IRC and he said he'll propose a solution soon.

webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Version: » 8.x-1.x-dev

I think video_embed_field is another candidate for collaboration.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

I agree with #3. If VEF implemented a MediaType plugin, wouldn't the two modules have complete parity? I'm looking through this module and I can't see a reason not to implement the plugin and bring the existing VEF providers/feature set to the media module.

Please correct me if I'm wrong and perhaps overlooking some other integration points?

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

I have filed #2688927: Integrate with the media_entity module..

slashrsm’s picture

slashrsm CreditAttribution: slashrsm as a volunteer commented

VEF could implement EmbeddableVideoProvider plugins which would allow us to share 3rd party integrations.

It would be great to share efforts between both modules as they really have a lot in common.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

My thoughts were around directly integrating with media_entity, given it looks like a single plugin? I'd rather not create a 3 levels of dependencies and discard the existing work for what seems like it would be a much worse experience. I've detailed this in the issue I've linked.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

Following up on #6, to be frank, I think they have so much in common the efforts should have been geared to simply integrating VEF with media to begin with. Besides the media plugin, they seem to have a similar architecture, plugin system and purpose.

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

Added some more detailed thoughts here #2688927: Integrate with the media_entity module.. Waiting on a response before proceeding.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm as a volunteer commented

Commented on #2688927: Integrate with the media_entity module.. I am in favour of merging. We just need to figure out how to handle sites that are already using media_entity_embeddable video and to achieve feature-parity.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

I still think the goal should be to separate out the logic that media_entity_embeddable_video is doing and either provide our own library (decoupled from media_entity), or use an independent PHP library for this. Would anyone be open to a BOF at the upcoming DrupalCon New Orleans to discuss this?

Sam152’s picture

Sam152 CreditAttribution: Sam152 as a volunteer and at PreviousNext commented

I think it's a good idea. I've opened #2700113: Integrate/adapt/extend video providers from a 3rd party library to discuss the details. I won't be at New Orleans, but you can catch me on IRC most week days.