I am seeing a fatal error after upgrading to 1.0-beta2 on a page that just displays a custom entity (i.e. not a search page).
It has a block that displays links to switch the displayed entity language.

I get the following error:

The website encountered an unexpected error. Please try again later.
Error: Call to a member function getId() on null in facets_language_switch_links_alter() (line 374 of modules/contrib/facets/facets.module).

facets_language_switch_links_alter(Array, 'language_content', Object) (Line: 501)
Drupal\Core\Extension\ModuleHandler->alter('language_switch_links', Array, 'language_content', Object) (Line: 417)
Drupal\language\ConfigurableLanguageManager->getLanguageSwitchLinks('language_content', Object) (Line: 90)
Drupal\language\Plugin\Block\LanguageBlock->build() (Line: 90)
Drupal\as_language\Plugin\Block\ASTranslationLanguageBlock->build() (Line: 203)
Drupal\block\BlockViewBuilder::preRender(Array)
call_user_func('Drupal\block\BlockViewBuilder::preRender', Array) (Line: 378)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 195)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 151)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 588)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 152)
Drupal\Core\Render\Renderer->renderPlain(Array) (Line: 166)
Drupal\Core\Render\Renderer->renderPlaceholder('', Array) (Line: 673)
Drupal\Core\Render\Renderer->replacePlaceholders(Array) (Line: 558)
Drupal\Core\Render\Renderer->doRender(Array, 1) (Line: 195)
Drupal\Core\Render\Renderer->render(Array, 1) (Line: 139)
Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}() (Line: 588)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 140)
Drupal\Core\Render\Renderer->renderRoot(Array) (Line: 258)
Drupal\Core\Render\HtmlResponseAttachmentsProcessor->renderPlaceholders(Object) (Line: 131)
Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAttachments(Object) (Line: 78)
Drupal\as_base\Render\ASMetadataResponseAttachmentsProcessor->processAttachments(Object) (Line: 70)
Drupal\as_rule_engine\Render\InlineContentBoxDetailsStateAttachmentsProcessor->processAttachments(Object) (Line: 45)
Drupal\Core\EventSubscriber\HtmlResponseSubscriber->onRespond(Object, 'kernel.response', Object) (Line: 108)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.response', Object) (Line: 193)
Symfony\Component\HttpKernel\HttpKernel->filterResponse(Object, Object, 1) (Line: 175)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 68)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 30)
Drupal\prefetch_cache\StackMiddleware\PrefetchCacheAfterSessionInitialized->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 41)
Drupal\as_segment\StackMiddleware\ASSegmentMiddleware->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 59)
Drupal\prefetch_cache\StackMiddleware\PrefetchCacheBeforePageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 658)
Drupal\Core\DrupalKernel->handle(Object) (Line: 30)

It seems the link arrays being processed do not necessarily have a language object under the key 'language'.

CommentFileSizeAuthor
#2 2938089-1.patch529 bytescspitzlay
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cspitzlay created an issue. See original summary.

cspitzlay’s picture

FileSize
529 bytes

Maybe this will do?

borisson_’s picture

Status: Active » Needs review
Issue tags: -SeachAPI Facets, -fatal error

This does sound like a big problem. Setting to needs review to see if there's any changes in the tests.

cspitzlay’s picture

Oh, hadn't set it to Needs Review. Sorry, my bad.

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

Looks solid.

cspitzlay’s picture

What needs to be done for this to be committed?

borisson_’s picture

@cspitzlay, I need to have more time in the day, I've had this tab open since I rtbc'd it. I'll try to get to this after work.

cspitzlay’s picture

No worries. Just wondering if something was still missing.
We're running fine with the patch in the meantime.

borisson_’s picture

Status: Reviewed & tested by the community » Fixed

Committed, sorry for having to wait so long.

  • borisson_ committed 3fac0f7 on 8.x-1.x authored by cspitzlay
    Issue #2938089 by cspitzlay: Fatal error after upgrade to beta-2
    
cspitzlay’s picture

Thx.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.