Hi,
When i work with entity_browser and entity_embed, i can select multiple entities to load in Ckeditor.
however, when I submit the entity_browser dialog after chosing my entities, entity_embed will handle the last selected entity and handle only this one.

If the entity browser allows selecting multiple entities , it must handle all of them.

CommentFileSizeAuthor
#12 2769895--multiple-embeds--11.patch56.5 KBe0ipso
#11 2769895--multiple-embeds--11.patch34.13 KBe0ipso
#2 0001-2769895-entity_embed_multiload-Manage-multi-load-ent.patch21.35 KBmars0test

Comments

BizuTétu created an issue. See original summary.

mars0test’s picture

mars0test commented
Status: Active » Needs review
StatusFileSize
new 0001-2769895-entity_embed_multiload-Manage-multi-load-ent.patch21.35 KB

Here is a possible patch.

renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented

I've encountered the same issue. I'm able to select many entities (of type media) in my entity browser but when I save the selection, only one of them is considered. However the patch does not seem to work for me, as there are many steps where only one entity can be considered.

mars0test’s picture

mars0test commented

Hy !
Sorry but I think with the many change of Drupal core and Entity Embed module this patch can't work. it work find for 8.2 if I remember :/

Status: Needs review » Needs work

The last submitted patch, 2: 0001-2769895-entity_embed_multiload-Manage-multi-load-ent.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: CKEditor integration » User interface

Interesting! Either Entity Embed should instruct Entity Browser to restrict selection to a single entity or Entity Embed should effectively create one <drupal-entity data-entity-uuid="…" …> tag for every selected entity.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Entity_embed does not charge multiple entity » Entity Embed does not embed all entities selected in Entity Browser
Issue tags: +Media Initiative
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Entity Embed does not embed all entities selected in Entity Browser » [entity_browser] When selecting multiple entities, only the last one is inserted
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [entity_browser] When selecting multiple entities, only the last one is inserted » [entity_browser] [upstream] When selecting multiple entities, only the last one is inserted
Issue tags: -Media Initiative +Usability
Related issues: +#2767573: [Follow-up] Use Entity browser's form element

Actually, \Drupal\entity_embed\Form\EntityEmbedDialog::buildSelectStep() contains:

        '#cardinality' => 1,

Which #2767573: [Follow-up] Use Entity browser's form element introduced. Either it wasn't properly tested there, or entity_browser broke something.

The Media Initiative doesn't depend on Entity Browser anymore (with Media Library in core), so untagging for that.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [entity_browser] [upstream] When selecting multiple entities, only the last one is inserted » [entity_browser] Allows selecting multiple entities despite #cardinality = 1 — either insert multiple entities or respect single cardinality
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs work » Needs review
StatusFileSize
new 2769895--multiple-embeds--11.patch34.13 KB

I am using this patch in my client's site to solve this on CKEditor5, perhaps it's useful to anyone.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
StatusFileSize
new 2769895--multiple-embeds--11.patch56.5 KB

Updating patch to allow editing the metadata.

jannakha’s picture

jannakha commented

@e0ipso can you provide a merge request out of your patch?
it will speed up testing and review process.
ta