[entity_browser] Allows selecting multiple entities despite #cardinality = 1 — either insert multiple entities or respect single cardinality [#2769895]

Hi,
When i work with entity_browser and entity_embed, i can select multiple entities to load in Ckeditor.
however, when I submit the entity_browser dialog after chosing my entities, entity_embed will handle the last selected entity and handle only this one.

If the entity browser allows selecting multiple entities , it must handle all of them.

Comment	File	Size	Author
#2	0001-2769895-entity_embed_multiload-Manage-multi-load-ent.patch	21.35 KB	Mars0test
#2	8.x-1.x: PHP 5.6 & MySQL 5.5, D8.2 32 pass PHP 7 & MySQL 5.5, D8.7 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

20 July 2016 at 13:07

BizuTétu created an issue. See original summary.

Comment #2

Mars0test CreditAttribution: Mars0test at Alter Way commented 20 July 2016 at 15:36

Status:

Active

» Needs review

File	Size
0001-2769895-entity_embed_multiload-Manage-multi-load-ent.patch	21.35 KB
8.x-1.x: PHP 5.6 & MySQL 5.5, D8.2 32 pass PHP 7 & MySQL 5.5, D8.7 Patch Failed to Apply

Here is a possible patch.

Comment #3

Renrhaf

French

📍 Strasbourg 🐦🦜

CreditAttribution: Renrhaf at Skazy for DTSI commented 22 September 2017 at 00:18

I've encountered the same issue. I'm able to select many entities (of type media) in my entity browser but when I save the selection, only one of them is considered. However the patch does not seem to work for me, as there are many steps where only one entity can be considered.

Comment #4

Mars0test CreditAttribution: Mars0test commented 28 September 2017 at 13:55

Hy !
Sorry but I think with the many change of Drupal core and Entity Embed module this patch can't work. it work find for 8.2 if I remember :/

Comment #5

16 July 2018 at 08:12

Status:

Needs review

» Needs work

The last submitted patch, 2: 0001-2769895-entity_embed_multiload-Manage-multi-load-ent.patch, failed testing. View results

Comment #6

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 9 November 2018 at 11:50

Component:

CKEditor integration

» User interface

Interesting! Either Entity Embed should instruct Entity Browser to restrict selection to a single entity or Entity Embed should effectively create one <drupal-entity data-entity-uuid="…" …> tag for every selected entity.

Comment #7

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 9 November 2018 at 12:05

Title:	Entity_embed does not charge multiple entity	» Entity Embed does not embed all entities selected in Entity Browser
Issue tags:		+Media Initiative

Comment #8

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 27 November 2018 at 18:52

Title:

Entity Embed does not embed all entities selected in Entity Browser

» [entity_browser] When selecting multiple entities, only the last one is inserted

Comment #9

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 23 May 2019 at 18:17

Title:	[entity_browser] When selecting multiple entities, only the last one is inserted	» [entity_browser] [upstream] When selecting multiple entities, only the last one is inserted
Issue tags:	-Media Initiative	+Usability
Related issues:		+#2767573: [Follow-up] Use Entity browser's form element

Actually, \Drupal\entity_embed\Form\EntityEmbedDialog::buildSelectStep() contains:

        '#cardinality' => 1,

Which #2767573: [Follow-up] Use Entity browser's form element introduced. Either it wasn't properly tested there, or entity_browser broke something.

The Media Initiative doesn't depend on Entity Browser anymore (with Media Library in core), so untagging for that.