Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
When N is 0 in "Credited on N issues fixed in the past Y months"
The link to all (stored issue credits, not all git mentions) is not shown.
Example
https://www.drupal.org/u/dsnopek
<h4>Credited on 30 issues fixed in the past 3 months</h4><div class="view view-issue-credit view-id-issue_credit view-display-id-user_recent view-dom-id-16c0875d8732789cab8472bbcdc60d73">
<div class="view-content">
<div class="item-list"> <ul> <li class="">
<span class="views-field views-field-title-1"> <span class="field-content"><a href="/project/panels">Panels</a>,</span> </span>
<span class="views-field views-field-nid"> <span class="field-content"><a href="/u/dsnopek/issue-credits/74958">10 issues</a></span> </span></li>
<li class="">
<span class="views-field views-field-title-1"> <span class="field-content"><a href="/project/panelizer">Panelizer</a>,</span> </span>
<span class="views-field views-field-nid"> <span class="field-content"><a href="/u/dsnopek/issue-credits/1072922">1 issue</a></span> </span></li>
Clicking on the link for Panelizer "1 issue" goes to https://www.drupal.org/u/dsnopek/issue-credits/1072922
1072922 is the node id for the Panelizer project.
At the time of writing up this example, it lists 6 issues
(but does not count them).
And, dsnopek has Page Manager issue credits, but none in the last 3 months,
https://www.drupal.org/u/dsnopek/issue-credits/2272255
Proposed resolution
Let people still have easy access to the history.
<h4 style="
display: inline;
">Credited on 30 issues fixed in the past 3 months</h4>
(<a href="/u/dsnopek/issue-credits">All recorded issue credits</a>)
Remaining tasks
User interface changes
before
proposed in #2
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#2 | proposed-allissues.png | 117.42 KB | YesCT |
#2 | before-allfixes.png | 138.11 KB | YesCT |
Comments
Comment #2
YesCT CreditAttribution: YesCT commented@webchick Had a good idea, to add an "all" link to the header.
While mocking it up, I had some thoughts:
Using a long semantic phrase for the link text makes it accessible(r).
And I'm not sure if there is a view with magical url args that goes to all issues in all projects. I put /u/dsnopek/issue-credits in the proposed resolution just as a placeholder.
This also reminded me that the "1 issue" link text that goes to all recorded issues for a project is not accessible (in that it is not clear that you will get more than one issue when you click on it). But that's potentially out of scope for this issue.
A display: inline; on the h4 will let the "(All recorded issue credits)" be on the same line as the "Credited on N issues fixed in the past Y months" header. (I dont yet have an opinion on if it should visually be on the same line, or the next line. But wanted to remember how to make it there. :)
Comment #3
YesCT CreditAttribution: YesCT commentedComment #4
YesCT CreditAttribution: YesCT commentedComment #5
YesCT CreditAttribution: YesCT commented#2522070: Give better context for list of issues credited on d.o is "bigger"
The idea of *this* issue was that it could be "simple"
Comment #6
xjm#2522070: Give better context for list of issues credited on d.o is related (for explaining what this link actually shows).
Comment #7
YesCT CreditAttribution: YesCT commentedComment #10
drummUser profile pages now have a link to “View all issue credits” to get to older credits.