
Problem/Motivation
Comparing #357254: Transliteration of Russian letters to #2932249: Incorrect transliteration of some Russian Cyrillic characters there is a change: "shch" became "sch". I suspect this is a typo: none of the tables on http://transliteration.ru/ uses "sch" and as I mentioned the contrib issue also uses "shch". ICU also uses shch here although that doesn't necessarily mean it's the desirable version, after all it uses "ts" for ц where our table uses "c" instead. ICAO also recommends "shch" in https://www.icao.int/publications/Documents/9303_p3_cons_en.pdf
Proposed resolution
We agreed to settle on the ICAO and ICU standard transliterations of the characters.
Therefore, we will update the Cyrillic translation table:
- Use
shch
for lowercase щ - Use
SHCH
for uppercase Щ
See #2932249: Incorrect transliteration of some Russian Cyrillic characters for reference on these changes.
The Wikipedia page documenting the Unicode table is a helpful reference for updating the transliteration data.
Remaining tasks
- NR
- Subsystem maintainer review
- Review from someone who builds sites that transliterate Russian
- (optional, possible followup) Feedback from Bulgarian-speakers :)
User interface changes
Correct transliteration of the character in various strings, UI tokens, etc.
API changes
N/A
Data model changes
N/A
Release notes snippet
Not needed.
Comment | File | Size | Author |
---|---|---|---|
#30 | 3215368-nr-bot.txt | 730 bytes | needs-review-queue-bot |
#26 | 3215368-nr-bot.txt | 730 bytes | needs-review-queue-bot |
Issue fork drupal-3215368
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3215368-shcha
changes, plain diff MR !12575
Comments
Comment #2
ghost of drupal pastComment #3
acbramley CreditAttribution: acbramley at PreviousNext for Service NSW commentedTriaged as part of BSI today, we'll need to confirm the bug with someone that can speak Russian.
Comment #4
acbramley CreditAttribution: acbramley at PreviousNext commentedComment #6
dimas11 CreditAttribution: dimas11 commentedц => ts
For example царь => tsar
Comment #7
andypostThat's about difference between
Ш
andЩ
Used to grep and a bit disappointed as both are valid but maybe not aligned with ICU
is correct for Ukraine
so both letters are covered
'sh', 'sch'
for Russian but as comment #6 already said it's preferable to continue use it - bothts
andsch
https://en.wikipedia.org/wiki/GOST_7.79-2000Comment #8
longwave#3169212: Improve transliteration of Ukrainian letters also has some discussion on this.
Comment #9
smustgrave CreditAttribution: smustgrave at Mobomo commentedSo ultimately what is the path forward for this one?
Comment #10
smustgrave CreditAttribution: smustgrave at Mobomo commentedSince it's been about a month wonder what the path forward is for this one? Anything can be changed or no matter what is one approach wrong.
Comment #11
valthebaldAs @andypost mentioned in #7, the issue is about 2 variants of transcribing "щ" character that are found in the core.
From several sources I've checked, "shch" variant is more "favourable", so I'd suggest use it consistently in all places
Comment #12
valthebaldComment #13
andypostLet's use ICU variant -
shsh
as the summary statesComment #14
xjmAgreed;
shch
should be used for consistency with our other choices. Reference we used previously: https://en.wikipedia.org/wiki/List_of_Unicode_characters#Cyrillic(Pretty sure @andypost's
shsh
is a typo.)Comment #15
xjmI almost made the branch name
3215368-щ
but then no one would have been able to type it.Comment #16
xjmComment #18
xjm(Of course, there's the whole thing where in Bulgarian it makes almost a "th" sound as I learned during Dev Days last year, but what can you do.)
Comment #19
smustgrave CreditAttribution: smustgrave at Mobomo commentedSorry to be that guy can we update the issue summary with least proposed solution please. Will keep an eye for it to come back and rush review it
Comment #20
xjmlol, thanks Stephen. Updating the IS.
Comment #21
xjmComment #22
xjmComment #23
smustgrave CreditAttribution: smustgrave at Mobomo commentedI dont mind marking but I also dont speak the language so maybe someone who speaks can review for accuracy?
Comment #24
xjmA transliteration subsystem maintainer signoff would also be good.
There is no issue tag for "Давайте послушаем наших русскоязычных друзей!".
I am also interested to know what Bulgarians think about this transliteration, or if Bulgarian maybe needs an override like Danish has? But that may be out of scope.
Comment #25
xjmUpdating IS tasks.
Comment #26
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #27
xjmЩас!
Comment #28
xjmComment #29
amateescu CreditAttribution: amateescu for Tag1 Consulting commentedLooks good to me :)
Comment #30
needs-review-queue-bot CreditAttribution: needs-review-queue-bot as a volunteer commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #31
xjmNot sure what the bot is on about but this is like a two-character diff in a file that's almost never updated; it will apply easily even if the source branch is out of date, and I can't see how it's going to be failing static analysis inside this diff itself. Restoring RTBC.
Comment #35
catchCommitted/pushed to 11.x, cherry-picked to 11.2.x and 10.6.x, thanks!