Problem/Motivation

Comparing #357254: Transliteration of Russian letters to #2932249: Incorrect transliteration of some Russian Cyrillic characters there is a change: "shch" became "sch". I suspect this is a typo: none of the tables on http://transliteration.ru/ uses "sch" and as I mentioned the contrib issue also uses "shch". ICU also uses shch here although that doesn't necessarily mean it's the desirable version, after all it uses "ts" for ц where our table uses "c" instead. ICAO also recommends "shch" in https://www.icao.int/publications/Documents/9303_p3_cons_en.pdf

Proposed resolution

We agreed to settle on the ICAO and ICU standard transliterations of the characters.

Therefore, we will update the Cyrillic translation table:

  • Use shch for lowercase щ
  • Use SHCH for uppercase Щ

See #2932249: Incorrect transliteration of some Russian Cyrillic characters for reference on these changes.

The Wikipedia page documenting the Unicode table is a helpful reference for updating the transliteration data.

Remaining tasks

  • NR
  • Subsystem maintainer review
  • Review from someone who builds sites that transliterate Russian
  • (optional, possible followup) Feedback from Bulgarian-speakers :)

User interface changes

Correct transliteration of the character in various strings, UI tokens, etc.

API changes

N/A

Data model changes

N/A

Release notes snippet

Not needed.

Issue fork drupal-3215368

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Charlie ChX Negyesi created an issue. See original summary.

ghost of drupal past’s picture

Issue summary: View changes
acbramley’s picture

Status: Active » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative

Triaged as part of BSI today, we'll need to confirm the bug with someone that can speak Russian.

acbramley’s picture

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dimas11’s picture

ц => ts
For example царь => tsar

andypost’s picture

Status: Postponed (maintainer needs more info) » Needs review

That's about difference between Ш and Щ

Used to grep and a bit disappointed as both are valid but maybe not aligned with ICU

core/lib$ git grep "'shch'"
Drupal/Component/Transliteration/data/uk.php:21:  0x449 => 'shch',

is correct for Ukraine

core/lib$ git grep "'sch'"
Drupal/Component/Transliteration/data/kg.php:21:  0x449 => 'sch',
Drupal/Component/Transliteration/data/x04.php:13:  0x40 => 'r', 's', 't', 'u', 'f', 'kh', 'c', 'ch', 'sh', 'sch', '', 'y', '', 'e', 'yu', 'ya',

so both letters are covered 'sh', 'sch' for Russian but as comment #6 already said it's preferable to continue use it - both ts and sch https://en.wikipedia.org/wiki/GOST_7.79-2000

longwave’s picture

smustgrave’s picture

So ultimately what is the path forward for this one?

smustgrave’s picture

Status: Needs review » Postponed (maintainer needs more info)

Since it's been about a month wonder what the path forward is for this one? Anything can be changed or no matter what is one approach wrong.

valthebald’s picture

As @andypost mentioned in #7, the issue is about 2 variants of transcribing "щ" character that are found in the core.
From several sources I've checked, "shch" variant is more "favourable", so I'd suggest use it consistently in all places

valthebald’s picture

Status: Postponed (maintainer needs more info) » Active
andypost’s picture

Let's use ICU variant - shsh as the summary states

xjm’s picture

Agreed; shch should be used for consistency with our other choices. Reference we used previously: https://en.wikipedia.org/wiki/List_of_Unicode_characters#Cyrillic

(Pretty sure @andypost's shsh is a typo.)

xjm’s picture

I almost made the branch name 3215368-щ but then no one would have been able to type it.

xjm’s picture

Title: Is there a typo in the Russian transliteration table? » Use a more standard transliteration for Cyrillic щ
Status: Active » Needs review

xjm’s picture

(Of course, there's the whole thing where in Bulgarian it makes almost a "th" sound as I learned during Dev Days last year, but what can you do.)

smustgrave’s picture

Status: Needs review » Needs work

Sorry to be that guy can we update the issue summary with least proposed solution please. Will keep an eye for it to come back and rush review it

xjm’s picture

Issue summary: View changes
Status: Needs work » Needs review

lol, thanks Stephen. Updating the IS.

xjm’s picture

Issue summary: View changes
xjm’s picture

Issue summary: View changes
smustgrave’s picture

I dont mind marking but I also dont speak the language so maybe someone who speaks can review for accuracy?

xjm’s picture

A transliteration subsystem maintainer signoff would also be good.

There is no issue tag for "Давайте послушаем наших русскоязычных друзей!".

I am also interested to know what Bulgarians think about this transliteration, or if Bulgarian maybe needs an override like Danish has? But that may be out of scope.

xjm’s picture

Issue summary: View changes

Updating IS tasks.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new730 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

xjm’s picture

Щас!

xjm’s picture

Status: Needs work » Needs review
amateescu’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs subsystem maintainer review

Looks good to me :)

needs-review-queue-bot’s picture

Status: Reviewed & tested by the community » Needs work
StatusFileSize
new730 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

xjm’s picture

Status: Needs work » Reviewed & tested by the community
Issue tags: +no-needs-review-bot

Not sure what the bot is on about but this is like a two-character diff in a file that's almost never updated; it will apply easily even if the source branch is out of date, and I can't see how it's going to be failing static analysis inside this diff itself. Restoring RTBC.

  • catch committed ba0bf30f on 10.6.x
    Issue #3215368 by xjm, smustgrave, ghost of drupal past, valthebald,...

  • catch committed 114970ea on 11.2.x
    Issue #3215368 by xjm, smustgrave, ghost of drupal past, valthebald,...

  • catch committed 2d0d9189 on 11.x
    Issue #3215368 by xjm, smustgrave, ghost of drupal past, valthebald,...
catch’s picture

Version: 11.x-dev » 10.6.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, cherry-picked to 11.2.x and 10.6.x, thanks!