Drupal 10 readiness meeting / 10 May 2021 [#3210281]

Meeting will happen in #d10readiness on drupal.slack.com.

Hello and welcome to this Drupal 10 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Usually happens every other Monday at 18:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3210281`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

andypost	Andy, maintainer
hestenet (he/him)	Tim from DA - joining between meetings to stay caught up.
Sarah Corbine	Hello, Sarah, first time contributor. I do Front End stuff.
Gábor Hojtsy (he/him)	Gábor, Drupal 10 coordinator
mglaman	Matt, phpstan-drupaler
Chris Greatens	Hi! Chris from Bounteous.
xjm	:wave: Half here while dealing with legal drama
longwave	Dave, core contributor from the UK
Neslee	Neslee, goa. contributor
shaal	Ofer, Drupal-Rector, Umami
catch	Nat, core contributor from the UK.
mansoor20	Hello, Mansoor from India :wave:
hansa11	Hansa, India :wave:
Guilherme Vitoriano Pereira	Guilherme, Brazil. First meeting! :hooray:
anmolgoyal74	Hi, Anmol from India
Kristen Pol (she/her)	Kristen, Central California, catching up
gaurav mahlawat	Gauravmahlawat India
ashishdalvi	Ashish Dalvi, My first meeting in #d10readiness, catching up with current state of initiative and eager to start my contribution.
Kristen Pol (she/her)	Nice to have a few 1st timers here!
baddysonja	Hi, baddysonja from Germany here. A bit late to the party, but reading the threads to see what is happening.

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we'll open threads for them as appropriate.

hestenet (he/him)	Topic: Do we have a hitlist issue for D10 release yet?
andypost	Looking for opinions for #3075427: Create TemplateDiscovery for plugin managers to use as it blocker for front-matter adoption
xjm	The hitlist is the meta. Issues should be children of a child of the meta.
andypost	Another question is help topics, all requirements for stable is rtbc. So after it gets stable we should squash help with topics - should be done before 9.3? /cc @jhodgdon (she/her) (edited)
mglaman	not really a thread: but phpstan-drupal I am adding dynamic loading support for module_load_include which may find new bugs/problems
andypost	@mglaman would be great to get your review for https://www.drupal.org/project/drupal/issues/697946 in that context
mglaman	will do! I commented it on the phpstan-drupal issue so I can look
Gábor Hojtsy (he/him)	@Guilherme Vitoriano Pereira any specific areas you were interested to learn about or contributed to?
Guilherme Vitoriano Pereira	I'm new to Drupal, trying to contribute in core issues. I'm already part of the bugsmash group where I can do some manual reviews, summary updates and less complex patches. I want to help here too. I also recently became maintainer of a small module (content paywall) that is only D7 compatible and I'm slowly converting it to be D8/9 compatible.
Gábor Hojtsy (he/him)	@Guilherme Vitoriano Pereira that is a good first thing to do for sure :slightly_smiling_face:
Gábor Hojtsy (he/him)	also welcome!
hestenet (he/him)	Yes! Welcome! :tada:
Guilherme Vitoriano Pereira	Thanks! :hooray:

2️⃣ New Drupal 10 landing page on drupal.org at https://www.drupal.org/about/10

Gábor Hojtsy (he/him)	Feedback welcome in terms of what else should be covered.
Gábor Hojtsy (he/him)	This is not yet wired into the main menu, that only has a Drupal 9 menu item.
Kristen Pol (she/her)	Would it be possible to add a keynote video from DrupalCon or something similar that's recent?
Gábor Hojtsy (he/him)	The Drupal 10 keynote is not yet public.
Gábor Hojtsy (he/him)	Once it is published we can add it.
baddysonja	I agree and the page looks great.Can we add links to the correct issue queue of some of the key features that is being work on. This could be helpful for those who want to contribute and/or read about the feature.Example for Olivero would be this link: https://www.drupal.org/project/issues/drupal?text=&status=Open&prioritie... (edited)
baddysonja	I would also add information about the people who are leading this initiative in “How to get involved” or a link to this page here: https://www.drupal.org/about/core/strategic-initiatives/drupal10
Kristen Pol (she/her)	@baddysonja for now, it should be editable if you want to fix any links... once the video is added then we probably won't be able to edit anymore
Gábor Hojtsy (he/him)	This is a very high level page. I would not throw readers into random issues. That said the strategic initiative pages would be good link targets.
Kristen Pol (she/her)	Ah, good point

3️⃣ Top issue for Drupal 10 is at #3118143: [meta] Release Drupal 10 on December 14... or 15... 2022

Gábor Hojtsy (he/him)	@hestenet (he/him) raised this question :slightly_smiling_face:
Gábor Hojtsy (he/him)	the main key issues should all be children of this issue or children's children
hestenet (he/him)	Thanks! I think we built an explicit checklist int he issue summary back for D9 - with a core section and a D.o/DA section.
hestenet (he/him)	It was basically just the child issue list, but prioritized.
mglaman	it’s possible to query the d.o API for things who have those as parents
mglaman	(for “quick” generating that list)
xjm	When we get closer to alpha and beta, we'll start tagging alpha and beta blockers
xjm	If your issue isn't descended from the meta, try to find the right parent for it
Gábor Hojtsy (he/him)	@mglaman I used and posted a simple script in the Drupal 9 meta back in the day that generates a visual tree / mindmap version of the issues, but it did not seem like people used it or wanted it, so not doing it for Drupal 10 at this point
Gábor Hojtsy (he/him)	eg https://www.drupal.org/files/issues/2019-05-09/Release%20Drupal%209%20on...
Gábor Hojtsy (he/him)	colors based on priority :slightly_smiling_face:

4️⃣.1️⃣ Status of contributed projects from Drupal 9 to 10 compatibility

Gábor Hojtsy (he/him)	The Drupal Association is running the project analysis job on all 5660 Drupal 9 compatible projects to see how compatible they are with Drupal 10.
Gábor Hojtsy (he/him)	Visualized results at https://dev.acquia.com/drupal10/deprecation_status
Gábor Hojtsy (he/him)	So far 58% of projects are Drupal 10 compatible other than an info file change as far as the compatibility checking can tell :slightly_smiling_face: (both emphasis points are important)
Gábor Hojtsy (he/him)	That said, it is too early to declare Drupal 10 compatibility and you should not fix the problems manually for the other 42% either. See 4️⃣ .2️⃣.

4️⃣ .2️⃣ Automating Drupal 10 compatibility with drupal-rector

mglaman	After a little blow out on my end and recovery, I want to sync back with @Dan and see how I can help – letting him lead
Gábor Hojtsy (he/him)	@mglaman worked a lot on the 0.10 rector version update of drupal-rector in anticipation of making it Drupal 9 compatible afterwards.
Gábor Hojtsy (he/him)	@KarinG tested the minimised version of the port, but did not succeed (despite previously succeeding with @mglaman's more complete version)
Gábor Hojtsy (he/him)	the current PR to help test is at https://github.com/palantirnet/drupal-rector/pull/144
Gábor Hojtsy (he/him)	once this update is in, Drupal 9 compatibility can be added and coverage for Drupal 9 deprecated APIs can start to be implemented :slightly_smiling_face:
Gábor Hojtsy (he/him)	we have the top ones identified at https://github.com/palantirnet/drupal-rector/issues/136
Gábor Hojtsy (he/him)	also yay thanks @mglaman :slightly_smiling_face:
mglaman	side note: the static-drupal-autoloader is far along. one more hacking session and I think phpstan-drupal can use it, along with other tools like drupal-rector (edited)
Sarah Corbine	If we’re interested on working on these, should we create a new Issue?
mglaman	@Sarah Corbine unfortunately writing the rectors rules are kind of blocked. Not entirely, you could write a work in progress rule. But hard to test
Sarah Corbine	:thumbsup:
shaal	I just tested the minimal changes PR #144, the same way I tested Matt's PR #143 before.I am getting errorsPHP Warning: require_once(/workspace/ddev-gitpod/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit7/TestCompatibilityTrait.php): failed to open stream: No such file or directory in /workspace/ddev-gitpod/vendor/palantirnet/drupal-rector/config/drupal-phpunit-bootstrap-file.php on line 182Warning: require_once(/workspace/ddev-gitpod/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit7/TestCompatibilityTrait.php): failed to open stream: No such file or directory in /workspace/ddev-gitpod/vendor/palantirnet/drupal-rector/config/drupal-phpunit-bootstrap-file.php on line 182PHP Fatal error: require_once(): Failed opening required '/workspace/ddev-gitpod/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit7/TestCompatibilityTrait.php' (include_path='/workspace/ddev-gitpod/vendor/pear/archive_tar:/workspace/ddev-gitpod/vendor/pear/console_getopt:/workspace/ddev-gitpod/vendor/pear/pear-core-minimal/src:/workspace/ddev-gitpod/vendor/pear/pear_exception:.:/usr/share/php') in /workspace/ddev-gitpod/vendor/palantirnet/drupal-rector/config/drupal-phpunit-bootstrap-file.php on line 182Fatal error: require_once(): Failed opening required '/workspace/ddev-gitpod/web/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit7/TestCompatibilityTrait.php' (include_path='/workspace/ddev-gitpod/vendor/pear/archive_tar:/workspace/ddev-gitpod/vendor/pear/console_getopt:/workspace/ddev-gitpod/vendor/pear/pear-core-minimal/src:/workspace/ddev-gitpod/vendor/pear/pear_exception:.:/usr/share/php') in /workspace/ddev-gitpod/vendor/palantirnet/drupal-rector/config/drupal-phpunit-bootstrap-file.php on line 182
shaal	I'll add instructions of testing this way (without depending on rector-sandbox), and the error message I got.
mglaman	Yeah. That’s where we need the bootstrap.php hacks
mglaman	https://github.com/bluehorndigital/drupal-rector/blob/rector-0.10/config...
mglaman	Specifically// @todo This was added in 8.8.x, which means 8.7.x would fail on this but// people should upgrade to 8.9.x anyways.require_once $drupalRoot . "/core/tests/Drupal/TestTools/PhpUnitCompatibility/PhpUnit{$major}/TestCompatibilityTrait.php";class_alias("Drupal\TestTools\PhpUnitCompatibility\PhpUnit{$major}\TestCompatibilityTrait", '\Drupal\Tests\PhpunitVersionDependentTestCompatibilityTrait');
shaal	@mglaman I see the file you mention also in the minimal changes PR - https://github.com/palantirnet/drupal-rector/blob/rector-0.10-minimal-ch...
mglaman	oh wait
mglaman	weird, actually I don’t know why (edited)
shaal	oh wait
shaal	:facepalm:
mglaman	I’m going to wait on touching any of the code base until @Dan syncs w/ the Palantir team on direction before I touch it
shaal	I am on Drupal 9.1.8 (edited)
mglaman	or that
shaal	correction -minimal PR does work.It's important to test it on Drupal 8 :grin:
shaal	@Dan @mglaman Did you see this blog post? Does it help us?https://getrector.org/blog/prefixed-rector-by-default
shaal	and this - https://twitter.com/rectorphp/status/1391540181120032769?s=20
Dan	Looks like it probably does help. I may be able to take a look later. Thanks.
Dan	From what I read, it's a name change (a good one :) ) for Rector, but our experience is the same since we are using the prefixed version already. At some point, we just point to rector/rector instead of rector/rector-prefixed.I think it presents an interesting question, do we want to support two versions of Drupal Rector (Drupal Rector / Drupal Rector Source) to match Rector? I think that could be valuable and it seems like the developer tools (PhpUnit / PhpStan) require Rector Source and there could be value in doing development against that version of Rector. We've discussed the dependency challenges between Rector Source / Drupal before and I think that's still something to consider. (edited)
Gábor Hojtsy (he/him)	Phpstan did the same prefixed swap a year back. Where they swapped the prefixed project to be the main project.

5️⃣ Stabilising help topics

Gábor Hojtsy (he/him)	This is not a Drupal 10 release requirements, however there is good progress.
Gábor Hojtsy (he/him)	Topic raised by @andypost
andypost	I think this stabilization may affect new themes which also going to stable
andypost	The meta is #3027054: Help Topics module roadmap: the path to beta and stable
Gábor Hojtsy (he/him)	@andypost good point
andypost	But generally it needs to deprecate help topics and merge it into help moduleThe plan is [#3037230]But any reason to stabilize the module and deprecate it?
jhodgdon (she/her)	It would really help if the RTBC issues got committed. This has been our main bottleneck IMO.
daffie	Yes, it would be nice when the RTBC issues got some love from a core committer. :grin:

6️⃣ Drupal 9 testing with Symfony 5.3 update

Gábor Hojtsy (he/him)	@longwave updated #3161889: [META] Symfony 6 compatibility to 5.3.0-beta3
Gábor Hojtsy (he/him)	and turned up this interesting bug where we use a component we should not be using...PHP Fatal error: Uncaught Error: Class "Symfony\Component\Config\Loader\FileLoader" not found in /var/www/html/vendor/symfony/dependency-injection/Loader/FileLoader.php:32
catch	It's a dev dependency of the dependency injection component - I wonder if container builder or something related to that is assuming the code will only run during development.
longwave	so far what I think has happened is that Symfony has added a new compiler pass for PHP 8 attributes support, and that seems to assume Symfony's own YamlFileLoader rather than our custom one
longwave	maybe we can just remove that pass if it's not useful to us
longwave	a bit surprised that the DI component only has Config as a dev dependency, is building a container considered as development?
catch	@longwave probably technically build dependency, but yeah they just looked at us funny when we talked about building container in runtime.
catch	Removing the pass sounds like a good first step.
xjm	:rotating_light: We also need to have a core issue to make beta1 depend on SF 5.3 rc1 for the five components we ship in D9 on SF 5 (edited)
catch	Opened an issue #3213295: Update Symfony 5 components to 5.3-rc1
longwave	without some class_alias work we can't use Symfony's PassConfig any more on PHP 8, so i opened https://github.com/symfony/symfony/issues/41169 to get their opinion on this change
daffie	@longwave I see that we have a solution for the Symfony problem. What do we need to do in core?
longwave	i patched symfony 5.3.0-beta3 with the fix and it is running at #3161889: [META] Symfony 6 compatibility#mr569-note24385
Gábor Hojtsy (he/him)	Woot looks promising thanks!
Gábor Hojtsy (he/him)	Also good find!

7️⃣ Guest thread: stability of Olivero

Gábor Hojtsy (he/him)	While also not a Drupal 10 release requirement, Olivero is getting close to stable. Status is at #3177296: [META] Make Olivero stable
Gábor Hojtsy (he/him)	The Olivero team meeting was earlier today in #d9-theme.
Gábor Hojtsy (he/him)	@Sarah Corbine this may be a good area for you given your frontend focus :slightly_smiling_face:
Sarah Corbine	I’ll talk with @brianperry about the best way to approach that.
Gábor Hojtsy (he/him)	there are a couple of accessibility issues, and tech debt that could be picked up :slightly_smiling_face: @mherchel can also help match an issue for you
Sarah Corbine	that’d be great

8️⃣ CKEditor 5

Gábor Hojtsy (he/him)	Currently being built in a contributed project
Gábor Hojtsy (he/him)	https://www.drupal.org/project/ckeditor5
Gábor Hojtsy (he/him)	If you have a contributed extension of CKEditor 4, porting your extension to 5 would be really welcome to prove the new API.