Closed (duplicate)
Project:
Drupal core
Version:
9.5.x-dev
Component:
Olivero theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Mar 2021 at 11:50 UTC
Updated:
25 Jul 2022 at 14:16 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
meghasharma commentedPlease review the patch
Comment #3
meghasharma commentedUpdated patch, please review
Comment #4
abhijith s commentedApplied patch #3 and it works fine.The title becomes properly aligned after applying this patch.
Before path:

After patch:

RTBC +1
Comment #5
gauravvvv commentedI have attached the before and after patch screenshot for reference.
Moving to RTBC.
Comment #6
gauravvvv commentedComment #7
gauravvvv commentedComment #9
gauravvvv commentedComment #10
spokjeTest failure was caused by #3207086: [HEAD BROKEN] Consistent failure in MonthDatePluginTest which is fixed. Ordered retest and put this issue back to RTBC per #6.
Comment #13
catchRestoring status after HEAD was broken.
Comment #14
lauriiiBased on https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap
word-wrapis deprecated. Should we useoverflow-wrapinstead?Comment #15
Agnesh Tank commentedVerified and tested patch#3 on Olivero 9.3.0-dev version with 9.3.x-dev Patch applied successfully and result is Acceptable.
Testing Steps:
Testing Output:
After applying the patch the title is displayed properly in wrapped form. Please refer attached Before patch and After patch images for reference. Hence moving this ticket to RTBC.
Comment #16
imalabyaMoving to NW
As per @lauriii's comment in https://www.drupal.org/project/drupal/issues/3210358#comment-14155124
Since the overflow is specific for the title element, the fix should be applied only for the title.
Comment #17
imalabyaAdded a patch to update the
.page-titleAlso, added a hypen to specify the break.
Comment #18
imalabyaComment #19
roshanibhangale commentedComment #20
roshanibhangale commentedVerified and tested patch #17 on the drupal 9.3.x-dev version. Patch applied successfully.
Testing Steps:
Expected Result:
Actual Results:
Please refer attached screenshot.
This is can be move to RTBC.
Comment #21
roshanibhangale commentedComment #22
mherchelIn order to properly test this, we'll need screenshots in Chrome, FF, and Safari of long text breaking, as well as properly spaced text to ensure that it doesn't improperly break.
Comment #23
hmendes commentedAdding after patch screenshots on Chrome and Firefox, I can't test this on Safari.
Comment #24
mherchelThanks for the screenshots, but the spacing screenshot needs to tell me if the word breaks are in the correct place.
Unfortunately, I can't tell where they are supposed to be. It would be nice if we had words when testing out the spacing. Such as 'test test test' etc.
Comment #25
hmendes commentedHey mherchel,
It breaks the line after the space. Adding others screenshot to reference, is that what you wanted?
Comment #26
chetanbharambe commentedVerified and tested patch #17.
Patch applied successfully.
Testing Steps:
# Go to Appearance -> Set Olivero theme
# Create a basic page with a long title and long body without any space
# Save it
# See the results
Expected Results:
# Title should not overflow when title link text is too long.
Actual Results:
# Title overflow when title link text is too long.
Issue: Currently Page is not stable and it's horizontally scrollable.
Please refer attached screenshots.
Looks good to me.
Can be a move to Needs work.
Comment #27
xjmThis is a normal priority bug under the normal issue priority definition, which specifically refers to:
Comment #28
vikashsoni commentedApplied patch #3 working fine after patch the body field coming in proper layout
Thanks for the patch
for ref sharing screenshot
Comment #30
Shubham Sharma 77 commentedI have applied patch #3 before and after screenshots.
Comment #31
Shubham Sharma 77 commentedComment #32
kristen pol@Shubham Sharma 77 @vikashsoni @chetanbharambe and anyone else testing this issue, please:
1) Do not test something again if you are just testing the same thing. There have been 6 people who have tested this issue since the patch was provided and it would be much more helpful if people read the previous comments and respond accordingly.
2) Note the browsers and testing steps.
3) See #24 for testing directions. Some of these things have been tested already, you can look at the various comments and figure out what is left to test.
Comment #34
rinku jacob 13 commentedComment #35
asha nair commentedApplied patch #34 cleanly. Adding results as screenshots.
Comment #36
smustgrave commentedTested #34 and it worked perfectly.
Comment #37
mherchel#34 doesn't provide proper line breaking in all browsers.
Attaching image of Safari as an example.
This issue is trickier than it seems. CSS does not give us proper tools to take into account all use cases, and I don't want to bloat the page with JavaScript.
This issue is a duplicate of #3177475: Olivero: Ensure long words break properly when zoomed in to provide proper reflow (the same issue marked as related). If you go through the (long) comments, you can see various explanations, code samples, codepens, accessibility reviews, etc.