Umami demo: Body overflow when link text too long.

Adding screenshot for reference.

CommentFileSizeAuthor
#13 After-patch-text.png23.22 KBMadhu kumar
#13 before-patch-text.png11.52 KBMadhu kumar
#12 3210358-after-patch.png70.86 KBindrajithkb
#12 interdiff_4-12.txt406 bytesindrajithkb
#12 3210358-12.patch439 bytesindrajithkb
#7 After patch.png675.18 KBmanojithape
#7 Before patch.png727.78 KBmanojithape
#4 interdiff-2-4.txt425 byteskishor_kolekar
#4 3210358-4.patch457 byteskishor_kolekar
#2 Screenshot 2021-04-23 at 13.33.50.png133.79 KBgauravvvv
#2 3210358-2.patch410 bytesgauravvvv
Screenshot 2021-04-23 at 13.24.47.png91.81 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3210358-2.patch410 bytes
new Screenshot 2021-04-23 at 13.33.50.png133.79 KB

I have provided the patch. please verify if it is working or not.

Adding an after patch screenshot for reference.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
kishor_kolekar’s picture

kishor_kolekar commented
StatusFileSize
new 3210358-4.patch457 bytes
new interdiff-2-4.txt425 bytes

As patch # 2 Custom command failed.
Added new pacth

manojithape’s picture

manojithape commented
Assigned: Unassigned » manojithape
manojithape’s picture

manojithape commented
manojithape’s picture

manojithape commented
Assigned: manojithape » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before patch.png727.78 KB
new After patch.png675.18 KB

Verified and tested patch#4. Patch applied successfully and looks good to me.

Testing Steps:

1-Install drupal 9.2.x-dev version with Umami Demo site.
2-Go to Content ->Add Content-> Add "Recipe" content with long text (word without space) in the below fields
Recipe Name
Summary
Recipe instruction
3-Publish added Recipe node and observe on the view page Recipe Name, Summary, Recipe instruction field overflow. (Refer attached screenshot i.e. Before patch.png)
4-Now apply the patch and again go to view Recipe node and observe Recipe Name, Summary, Recipe instruction field not overflow in case text is too long (a word without space)

Testing Results:
Recipe Name, Summary, Recipe instruction field does not overflow in case text is too long (without space word). Long word breaks with - and remaining displayed on the next line. Please refer attached After patch.png screenshot.

Moving this ticket to RTBC.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3210358-4.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Reviewed & tested by the community

Unrelated failure, moving back to RTBC

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 3210358-4.patch, failed testing. View results

indrajithkb’s picture

indrajithkb commented
Status: Needs work » Needs review
StatusFileSize
new 3210358-12.patch439 bytes
new interdiff_4-12.txt406 bytes
new 3210358-after-patch.png70.86 KB

Hi @kishor_kolekar thanks for the #4 patch, here am re-rolling patch with 9.3.x-dev please review.
Removing the "hyphen:auto". Here it's not making any effect (We need XML:lang attribute to work with hyphen).

Attaching the SS and interdiff.

image

Madhu kumar’s picture

Madhu kumar commented
StatusFileSize
new before-patch-text.png11.52 KB
new After-patch-text.png23.22 KB

Patch #12 applied cleanly and able to see proper alignment when body overflow when link text too long.
Sharing Screenshot for reference.

RTBC +1

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs review » Reviewed & tested by the community
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Closed (won't fix)

Any of the use cases shown here doesn't seem likely to occur. Also the bug fix seems potentially high risk since it impacts all elements. Closing this as this seems like too high risk compared to the potential reward.

If there are individual elements that are impacted in realistic use cases, feel free to open issues to those, so that fixes for those can be evaluated on case by case basis.