[meta] Replace calls to deprecated db_*() wrappers

moving db_truncate() to 2nd list, it is defined and only used in test files.

Moving following functions to 2nd list, as they don't have call implementation other than test files.

• db_xor
• db_escape_field
• db_escape_table
• db_query_temporary
• db_driver
• db_field_exists
• db_index_exists
• db_field_names

I think we should make the first issues about replacing code references, and then have a different combined followup for replacing all the documentation references for the different functions since they are often mentioned together. What do you think?

Added the db_query issue.

See #2953385: Add a $connection property to DatabaseTestBase kernel test class to be used by extending classes for a change to DatabaseTestBase.

If db_truncate is used in module, how can we replace that?

https://api.drupal.org/api/drupal/core%21includes%21database.inc/functio...

function db_truncate($table, array $options = []) {
  if (empty($options['target']) || $options['target'] == 'replica') {
    $options['target'] = 'default';
  }
  return Database::getConnection($options['target'])
    ->truncate($table, $options);
}

So, usage would be looks like:

\Drupal::database()->truncate($table);

$this->connection->truncate($table);

For db_field_set_default and db_field_set_no_default, I suggest to discuss in #2993663: Deprecate Schema::fieldSetDefault and Schema::fieldSetNoDefault, they're not used whether not just those, but even the new OOP methods should be deprecated.

• db_or #2117305: Replace usages of db_or() and db_and().
• db_and #2117305: Replace usages of db_or() and db_and().
• db_create_table #2848822: Replace all calls to db_create_table, which is deprecated

The issues here led to removing usage, but not to deprecation according to new standard, so we will need new issues to fix them.

Added related to db_ignore_replica #2286235: Deprecate db_ignore_replica() and convert it to service

Opened #2994556: Properly deprecate db_and, db_condition, db_or, db_xor.

filed #2994561: Properly deprecate db_create_table

Opened #2994694: Properly deprecate db_driver, db_escape_field, db_escape_table, db_rename_table, db_drop_index, db_drop_unique_key, db_add_unique_key, db_drop_primary_key, db_add_primary_key

Opened #2994904: Convert query('SELECT ... FROM {xxx}') to select('xxx')->... in tests that would help reducing later efforts on #2875394: Replace all calls to db_query, which is deprecated

Filed
- #2996436: Follow-up to fix DatabaseLegacyTest::testDbRenameTable
- #2996432: Replace all calls to db_truncate, which is deprecated.

Filed #2996441: Replace all calls to db_query_temporary, which is deprecated.

Opened

• db_add_index #2999586: Properly deprecate db_add_index
• db_index_exists #2999588: Properly deprecate db_index_exists

Created #2999612: Properly deprecate db_query_range

Filed patch for last one #2999678: Properly deprecate db_field_exists

Fixed #2999612: Properly deprecate db_query_range

Fixed #2999588: Properly deprecate db_index_exists

Fixed #2999678: Properly deprecate db_field_exists

Adding to IS some more issues that IMHO should be solved before closing this meta.

Fixed #2850037: Replace all calls to db_like(), which is deprecated

#3001216: Use the database.replica service where appropriate

#2959269: [meta] Core should not trigger deprecated code except in tests and during updates

All calls were replaced

Reprioritized the issues. The real blocker for this meta is the issue #2947946: Create change record for all deprecated db_* functions

The last required issue is resolved, so all calls to functions from database.inc file was replaced and properly deprecated.
Set status to Needs review to collect more opinions and potentially resolve this issue as Fixed.

My mistake. Closed #3049380: Complete deprecation of _db_get_target() function issue. So we still need to resolve #2947946: Create change record for all deprecated db_* functions

#2947946: Create change record for all deprecated db_* functions fixed.

This meta could be closed cos only 2 issues left but they are just related

Agree. Mark as fixed.
Only #2849745: Replace documentation recommending db_*() wrappers left to completely deprecate database.inc file.