See #2848161: [meta] Replace calls to deprecated db_*() wrappers

Problem/Motivation

Using the RegressionTest class for deprecation tests is confusing. In the parent issue the testDbTableExist method has been changed to track deprecation, which means that it will be dropped in 9.0 when the db* wrappers will be removed from code. But that test is pre-existing and should not be dropped.

Proposed resolution

Add a DatabaseLegacyTest class for deprecation tests only, and move the tests already coded there.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 interdiff_2-4.txt495 bytesmondrake
#4 2991542-4.patch4.11 KBmondrake
#2 2991542-2.patch4.14 KBmondrake
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Title: Replace all calls to db_table_exists, which is deprecated. » Introduce a DatabaseLegacyTest class for deprecation testing
Status: Active » Needs review
FileSize
2991542-2.patch4.14 KB
voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented
Status: Needs review » Needs work 
+++ b/core/tests/Drupal/KernelTests/Core/Database/DatabaseLegacyTest.php
@@ -0,0 +1,42 @@
+
+use Drupal\Core\Database\Database;

This is redundant code.
DatabaseTestBase already has database connection injected into connection property.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Needs work » Needs review
FileSize
2991542-4.patch4.11 KB
interdiff_2-4.txt495 bytes

Indeed, thank you @voleger

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for GOLEMS GABB, Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

Tests are "green". +1 for RTBC
And let's continue with replacing deprecated db_* functions.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 3f44f5bbcb to 8.7.x and c4c573303d to 8.6.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Backported to 8.6.x since this is a test-only change.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.