See #2848161: [meta] Replace calls to deprecated db_*() wrappers

CommentFileSizeAuthor
#9 2996432-9.patch4.07 KBandypost
#5 2996432-5.patch4.04 KBandypost
#5 interdiff.txt2.29 KBandypost
#3 2996432-3.patch4.03 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Replace all calls to db_drop_table, which is deprecated. » Replace all calls to db_truncate, which is deprecated.
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 2996432-3.patch4.03 KB
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

Yep.

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt2.29 KB
new 2996432-5.patch4.04 KB

I think it would be more inline with other deprecations - probably needs follow-up to fix few other messages

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Reviewed & tested by the community » Needs work

Fails on SQLite

andypost’s picture

andypost
he/him
Primary language Russian
commented

It fails on sqlite/pgsql waiting for #2996436: Follow-up to fix DatabaseLegacyTest::testDbRenameTable

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review

Queued sqlite/pgsql as follow-up was commited

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 2996432-9.patch4.07 KB

re-roll after fixes

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

All db pass, back to RTBC.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 2996432-9.patch, failed testing. View results

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Reviewed & tested by the community

Only failed due to timeout when downloading from GitHub, so back to RTBC

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 0875ceb and pushed to 8.7.x. Thanks!

  • catch committed 0875ceb on 8.7.x 
    Issue #2996432 by andypost: Replace all calls to db_truncate, which is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.