User role machine name created with caps and spaces [#2824519]

Problem/Motivation

It is possible to create a role programmatically with invalid machine name characters:

$role = \Drupal\user\Entity\Role::create([
  'id' => 'aBc !',
  'label' => 'zyx',
]);
$role->save();

Then navigate to /admin/people/roles/manage/aBc !

You can no longer save the form because machine names are immutable.

cant change machine name

Proposed resolution

? - Refer to parent #2845517: Enforce allowed characters of machine names in config entities.

Original report by suresh kumara

User role machine name created with invalid characters

How to replicate issue?

I have create role using drush.

drush role-create 'Unapproved Teacher'

The machine name of a role created as Unapproved Teacher.

The machine name of a role should be unapproved_teacher.

Comment	File	Size	Author
#4	role_invalid_machinename.jpg	104.78 KB	dpi
	Edit role ipassio.png	65.98 KB	FlutterStack

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 November 2016 at 06:14

suresh kumara created an issue. See original summary.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 3 November 2016 at 08:08

Looks like drush problem, because it create role via create Role instance directly. Proof:

    $role = new Role(array(
      'id' => $role_machine_name,
      'label' => $role_human_readable_name,
    ), 'user_role');
    $role->save();

But maybe we must override Role construct with the necessary checks, for stable work via third-party applications?

Comment #3

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 3 November 2016 at 10:04

Priority:	Critical	» Normal
Related issues:		+#2164373: [META] Untie config validation from form validation — enables validatable Recipes, decoupled admin UIs …

@suresh kumara thanks for reporting this issue. Before we can work out what to do here we need a bit more information. Why is this a critical issue? What are the effects on the site? I agree we have issues around configuration validation when creating config via the API and not the UI but an contributed project abusing the API does not make a critical. I'm going to tentatively just mark this a normal bug and relate it to the work on config validation.

Comment #4

dpi

Perth, Australia

CreditAttribution: dpi as a volunteer commented 21 January 2017 at 07:26

Issue summary:	View changes
Parent issue:		» #2845517: Enforce allowed characters of machine names in config entities.

File	Size
role_invalid_machinename.jpg	104.78 KB

Reformatted issue summary, linked to relevant parent.

Comment #5

21 January 2017 at 07:26

Version:

8.2.x-dev

» 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #6

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 commented 1 July 2017 at 06:41

I think a constraint (if already not available) will be good to check violation.

Comment #7

1 July 2017 at 06:41

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #8

1 July 2017 at 06:41

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #9

1 July 2017 at 06:41

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #10

1 July 2017 at 06:41

Version:

8.6.x-dev

» 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #11

1 July 2017 at 06:41

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.