Enforce allowed characters of machine names in config entities. [#2845517]

It is currently possible to programmatically create config entities with invalid machine names.

Form UI typically enforces "Only lowercase alphanumeric characters and underscores are allowed, and only lowercase letters and underscore are allowed as the first character".

This issue also means that if go to edit a configuration entity, the form will no longer submit because an invalid machine name was used

Non exhaustive list of configuration entities which make use of machine name in their forms:

Config	Current behaviour	Issue
Block	Invalid machine name permitted
FieldStorageConfig	Throws exception on create (Attempt to create a field storage xyz with invalid characters)	-
Node type	Invalid machine name permitted
Role	Invalid machine name permitted	#2824519: User role machine name created with caps and spaces
Vocabulary	Invalid machine name permitted

Comments

Comment #1

21 January 2017 at 07:10

dpi created an issue. See original summary.

Comment #2

dpi

Perth, Australia

CreditAttribution: dpi as a volunteer commented 21 January 2017 at 07:17

Issue summary:

View changes

Comment #3

dpi

Perth, Australia

CreditAttribution: dpi as a volunteer commented 21 January 2017 at 07:29

Is it worth duplicating the same logic as \Drupal\field\Entity\FieldStorageConfig to other config types?

public function __construct(array $values) {
  // ...
  if (!preg_match('/^[_a-z]+[_a-z0-9]*$/', $values['field_name'])) {
    throw new FieldException("Attempt to create a field storage {$values['field_name']} with invalid characters. Only lowercase alphanumeric characters and underscores are allowed, and only lowercase letters and underscore are allowed as the first character");
  }
  // ...

Comment #4

21 January 2017 at 07:29

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #5

21 January 2017 at 07:29

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #6

21 January 2017 at 07:29

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #7

21 January 2017 at 07:29

Version:

8.6.x-dev

» 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #8

21 January 2017 at 07:29

Version:

8.7.x-dev

» 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #9

21 January 2017 at 07:29

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #10

bircher

🇨🇿

CreditAttribution: bircher as a volunteer and at Nuvole commented 31 October 2019 at 12:43

Comment #11

31 October 2019 at 12:43

Version:

8.9.x-dev

» 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #12

31 October 2019 at 12:43

Version:

9.1.x-dev

» 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Comment #13

31 October 2019 at 12:43

Version:

9.2.x-dev

» 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #14

31 October 2019 at 12:43

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.