Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Evaluate if we need to port the fix from #2305017: Regression: Files or images attached to certain core and non-core entities are lost when the entity is edited and saved (#96) to D8, to allow for wrappers such as s3:// or hash://
Comment | File | Size | Author |
---|---|---|---|
#5 | use_another_wrapper-2748555-3.patch | 904 bytes | pareshpatel |
#2 | 2748555-2.patch | 909 bytes | stefan.r |
Comments
Comment #2
stefan.r CreditAttribution: stefan.r commentedNote: IMO this should only be accepted if there's actually a need for this (such as a real-world module), no need to add this if no one cares about this :)
Comment #4
mayurjadhav CreditAttribution: mayurjadhav commentedComment #5
pareshpatel CreditAttribution: pareshpatel as a volunteer and at Cybage Software Pvt Ltd. commentedHi Stefan,
I have checked your patch but it seems that variable_get function which you have used in your patch is deprecated now in drupal 8 so I have used with drupal 8 config API instaed of that and creates a patch for the same.
Please find the attached patch.
Thanks.
Comment #6
pareshpatel CreditAttribution: pareshpatel as a volunteer and at Cybage Software Pvt Ltd. commentedKindly review the patch "https://www.drupal.org/files/issues/use_another_wrapper-2748555-3.patch".
Comment #7
tstoecklerHmm... I'm not sure if this is correct. Can you elaborate more on the use-case? AFAIK this check is only because public:// files are always publically accessible anyway, so it's pointless to control access if it's requested via PHP. Not sure what changing that stream wrapper would change.
Comment #8
pareshpatel CreditAttribution: pareshpatel as a volunteer and at Cybage Software Pvt Ltd. commentedYes. I have just removed the hard coded value of stream wrapper. so It may be possible that it should help if there are multiple stream wrappers which we can use.
Comment #19
smustgrave CreditAttribution: smustgrave at Mobomo commentedif still a valid request think this will need a test