Problem/Motivation

The discussion in #2120875: Remove breakpoint and picture module from core was resolved by closing that discussion but marking as needing to be revisited before D8 beta. A number of issues were identified that needed to be addressed in the Picture and Breakpoints modules. This issue is intended to track those and any new issues that arise before beta.

Update
Since D8.0 beta is here, this is all about followups now.

Open issues

#1836860: Picture doesn't work with AJAX callback
#1855412: Enable responsive_image.module by default for standard install profile
#1701116: Responsive Images UI/UX: Image styles
#1880606: Introduce a configuration UI for theme-based breakpoints
#1898442: responsive_image.module - Convert theme_ functions to Twig
#2123251: Improve DX of responsive images; convert theme functions to new #type element
#2220865: Add empty img element inside picture element
#2349461: Move fallback image style into the responsive image style entity
#2348255: Provide option to use srcset and/or sizes attributes on img tag instead of the picture element
#2349859: Responsive Image Mappings :: throws a fatal exception if no image style is set
#2260061: Responsive image module does not support sizes/picture polyfill 2.2
#2343351: Make picture polyfill optional
#2334387: UI changes to support current responsive image standards
#2372187: Add getDescription in Breakpoint module

Fixed/Closed issues

#2254071: [PP-1] Responsive images can't be linked to Content
#2254071: [PP-1] Responsive images can't be linked to Content
#1701112: Advanced responsive images UI/UX for breakpoints
#2203459: responsive_image mapping doesn't implement 'delete' function
#1937914: Special handling for setting the BreakpointGroup::breakpoints property during ConfigStorageController::importChange()
#1828606: Make BREAKPOINT resources inheritable
#1851018: Improve breakpoint configuration implementation.
#1883526: Decide on the picture polyfill to use
#2123225: Do not upscale by default
#2026319: Mis-named variables in picture_theme()
#2030653: Expand ResponsiveImageMapping with methods
#2078001: Modernize responsive_image.module forms
#2124377: Rename "Picture" module to "Responsive Image" module
#2132551: Picture module uses config keys with a dot
#2204159: (Responsive) Image styles do not add correct cache tags, nor do they invalidate cache tags upon flushing
#2211831: Removal of alt attribute from [picture] tag
#2219329: ResponsiveImageMapping::mappings and ResponsiveImageMapping::breakpointGroup properties have inconsistent return structure and type respectively
#2222431: Project name clean up after Picture module renamed Responsive Image
#2225677: Fix naming in ResponsiveImageMappingEntityTest following module rename from Picture to Responsive Image
#2227435: Remove noscript from picture element markup
#2243549: Text changes needed as follow-up to Menu UI module rename
#2245727: Add missing configuration schema in Breakpoint component
#1820512: Move Breakpoint module closer to meeting Drupal standards
#1945228: Repetitive config in breakpoint.module
#1945362: error messages on admin page for picture mappings
#1971174: BreakpointGroup::loadAllBreakpoints() is expensive
#1982818: Automatically sort breakpoints from small to large
#1999312: Add an 'empty image' option for responsive image
#2030585: Expand Breakpoint with methods
#2030587: Expand BreakpointGroup with methods
#2271529: Move breakpoint settings to theme and module *.breakpoints.yml files at root level
#2349789: Responsive Image Mappings are not listed with sqlite
#2267563: Uncaught SQLite failure breaks responsive images
#2315077: Using the "Link image to" feature of the picture formatter causes a fatal error
#2342439: Some test modules/themes missing "Testing" package assignment in their info files.
#2318801: Breakpoint Module: Fix documentation that refers to enabling/disabling of modules
#2030587: Expand BreakpointGroup with methods

Comments

dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes

Added new issue to list

dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Title: [Meta] Followup Picture and Breakpoints in core » [Meta] Followup Responsive_image(Picture element) and Breakpoints in core
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
Related issues: +#2009662: [REGRESSION] Replace theme() with drupal_render() in picture module
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes

Some of these added because they hit breakpoint/responsive_image code. Some should be reviewed to see if they are still relevant.

dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
Related issues: +#1898420: image.module - Convert theme_ functions to Twig, +#2061377: [drupalImage] Optionally apply image style to images uploaded in CKEditor 5

Not sure how to properly handle 'related' issues. These touch breakpoint/responsive_image code bur in a minor way. Should I just track them in a list?

dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
Related issues:
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
attiks’s picture

attiks CreditAttribution: attiks commented

Just a heads up #2271529: Move breakpoint settings to theme and module *.breakpoints.yml files at root level will simplify everything of breakpoints and will close a lot of issues,

attiks’s picture

attiks CreditAttribution: attiks commented

#2271529: Move breakpoint settings to theme and module *.breakpoints.yml files at root level got committed, I closed the other ones

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray commented
Issue summary: View changes
RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray commented
Issue summary: View changes
RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray commented
Issue summary: View changes

Once we take care of #2260061: Responsive image module does not support sizes/picture polyfill 2.2, a lot of the postponed issues will get unblocked or will no longer be relevant.

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes

Updates

dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented

I have made a feature request for Breakpoints: #2372187: Add getDescription in Breakpoint module

dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes
dcrocks’s picture

dcrocks CreditAttribution: dcrocks commented
Issue summary: View changes

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.