Allow selecting multiple checkboxes on "Modules" page with a single click

Can I give this issue a try, I think I can do this. This will be my 2nd Issue. :)

Hi,

I have added js in form.js file which works fine and resolved this issue. Adding image and patch for review.

Thanks,
Prateek

@prateek - Functionality seems to be working fine.However, code needs to be cleaner.Changing status to Need work so that you can format it properly

Aman,

Thanks for reviewing this patch. I have formatted this patch. Please review it.

Thanks,
Prateek

All,

Please review this and let me know if any thing needs to be change.

@prateekS To get a review, you need to change the status to "needs review".

Hi Yannickoo,

I have also written js code for this issue which is working fine and added patch for it. Just wanted to review so that it this issue can be resolved.

Can you make tableselect reusable for module page ?

This code working fine, but Drupal.tableSelectRange function do this already on contents overview page. We can add this feature to tableselect.js, just remove "select all" function from modules page.

We're not going to make a jquery plugin for that. Having it in form.js is a problem too, I'd rather have a standalone file if we make it generic like that.

As droplet said, it'd be better to reuse what we have already instead of making something brand new. Or you can improve what we have right now with your code too, that works.

Features are not for 8.0.x

@droplet @tompagabor @nod_, thanks for response. The html structure of content overview and module page bit change and if we will going to use tableselect.js for these two section then either we have to change html structure one of the page or have to add some js in tableselect js file.

So one thing, which will be i can remove js from form.js file and add here (tableselect.js). and do necessary changes, if require.

Thanks,
Prateek

Yes, yannickoo, this is good. But JS which i used for module page is also doing same thing. So we can use that also for our requirement.

tableselect.js is a simple lib already :) We can do a little trick for that.

Source file on GIT 8.1.x branch are outdated...

Here's droplet's idea rebased on current 8.1.x.

Submitting the same patch again to hopefully activate the test bot.

Lets see if testbot picks this up..

re uploading for 8.0.x, don't credit me for this

Looks good, I dont know if this is actually accessible?

ok with me.

Tested select-all-2104633-27.patch on Firefox and chrome browser for Ubuntu 14.04. Its working fine.
After applying the patch, user is allowed to select multiple check-boxes on "Modules" page with a single click.
User can select multiple nodes while clicking shift and selecting the first and the last check-box.
Screenshots attached.

I don't see this as being a barrier, so removing the "needs accessibility review"

The functionality is already in Core, it's just about applying this consistently across the UI. Because it's an inconsistent UI, I'm marking it as a bug. Makes no sense that it works in /admin/content but not /admin/modules

I tested it on a Mac in Firefox & Chrome.

We could look at setting up a follow-up issue to see if we could replicate this functionality for keyboard only users and screen readers. I'm not sure what the pattern would be yet.

This results in visual changes to the install and uninstall forms - in HEAD when you select them the rows do not turn yellow - with the patch they do. Whilst this might be desired - it is not a stated aim of the issue and I don't think this change has had adequate consideration because it is not discussed on issue.

Also I think the description of this as a bug is pretty tenuous and if it is a bug then we should be adding this functionality to ALL tables that have checkboxes like this. There are a few in multilingual configuration that comes to mind. I think this is just a task and as such is eligible for inclusion in 8.1.x.

Hi,
I have patched to remove color while selecting on the below patch selecting_multiple_checkboxes_2104633_39.patch

This patch works fine if we selected two check box within wrapper.

I've reviewed select-all-2104633-27.patch. It also fixes this issue on 8.4.x branch.

It is not clear from the comments why this was moved from NR to NW. Maybe that was an accident?

Please pay attention to the comment in #37.

I'm at Drupalcon, and will be working on this issue for the next hour. Find me if you want to work on this too. (#301)

Re-rolled.

I've tested the patch from #48 and here are the results:

• Before: https://www.drupal.org/files/issues/module_select_before.mov
• After: https://www.drupal.org/files/issues/module_select_after.mov

The sequential checkboxes are selected/unselected between click (with shift being held be for the second click) and there is no change in the visual styling.

Although it works, I think the code still need a little more work.

In core/misc/tableselect.js around lines 96-97 there is a comment but the code it referrers to appears to have been removed. Is this the case?

Also, after the patch multiple select on admin/content doesn't highlight the selected rows yellow, and is therefore a regression.

We need to decide if the task is actually to make the tables consistent as there are other styling differences. If this is the case, the issue summary need to be updated to reflect this.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!