Problem/Motivation

If you go to the content overview you can select multiple nodes while clicking shift and selecting the first and the last checkbox (see video).
Navigate to the modules page, there is not the same behavior. Neither on the modules overview and the modules which you can uninstall.

Proposed resolution

Put that functionality on the modules page

Remaining tasks

  • Needs re-roll.
  • All the latest patches fail to apply in 8.4.x
  • This issue is not necessarily a bug, seems more like a task (comment #37 has more details)

Comments

JayKandari’s picture

Issue summary: View changes

Can I give this issue a try, I think I can do this. This will be my 2nd Issue. :)

prateekS’s picture

Assigned: Unassigned » prateekS
prateekS’s picture

FileSize
308.79 KB
974 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 88,775 pass(es). View

Hi,

I have added js in form.js file which works fine and resolved this issue. Adding image and patch for review.

Thanks,
Prateek

amankanoria’s picture

Status: Active » Needs review
amankanoria’s picture

Status: Needs review » Needs work
Issue tags: +SprintWeekend2015

@prateek - Functionality seems to be working fine.However, code needs to be cleaner.Changing status to Need work so that you can format it properly

prateekS’s picture

FileSize
944 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,504 pass(es). View

Aman,

Thanks for reviewing this patch. I have formatted this patch. Please review it.

Thanks,
Prateek

prateekS’s picture

All,

Please review this and let me know if any thing needs to be change.

AjitS’s picture

Status: Needs work » Needs review

@prateekS To get a review, you need to change the status to "needs review".

LewisNyman’s picture

Issue tags: +frontend, +JavaScript, +Usability
yannickoo’s picture

I just want to mention that you can find the code here for the content overview.

prateekS’s picture

Hi Yannickoo,

I have also written js code for this issue which is working fine and added patch for it. Just wanted to review so that it this issue can be resolved.

droplet’s picture

Can you make tableselect reusable for module page ?

tompagabor’s picture

This code working fine, but Drupal.tableSelectRange function do this already on contents overview page. We can add this feature to tableselect.js, just remove "select all" function from modules page.

nod_’s picture

Category: Task » Feature request
Status: Needs review » Needs work

We're not going to make a jquery plugin for that. Having it in form.js is a problem too, I'd rather have a standalone file if we make it generic like that.

As droplet said, it'd be better to reuse what we have already instead of making something brand new. Or you can improve what we have right now with your code too, that works.

nod_’s picture

Version: 8.0.x-dev » 8.1.x-dev

Features are not for 8.0.x

prateekS’s picture

@droplet @tompagabor @nod_, thanks for response. The html structure of content overview and module page bit change and if we will going to use tableselect.js for these two section then either we have to change html structure one of the page or have to add some js in tableselect js file.

So one thing, which will be i can remove js from form.js file and add here (tableselect.js). and do necessary changes, if require.

Thanks,
Prateek

yannickoo’s picture

prateekS’s picture

Yes, yannickoo, this is good. But JS which i used for module page is also doing same thing. So we can use that also for our requirement.

droplet’s picture

Assigned: prateekS » Unassigned
Status: Needs work » Needs review
FileSize
1.74 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 94,434 pass(es). View

tableselect.js is a simple lib already :) We can do a little trick for that.

Status: Needs review » Needs work

The last submitted patch, 19: select-all.patch, failed testing.

droplet’s picture

Version: 8.1.x-dev » 8.0.x-dev
Status: Needs work » Needs review

Source file on GIT 8.1.x branch are outdated...

droplet queued 19: select-all.patch for re-testing.

droplet’s picture

Version: 8.0.x-dev » 8.1.x-dev
Issue tags: +js-novice, +Novice
tohesi’s picture

Assigned: Unassigned » tohesi
Issue tags: +drupalcampfi
tohesi’s picture

Here's droplet's idea rebased on current 8.1.x.

tohesi’s picture

Assigned: tohesi » Unassigned
tohesi’s picture

FileSize
5.1 KB

Submitting the same patch again to hopefully activate the test bot.

lauriii’s picture

Version: 8.1.x-dev » 8.0.x-dev

Lets see if testbot picks this up..

lauriii’s picture

re uploading for 8.0.x, don't credit me for this

yannickoo’s picture

FileSize
59.93 KB

Great!

lauriii’s picture

Bojhan’s picture

Looks good, I dont know if this is actually accessible?

nod_’s picture

ok with me.

cilefen’s picture

Title: Allow selecting multiple checkboxes on "Modules" page » Allow selecting multiple checkboxes on "Modules" page with a single click
NikitaJain’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
159.1 KB
159.73 KB

Tested select-all-2104633-27.patch on Firefox and chrome browser for Ubuntu 14.04. Its working fine.
After applying the patch, user is allowed to select multiple check-boxes on "Modules" page with a single click.
User can select multiple nodes while clicking shift and selecting the first and the last check-box.
Screenshots attached.

mgifford’s picture

Category: Feature request » Bug report
Issue tags: -needs accessibility review

I don't see this as being a barrier, so removing the "needs accessibility review"

The functionality is already in Core, it's just about applying this consistently across the UI. Because it's an inconsistent UI, I'm marking it as a bug. Makes no sense that it works in /admin/content but not /admin/modules

I tested it on a Mac in Firefox & Chrome.

We could look at setting up a follow-up issue to see if we could replicate this functionality for keyboard only users and screen readers. I'm not sure what the pattern would be yet.

alexpott’s picture

Version: 8.0.x-dev » 8.1.x-dev
Category: Bug report » Task
Status: Reviewed & tested by the community » Needs work

This results in visual changes to the install and uninstall forms - in HEAD when you select them the rows do not turn yellow - with the patch they do. Whilst this might be desired - it is not a stated aim of the issue and I don't think this change has had adequate consideration because it is not discussed on issue.

Also I think the description of this as a bug is pretty tenuous and if it is a bug then we should be adding this functionality to ALL tables that have checkboxes like this. There are a few in multilingual configuration that comes to mind. I think this is just a task and as such is eligible for inclusion in 8.1.x.

arunkumark’s picture

Assigned: Unassigned » arunkumark
arunkumark’s picture

Status: Needs work » Needs review
FileSize
5.57 KB

Hi,
I have patched to remove color while selecting on the below patch selecting_multiple_checkboxes_2104633_39.patch

kiruba karan’s picture

Assigned: arunkumark » Unassigned
Status: Needs review » Needs work
Issue tags: +#ChennaiDrupalGroup

This patch works fine if we selected two check box within wrapper.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sahilsharma011’s picture

I've reviewed select-all-2104633-27.patch. It also fixes this issue on 8.4.x branch.

benjifisher’s picture

Issue tags: +Baltimore2017

It is not clear from the comments why this was moved from NR to NW. Maybe that was an accident?

Please pay attention to the comment in #37.

basquet_57’s picture

I'm at Drupalcon, and will be working on this issue for the next hour. Find me if you want to work on this too. (#301)

basquet_57’s picture

Issue summary: View changes
Issue tags: +Needs reroll
Jo Fitzgerald’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
5.54 KB

Re-rolled.

John Cook’s picture

Status: Needs review » Needs work
FileSize
348.51 KB
395.24 KB

I've tested the patch from #48 and here are the results:

The sequential checkboxes are selected/unselected between click (with shift being held be for the second click) and there is no change in the visual styling.

Although it works, I think the code still need a little more work.

In core/misc/tableselect.js around lines 96-97 there is a comment but the code it referrers to appears to have been removed. Is this the case?

Also, after the patch multiple select on admin/content doesn't highlight the selected rows yellow, and is therefore a regression.

We need to decide if the task is actually to make the tables consistent as there are other styling differences. If this is the case, the issue summary need to be updated to reflect this.

yannickoo’s picture

Also, after the patch multiple select on admin/content doesn't highlight the selected rows yellow, and is therefore a regression.

I don't think it's a regression because selected is neither added to rows on modules overview in 8.x-4.x. We could create a new issue for that.

droplet’s picture