Part of the JavaScript selectors clean-up effort.
#1574470: Selectors clean-up
#1415788: Javascript winter clean-up

CommentFileSizeAuthor
#34 interdiff_1751356_31-33.txt4.72 KBkarishmaamin
#33 1751356-33.patch4.09 KBkarishmaamin
#31 1751356-31.patch4.19 KBsrilakshmier
#27 clean_up_field_ui-1751356-27.patch3.76 KBkostyashupenko
#7 clean_up_field_ui-1751356-7.patch4.15 KBpguillard
#4 clean_up_field_ui-1751356-4.patch3.47 KBpguillard

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented

Arg tabledrag-y code :/

don't use the second parameter of once
the .each() should be named functions
use .on
reduce the function nesting.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +Needs JavaScript testing

tag

manuel garcia’s picture

manuel garcia commented
Issue summary: View changes
Parent issue: » #1574470: Selectors clean-up
pguillard’s picture

pguillard commented
Status: Active » Needs work
StatusFileSize
new clean_up_field_ui-1751356-4.patch3.47 KB

A first patch.
I made a turn on the field interface, it seems that nothing is broken...

pguillard’s picture

pguillard commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: clean_up_field_ui-1751356-4.patch, failed testing.

pguillard’s picture

pguillard commented
Status: Needs work » Needs review
StatusFileSize
new clean_up_field_ui-1751356-7.patch4.15 KB

Patch rerolled

Status: Needs review » Needs work

The last submitted patch, 7: clean_up_field_ui-1751356-7.patch, failed testing.

Status: Needs work » Needs review

pguillard queued 7: clean_up_field_ui-1751356-7.patch for re-testing.

droplet’s picture

droplet commented
Priority: Normal » Minor

Thanks @pascalduez and @pguillard !!

However, since jQuery.Once 2.x, I think we don't need this refactoring

andriyun’s picture

andriyun commented

Patch #7 is ok for me.
Thank you @pguillard
+1 to RTBC

andriyun’s picture

andriyun commented
andriyun’s picture

andriyun commented
Status: Needs review » Needs work
andriyun’s picture

andriyun commented

bot trigger

andriyun’s picture

andriyun commented
Status: Needs work » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs manual testing

this needs manual test while there's no js testing

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

kwoxer’s picture

kwoxer commented
Status: Needs review » Needs work

Needs a re-roll since there has been changed lot's of things in that file.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs reroll
droplet’s picture

droplet commented
Status: Needs work » Postponed

Since we have no confidence to commit a patch without testing. I postponed this until we have a better JS testing engine: #2869825: Leverage JS for JS testing (using nightwatch).

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Postponed » Needs work

The dependency is now fixed, so I guess this needs work again.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new clean_up_field_ui-1751356-27.patch3.76 KB

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.9.x-dev » 9.4.x-dev
Status: Needs review » Needs work
Issue tags: +Needs reroll 
patching file core/modules/field_ui/field_ui.js
Hunk #1 FAILED at 38.
Hunk #2 FAILED at 51.
Hunk #3 FAILED at 101.
3 out of 3 hunks FAILED -- saving rejects to file core/modules/field_ui/field_ui.js.rej
srilakshmier’s picture

srilakshmier commented
Status: Needs work » Needs review
StatusFileSize
new 1751356-31.patch4.19 KB

Rerolled the patch for 9.4.x. Please review.

Thank you

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
karishmaamin’s picture

karishmaamin commented
StatusFileSize
new 1751356-33.patch4.09 KB
karishmaamin’s picture

karishmaamin commented
StatusFileSize
new interdiff_1751356_31-33.txt4.72 KB

interdiff #31 and #33

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: -Needs reroll

FYI you are not supposed to modify the JS files directly, you are supposed to modify the .es6.js files and then compile them; see https://www.drupal.org/node/2815083 for details.

Removing the "needs reroll" tag as it is not relevant anymore.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.