Part of the JavaScript selectors clean-up effort.
#1574470: Selectors clean-up
#1415788: Javascript winter clean-up

CommentFileSizeAuthor
#7 clean_up_field_ui-1751356-7.patch4.15 KBpguillard
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 96,851 pass(es). View
#4 clean_up_field_ui-1751356-4.patch3.47 KBpguillard
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch clean_up_field_ui-1751356-4.patch. Unable to apply patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

nod_’s picture

Arg tabledrag-y code :/

don't use the second parameter of once
the .each() should be named functions
use .on
reduce the function nesting.

nod_’s picture

Issue tags: +Needs JS testing

tag

Manuel Garcia’s picture

Issue summary: View changes
Parent issue: » #1574470: Selectors clean-up
pguillard’s picture

Status: Active » Needs work
FileSize
3.47 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch clean_up_field_ui-1751356-4.patch. Unable to apply patch. See the log in the details link for more information. View

A first patch.
I made a turn on the field interface, it seems that nothing is broken...

pguillard’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: clean_up_field_ui-1751356-4.patch, failed testing.

pguillard’s picture

Status: Needs work » Needs review
FileSize
4.15 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 96,851 pass(es). View

Patch rerolled

Status: Needs review » Needs work

The last submitted patch, 7: clean_up_field_ui-1751356-7.patch, failed testing.

Status: Needs work » Needs review
droplet’s picture

Priority: Normal » Minor

Thanks @pascalduez and @pguillard !!

However, since jQuery.Once 2.x, I think we don't need this refactoring

andriyun’s picture

Patch #7 is ok for me.
Thank you @pguillard
+1 to RTBC

andriyun’s picture

andriyun’s picture

Status: Needs review » Needs work
andriyun’s picture

bot trigger

andriyun’s picture

Status: Needs work » Needs review
andypost’s picture

Issue tags: +Needs manual testing

this needs manual test while there's no js testing

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.