Allow $folder option for importContent method

Hi otarza,
Whenever you upload the patch, the Status need to be changed to "Needs Review", only after that the patch will be reviewed. Changing the status, thanks for the patch.

+++ b/src/DefaultContentManagerInterface.php
@@ -23,13 +23,15 @@ interface DefaultContentManagerInterface {
+   *   $options = array('type' => 'folder', 'folder_path' => 'somePathToFolderContainingJSONData')

Can we wrap it to 80 col. Otherwise look fine set of work.

Hi otarza,
As mentioned before also, you need to change the status of the issue to "Needs review", else it will not be reviewed. Kindly keep that in mind from next time. Thanks for the patch.

Sorry for that @otarza.
To be a confirm user you can apply for the "confirmed" user role via the issue queue. Issue summary can just say 'Please review'.
See the following Link
-- https://www.drupal.org/node/1887616
-- https://www.drupal.org/node/add/project-issue/webmasters?component=User%...

looks ok to me +1 for RTBC. In future please add interdiff so that we can easily find what has been changed.

Any update on this ?

+1

Looks ready to merge.

1. +++ b/default_content.module
   @@ -12,7 +12,8 @@ function default_content_modules_installed($modules) {
   +      $options = array('type' => 'module', 'module_name' => $module);
   
   +++ b/src/DefaultContentManager.php
   @@ -141,9 +141,15 @@ class DefaultContentManager implements DefaultContentManagerInterface {
   +  public function importContent($options) {
   

   Why an array of options and not a second option argument?
   I'd prefer the later

2. +++ b/src/DefaultContentManager.php
   @@ -217,7 +223,10 @@ class DefaultContentManager implements DefaultContentManagerInterface {
   +      if(!$folder) {
   +        $this->eventDispatcher->dispatch(DefaultContentEvents::IMPORT,
   +          new ImportEvent($created, $options['module_name']));
   +      }
   

   We need the event in both instances, but it should be a different event.

   This means it makes more sense to rename importContent as importContentFromModule and add a new method importContentFromFolder

Also, we need a test if possible, should be able to use drupal_get_path() to the test module and test using the folder

Patch works well in my case, marking as RTBC.

I've re-rolled patch on #22 working on the following points:

• Writing tests for "import from folder" functionality: in order to test import from arbitrary directory I had to split default_content_test module into two modules: "default_content_test" which just holds configuration such as tags vocabulary and page term reference and "default_content_import_test" which depends from "default_content_test" and just provides default content.
• Providing two different events for import from module and import from folder functionalities as suggested by @larowlan on #18
• Splitting the "importContent()" method into two, protected, service methods: this will allow for custom modules to extend "DefaultContentManager" class in order to easily provide custom import logic reducing feature requests such as this very issue since now developers could simply build the importer as they see fit to their project
• Fixing typos and Drupal coding-standards where I could spot them
• Fixing deprecated usage of "SafeMarkup" class as per https://www.drupal.org/node/1312890

Interdiff between #22 and #26 is also provided.

Nice! This is a nice addition!

I've reviewed the re-roll and everything works as expected. Thanks!

Anyone working on this ?

This will be useful with related

Another reroll on current 8.x-1.x branch.
The reroll is manual, let's see what the testbot says.

The patch applies, but the tests are failing. Try to fix it next days/week.

This feature would also allow the default content manager to be used, e.g. in an install profile.
Thanks for the patch

This could also be useful in relation to manual imports #2640734: [PP-1] Allow manual imports.

For example, the default-content-export-references has a --folder option, and an import command could have it too, for symmetry.

I think this ticket may have merged with #2824103: default-content-export-references behaves differently than default-content-export which also needs to use the --folder option for symmetry.

Suggested credits get moved and work gets continued there.

IMO anyway.

Adding a patch for 2.x branch.

These two issues do not alter the import behavior, only the export behavior.
#2824103: default-content-export-references behaves differently than default-content-export
#2640734: [PP-1] Allow manual imports

For my use case, I need to import from a folder, that is not in a module.