Problem/Motivation

Add tests for the order source plugin.

Proposed resolution

Write the tests.

Remaining tasks

Patch
review
commit

CommentFileSizeAuthor
#2 2962640-2.patch7.6 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
FileSize
2962640-2.patch7.6 KB

Let's try this.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Active » Needs review

Tests pass setting to NR.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Needs work 
+++ b/modules/ubercart/tests/src/Kernel/Plugin/migrate/source/d6/OrderTest.php
@@ -0,0 +1,185 @@
+          'delivery_first_name' => '',
+          'delivery_last_name' => '',
+          'delivery_phone' => '',
+          'delivery_company' => '',
+          'delivery_street1' => '',
+          'delivery_street2' => '',
+          'delivery_city' => '',
+          'delivery_zone' => '',
+          'delivery_postal_code' => '',
+          'delivery_country' => '',
+          'billing_first_name' => 'Foo',
+          'billing_last_name' => 'Bar',
+          'billing_phone' => '555-4567',
+          'billing_company' => 'Acme',
+          'billing_street1' => '1 Coyote Way',
+          'billing_street2' => 'Utah',
+          'billing_city' => 'Salt Lake',
+          'billing_zone' => '58',
+          'billing_postal_code' => '11111',
+          'billing_country' => '840',

Do we in fact really loose all this profile data? Seems like we should document that.

Or plan a follow-up migration to profiles and re-link them back in.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Needs work » Needs review

Not at all. The source plugin output has not changed at all. The billing profile is migrated in d6_ubercart_billing_profile and then, in the order migration, the profile field is populated by doing a migration_lookup to the billing profile migration with the order_id as the source.

  • heddn committed 2da6164 on 8.x-2.x authored by quietone 
    Issue #2962640 by quietone, heddn: Add Order source plugin test
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs review » Fixed

Ah good. All looks good here then.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.