make ProductVariation inherit from Node?

Or extend it from Drupal\migrate_drupal\Plugin\migrate\source\DrupalSqlBase\FieldableEntity and then have the methods getFields() and getFieldValues() available.

Yes, let's extend from Node. Just needed a few tweaks.

It looks like the failure is due to translations, which are not enabled for product variations in the tests.

Did some testing on a fresh install, which included Spanish.

$ drush mim --execute-dependencies d6_language_content_settings
 [notice] Processed 5 items (2 created, 0 updated, 0 failed, 3 ignored) - done with 'd6_node_type'
 [notice] Processed 3 items (3 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_product_type'
 [notice] Processed 5 items (0 created, 0 updated, 0 failed, 5 ignored) - done with 'd6_language_content_settings'
$ drush mim --execute-dependencies d6_ubercart_language_content_settings
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_product_type'
 [notice] Processed 5 items (2 created, 0 updated, 0 failed, 3 ignored) - done with 'd6_ubercart_language_content_settings'

Manually enable translations for all product variation types

$ drush mim --execute-dependencies d6_ubercart_product_variation
 [notice] Processed 4 items (4 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field'
 [notice] Processed 4 items (4 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_product_attribute'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_product_attribute'
 [notice] Processed 4 items (4 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field_instance'
 [notice] Processed 5 items (5 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_product_variation'
v@cm {/opt/sites/d8/modules/contrib/commerce_migrate} (pvsource)$ drush mim --execute-dependencies d6_ubercart_product_variation_translation
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_product_attribute'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_product_attribute'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_attribute_field_instance'
 [notice] Processed 2 items (2 created, 0 updated, 0 failed, 0 ignored) - done with 'd6_ubercart_product_variation_translation'
v@cm {/opt/sites/d8/modules/contrib/commerce_migrate} (pvsource)$ 

Checked the variation table and the translations are there, although they all have the 'default' product variation type. Hmm, there is no migration for product variation types?

Set component

So, what needs to happen here is for the product variation migration to be translation aware. For that to happen the following has been added; a migration for the language content settings for product variations, a migration for product variation types and a migration for product variation translations.

In testing, I learned that product variations only get a translation entry in the db when a field on the product variation is translated. Unfortunately, the current D6 test fixture does not have such a field with a translation. So maybe it would be better to extend from Fieldable entity as suggested in #2.

And add some migrations to the tests.

Update the IS

Trying to reroll

Move test file to correct directory.

Silly me uploaded that same patch with the error.

Fix one error, the entity count.

Update IS

This is a reroll of the first patch, in #3. Adding the cck fielk data to the row should be straightforward. The product and product variation migrations passed tests locally now so something has been fixed since Jan that affects this.

This patch has reduced the number of product variation from 7 to 5, which was a bit of a surprise. The source has 5 products, 2 of which are translated and the migration creates product variations are created for the translated products. Note the product variations are in the 'en' language which makes sense because product variation translation is not enabled.

I'm preparing locally to run the full migration and check that everything works as expected in the UI. In the meantime, here is a new patch, updating the tests. There is a reduction in the product variation entity count in the full upgrade test, adjusting the rollback test and checking that the two extra product variations are not created.

Yes, a full migration works as expected the 2 translations are there and available via the UI.

Before this patch there were 7 product variations after the migration, the extra two were not linked to a product and there was no test to confirm they did not exist. A test to do just that has been added in the patch in #25.

The changes here make sense. Tests are also aligned.