Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Postponed on #2998666: Warnings after D7 upgrade caused by rdf migration
Problem/Motivation
We've found a couple cases now where the integration between migrations is causing issues. See #2899062: Order migration does not list store migration as dependency and #2899149: Product display migration is missing dependency on d7_product_display_type as a couple examples.
Proposed resolution
Let's add a test of all the things to help us catch some of these things. Modeled after the UI test in Drupal core.
Remaining tasks
Code it.
Review it.
User interface changes
n/a
API changes
n/a
Data model changes
n/a
Comment | File | Size | Author |
---|---|---|---|
#45 | interdiff.txt | 1.2 KB | quietone |
#45 | 2899676-45.patch | 16.32 KB | quietone |
#44 | interdiff.txt | 3.04 KB | quietone |
#44 | 2899676-44.patch | 16.28 KB | quietone |
#42 | 2899676-42.patch | 16.28 KB | quietone |
Comments
Comment #2
heddnComment #3
heddnComment #4
quietone CreditAttribution: quietone commentedPostponed on #2569805: For Drupal migration, identify the source module and #2899495: Add source_module and destination_module to the sources and destionations.
Comment #5
quietone CreditAttribution: quietone commentedBoth #2569805: For Drupal migration, identify the source module and #2899495: Add source_module and destination_module to the sources and destionations are in, so no longer postponded.
Comment #6
quietone CreditAttribution: quietone commentedBut let's postpone this until the other similar tests are working.
#2899672: Commerce 1 Test "All The Things" and #2899675: Ubercart 6 Test "All The Things".
Comment #7
quietone CreditAttribution: quietone commentedThis may work.
Comment #9
quietone CreditAttribution: quietone commentedOh right, need to finish the field migrations first.
Comment #10
quietone CreditAttribution: quietone commentedUpdating for all the recent migrations that have been committed.
Comment #12
quietone CreditAttribution: quietone commentedAdjust the node type.
Comment #14
quietone CreditAttribution: quietone commentedAdjust the entity counts for the latest changes.
Comment #16
quietone CreditAttribution: quietone commentedI think this is a dependency problem with and uc7_comment_type needs to be added as a dependency in d7_field_instance. As the code is it will get added other field migrations as well but that will should be ok.
Comment #18
quietone CreditAttribution: quietone commentedSo, this is failing due to d7_rdf_mapping.
That migration reports errors if the rdf_mapping entity already exists as we can see here.
Opened a core issue and upload a patch for this, #2998666: Warnings after D7 upgrade caused by rdf migration, which fixed this test locally. This is postponed on that.
However, this test is very useful to have in as early as possible and I am tempted to write a workaround for it. Marking postponed while I ponder on that.
Comment #19
quietone CreditAttribution: quietone at Acro Commerce commentedNo longer postponed
Comment #20
quietone CreditAttribution: quietone at Acro Commerce commentedComment #22
quietone CreditAttribution: quietone at Acro Commerce commentedsome more entity updates.
Comment #24
quietone CreditAttribution: quietone at Acro Commerce commentedHow about removing the horrible var_dump
Comment #26
quietone CreditAttribution: quietone at Acro Commerce commentedAnd there are two profile, yes
Comment #28
quietone CreditAttribution: quietone at Acro Commerce commentedMaybe this will get the last ones.
Comment #29
quietone CreditAttribution: quietone at Acro Commerce commentedNow make a new test base which will be used for U6 and U7 but for now just test with U7.
Comment #31
quietone CreditAttribution: quietone at Acro Commerce commentedMake all the entity counts an int.
Comment #33
quietone CreditAttribution: quietone at Acro Commerce commentedFixing more entity counts
Comment #35
quietone CreditAttribution: quietone at Acro Commerce commentedAlter views count
Comment #37
quietone CreditAttribution: quietone at Acro Commerce commentedWell, my local must be out of date. Let's try again.
Comment #39
quietone CreditAttribution: quietone at Acro Commerce commentedReally? One was still a string?
Comment #40
quietone CreditAttribution: quietone at Acro Commerce commentedNow convert MigrateUpgradeUbercart6Test to use the Core base test as well.
Comment #42
quietone CreditAttribution: quietone at Acro Commerce commentedThe setup method in core add content, that is why all the entity counts have changed.
Does it matter? It just means we are not testing from a clean install of the standard profile. I am ok with that. It is certainly possible that the destination will have content before running this migration.
Comment #44
quietone CreditAttribution: quietone at Acro Commerce commentedLet's see if my local is really up to date noe.
Comment #45
quietone CreditAttribution: quietone at Acro Commerce commentedGreat! Just a few comment changes.
Comment #47
quietone CreditAttribution: quietone at Acro Commerce commentedNo need to wait on this.