Postponed on #2998666: Warnings after D7 upgrade caused by rdf migration

Problem/Motivation

We've found a couple cases now where the integration between migrations is causing issues. See #2899062: Order migration does not list store migration as dependency and #2899149: Product display migration is missing dependency on d7_product_display_type as a couple examples.

Proposed resolution

Let's add a test of all the things to help us catch some of these things. Modeled after the UI test in Drupal core.

Remaining tasks

Code it.
Review it.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

heddn’s picture

Title: Ubercart 6 Test "All The Things" » Ubercart 7 Test "All The Things"
heddn’s picture

Component: Ubercart D6 » Ubercart D7
quietone’s picture

quietone’s picture

Status: Active » Postponed

But let's postpone this until the other similar tests are working.
#2899672: Commerce 1 Test "All The Things" and #2899675: Ubercart 6 Test "All The Things".

quietone’s picture

Status: Postponed » Needs review
FileSize
15.21 KB

This may work.

Status: Needs review » Needs work

The last submitted patch, 7: 2899676-7.patch, failed testing. View results

quietone’s picture

Status: Needs work » Postponed

Oh right, need to finish the field migrations first.

quietone’s picture

Status: Postponed » Needs review
FileSize
8.08 KB

Updating for all the recent migrations that have been committed.

Status: Needs review » Needs work

The last submitted patch, 10: 2899676-10.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
8.08 KB
660 bytes

Adjust the node type.

Status: Needs review » Needs work

The last submitted patch, 12: 2899676-12.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
8.08 KB
1.25 KB

Adjust the entity counts for the latest changes.

Status: Needs review » Needs work

The last submitted patch, 14: 2899676-14.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
8.66 KB
587 bytes

I think this is a dependency problem with and uc7_comment_type needs to be added as a dependency in d7_field_instance. As the code is it will get added other field migrations as well but that will should be ok.

Status: Needs review » Needs work

The last submitted patch, 16: 2899676-16.patch, failed testing. View results

quietone’s picture

Issue summary: View changes
Status: Needs work » Postponed
uc7\MigrateUpgradeUbercart7Test::testMigrateUpgrade
Migration of a:2:{s:9:"sourceid1";s:4:"node";s:9:"sourceid2";s:7:"article";} to a:0:{} as part of the d7_rdf_mapping migration. The source row status is 3

So, this is failing due to d7_rdf_mapping.

That migration reports errors if the rdf_mapping entity already exists as we can see here.

(8.7.x)$ drush mim d7_rdf_mapping
 [error]  'rdf_mapping' entity with ID 'node.article' already exists. (/opt/sites/d8/core/lib/Drupal/Core/Entity/EntityStorageBase.php:462) 
 [error]  'rdf_mapping' entity with ID 'node.page' already exists. (/opt/sites/d8/core/lib/Drupal/Core/Entity/EntityStorageBase.php:462) 

Opened a core issue and upload a patch for this, #2998666: Warnings after D7 upgrade caused by rdf migration, which fixed this test locally. This is postponed on that.

However, this test is very useful to have in as early as possible and I am tempted to write a workaround for it. Marking postponed while I ponder on that.

quietone’s picture

Status: Postponed » Needs work

No longer postponed

quietone’s picture

Status: Needs work » Needs review
FileSize
8.66 KB
729 bytes

Status: Needs review » Needs work

The last submitted patch, 20: 2899676-20.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
8.74 KB
2.88 KB

some more entity updates.

Status: Needs review » Needs work

The last submitted patch, 22: 2899676-22.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

quietone’s picture

Status: Needs work » Needs review
FileSize
8.66 KB

How about removing the horrible var_dump

Status: Needs review » Needs work

The last submitted patch, 24: 2899676-24.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
8.66 KB
660 bytes

And there are two profile, yes

Status: Needs review » Needs work

The last submitted patch, 26: 2899676-26.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
8.66 KB
936 bytes

Maybe this will get the last ones.

quietone’s picture

FileSize
10.75 KB
7.6 KB

Now make a new test base which will be used for U6 and U7 but for now just test with U7.

Status: Needs review » Needs work

The last submitted patch, 29: 2899676-29.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
7.59 KB
1.33 KB

Make all the entity counts an int.

Status: Needs review » Needs work

The last submitted patch, 31: 2899676-31.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
7.59 KB
2.12 KB

Fixing more entity counts

Status: Needs review » Needs work

The last submitted patch, 33: 2899676-33.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
7.59 KB

Alter views count

Status: Needs review » Needs work

The last submitted patch, 35: 2899676-35.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
7.59 KB

Well, my local must be out of date. Let's try again.

Status: Needs review » Needs work

The last submitted patch, 37: 2899676-37.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
7.59 KB

Really? One was still a string?

quietone’s picture

FileSize
16.28 KB

Now convert MigrateUpgradeUbercart6Test to use the Core base test as well.

Status: Needs review » Needs work

The last submitted patch, 40: 2899676-40.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
16.28 KB

The setup method in core add content, that is why all the entity counts have changed.

   // Create content.
    $this->createContent();

Does it matter? It just means we are not testing from a clean install of the standard profile. I am ok with that. It is certainly possible that the destination will have content before running this migration.

Status: Needs review » Needs work

The last submitted patch, 42: 2899676-42.patch, failed testing. View results

quietone’s picture

Status: Needs work » Needs review
FileSize
16.28 KB
3.04 KB

Let's see if my local is really up to date noe.

quietone’s picture

FileSize
16.32 KB
1.2 KB

Great! Just a few comment changes.

  • quietone committed dbcfac2 on 8.x-2.x
    Issue #2899676 by quietone, heddn: Ubercart 7 Test "All The Things"
    
quietone’s picture

Status: Needs review » Fixed

No need to wait on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.