Problem/Motivation

FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\amp.info.yml
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
----------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\amp.install
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  3 | WARNING | [x] Unused use statement
  4 | WARNING | [x] Unused use statement
 45 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
 61 | ERROR   | [x] There must be exactly one blank line before the tags in a doc comment
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\amp.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AND 49 WARNINGS AFFECTING 65 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
   5 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\Display\EntityViewDisplayInterface.
  46 | ERROR   | [x] Data types in @var tags need to be fully namespaced
  47 | ERROR   | [ ] The array declaration extends to column 109 (the limit is 80). The array content should be split up over multiple lines
  56 | WARNING | [ ] Unused variable $canonical_href.
 108 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 113 | WARNING | [x] A comma should follow the last multiline array item. Found: NULL
 118 | ERROR   | [x] Each index in a multi-line array must be on a new line
 118 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 124 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 125 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 133 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 136 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 139 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 142 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 145 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 148 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 151 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 154 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 157 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 160 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 163 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 166 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 169 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 172 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 175 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 178 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 181 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 184 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 187 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 190 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 193 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 196 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 199 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 202 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 205 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 208 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 211 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 214 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 217 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 218 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 219 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 220 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 221 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 228 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
 239 | WARNING | [x] A comma should follow the last multiline array item. Found: 'googleanalytics'
 241 | WARNING | [x] A comma should follow the last multiline array item. Found: $google_analytics_id
 254 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE
 255 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 262 | WARNING | [x] A comma should follow the last multiline array item. Found: $subs
 304 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 305 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 316 | ERROR   | [x] Short array syntax must be used to define arrays
 319 | ERROR   | [x] Short array syntax must be used to define arrays
 321 | WARNING | [x] A comma should follow the last multiline array item. Found: "save"
 325 | ERROR   | [x] Short array syntax must be used to define arrays
 328 | ERROR   | [x] Short array syntax must be used to define arrays
 330 | WARNING | [x] A comma should follow the last multiline array item. Found: "save"
 339 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 340 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 354 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
 354 | ERROR   | [ ] Doc comment short description must end with a full stop
 354 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 370 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 379 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 380 | ERROR   | [x] Short array syntax must be used to define arrays
 381 | ERROR   | [x] Short array syntax must be used to define arrays
 390 | WARNING | [ ] Unused variable $type.
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 62 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\config\schema\amp.settings.schema.yml
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 39 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\modules\amp_adsense\amp_adsense.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
 7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\modules\amp_adsense\amp_adsense.module
-----------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  3 | WARNING | [x] Unused use statement
 34 | WARNING | [x] A comma should follow the last multiline array item. Found: $data_ad_slot
 35 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 36 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\README.md
------------------------------------------------------------------------------
FOUND 1 ERROR AND 45 WARNINGS AFFECTING 45 LINES
------------------------------------------------------------------------------
  12 | WARNING | [ ] Line exceeds 80 characters; contains 141 characters
  14 | WARNING | [ ] Line exceeds 80 characters; contains 304 characters
  20 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
  22 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  24 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters
  27 | WARNING | [ ] Line exceeds 80 characters; contains 268 characters
  31 | WARNING | [ ] Line exceeds 80 characters; contains 251 characters
  32 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
  33 | WARNING | [ ] Line exceeds 80 characters; contains 150 characters
  34 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
  35 | WARNING | [ ] Line exceeds 80 characters; contains 195 characters
  36 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters
  42 | WARNING | [ ] Line exceeds 80 characters; contains 182 characters
  48 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
  50 | WARNING | [ ] Line exceeds 80 characters; contains 155 characters
  51 | WARNING | [ ] Line exceeds 80 characters; contains 205 characters
  53 | WARNING | [ ] Line exceeds 80 characters; contains 153 characters
  61 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
  66 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
  75 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
  76 | WARNING | [ ] Line exceeds 80 characters; contains 247 characters
  77 | WARNING | [ ] Line exceeds 80 characters; contains 129 characters
  83 | WARNING | [ ] Line exceeds 80 characters; contains 262 characters
  85 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
  86 | WARNING | [ ] Line exceeds 80 characters; contains 182 characters
  92 | WARNING | [ ] Line exceeds 80 characters; contains 280 characters
  96 | WARNING | [ ] Line exceeds 80 characters; contains 129 characters
  98 | WARNING | [ ] Line exceeds 80 characters; contains 124 characters
  99 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
 100 | WARNING | [ ] Line exceeds 80 characters; contains 156 characters
 102 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
 103 | WARNING | [ ] Line exceeds 80 characters; contains 141 characters
 104 | WARNING | [ ] Line exceeds 80 characters; contains 229 characters
 105 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
 106 | WARNING | [ ] Line exceeds 80 characters; contains 136 characters
 111 | WARNING | [ ] Line exceeds 80 characters; contains 529 characters
 125 | WARNING | [ ] Line exceeds 80 characters; contains 152 characters
 128 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
 129 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters
 131 | WARNING | [ ] Line exceeds 80 characters; contains 149 characters
 134 | WARNING | [ ] Line exceeds 80 characters; contains 236 characters
 136 | WARNING | [ ] Line exceeds 80 characters; contains 235 characters
 138 | WARNING | [ ] Line exceeds 80 characters; contains 221 characters
 140 | WARNING | [ ] Line exceeds 80 characters; contains 301 characters
 142 | WARNING | [ ] Line exceeds 80 characters; contains 140 characters
 142 | ERROR   | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Controller\AMPTestLibrary.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 2 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\amp\Service\AMPService.
 13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 19 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 25 | ERROR   | [x] Expected 1 blank line before function; 0 found
 41 | ERROR   | [ ] Description for the @return value is missing
 44 | ERROR   | [x] Concat operator must be surrounded by a single space
 54 | ERROR   | [x] Concat operator must be surrounded by a single space
 55 | ERROR   | [x] Expected 1 space after ".="; 20 found
 59 | ERROR   | [x] Concat operator must be surrounded by a single space
 59 | WARNING | [x] A comma should follow the last multiline array item. Found: "</pre>"
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Element\AmpAnalytics.php
-------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 15 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 27 | ERROR   | [x] Short array syntax must be used to define arrays
 30 | ERROR   | [x] Short array syntax must be used to define arrays
 31 | ERROR   | [x] Short array syntax must be used to define arrays
 35 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 36 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 46 | ERROR   | [x] Expected 1 blank line after function; 0 found
 47 | ERROR   | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Element\AmpIframe.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 5 WARNINGS AFFECTING 15 LINES
--------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  6 | WARNING | [x] Unused use statement
  7 | WARNING | [x] Unused use statement
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\amp\Service\AMPService.
  7 | ERROR   | [x] There must be one blank line after the last USE statement; 2 found;
 13 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 31 | ERROR   | [x] Short array syntax must be used to define arrays
 34 | ERROR   | [x] Short array syntax must be used to define arrays
 36 | ERROR   | [x] Short array syntax must be used to define arrays
 37 | ERROR   | [x] Short array syntax must be used to define arrays
 38 | ERROR   | [x] Short array syntax must be used to define arrays
 43 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 44 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 53 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 53 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 55 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 67 | ERROR   | [x] Expected 1 blank line after function; 0 found
 68 | ERROR   | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Element\AmpProcessedText.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AND 5 WARNINGS AFFECTING 23 LINES
------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  6 | WARNING | [x] Unused use statement
  7 | WARNING | [x] Unused use statement
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\amp\Service\AMPService.
  8 | WARNING | [x] Unused use statement
 22 | ERROR   | [x] Short array syntax must be used to define arrays
 25 | ERROR   | [x] Short array syntax must be used to define arrays
 27 | ERROR   | [x] Short array syntax must be used to define arrays
 28 | ERROR   | [x] Short array syntax must be used to define arrays
 29 | ERROR   | [x] Short array syntax must be used to define arrays
 33 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 34 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 41 | ERROR   | [ ] Description for the @return value is missing
 44 | ERROR   | [x] Opening brace should be on the same line as the declaration
 45 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 48 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 51 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 52 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 56 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 59 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 67 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 67 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 69 | ERROR   | [x] Data types in @var tags need to be fully namespaced
 85 | ERROR   | [x] Expected 1 blank line after function; 0 found
 86 | ERROR   | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 24 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\EntityTypeInfo.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AND 2 WARNINGS AFFECTING 16 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
   6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
 105 | ERROR   | [x] Short array syntax must be used to define arrays
 107 | ERROR   | [x] Short array syntax must be used to define arrays
 110 | ERROR   | [ ] The array declaration extends to column 130 (the limit is 80). The array content should be split up over multiple lines
 113 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 113 | ERROR   | [x] Short array syntax must be used to define arrays
 114 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 115 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 116 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 117 | ERROR   | [x] Array closing indentation error, expected 8 spaces but found 10
 120 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 120 | ERROR   | [x] Short array syntax must be used to define arrays
 121 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 122 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 123 | ERROR   | [x] Array closing indentation error, expected 8 spaces but found 10
 127 | ERROR   | [x] Expected 1 blank line after function; 0 found
 128 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\EventSubscriber\AmpHtmlResponseSubscriber.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\amp\Render\AmpHtmlResponseMarkupProcessor.
 32 | ERROR   | [ ] Parameter $amp_context is not described in comment
 57 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 5
 65 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters
 65 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Form\AmpSettingsForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 55 ERRORS AND 16 WARNINGS AFFECTING 43 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  30 | ERROR   | [ ] Missing @var tag in member variable comment
  67 | ERROR   | [x] You must use "/**" style comments for a function comment
  78 | ERROR   | [x] Use "elseif" in place of "else if"
 125 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 157 | ERROR   | [ ] The array declaration extends to column 639 (the limit is 80). The array content should be split up over multiple lines
 163 | ERROR   | [x] Short array syntax must be used to define arrays
 173 | ERROR   | [x] Short array syntax must be used to define arrays
 183 | ERROR   | [x] Short array syntax must be used to define arrays
 185 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 187 | ERROR   | [x] Short array syntax must be used to define arrays
 193 | ERROR   | [x] Short array syntax must be used to define arrays
 198 | ERROR   | [x] Short array syntax must be used to define arrays
 198 | ERROR   | [x] The first index in a multi-value array must be on a new line
 198 | ERROR   | [x] Short array syntax must be used to define arrays
 199 | ERROR   | [x] Short array syntax must be used to define arrays
 199 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 199 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
 202 | ERROR   | [x] Short array syntax must be used to define arrays
 207 | ERROR   | [x] Short array syntax must be used to define arrays
 207 | ERROR   | [x] The first index in a multi-value array must be on a new line
 207 | ERROR   | [x] Short array syntax must be used to define arrays
 208 | ERROR   | [x] Short array syntax must be used to define arrays
 208 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 208 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
 211 | ERROR   | [x] Short array syntax must be used to define arrays
 216 | ERROR   | [x] Short array syntax must be used to define arrays
 216 | ERROR   | [x] The first index in a multi-value array must be on a new line
 216 | ERROR   | [x] Short array syntax must be used to define arrays
 217 | ERROR   | [x] Short array syntax must be used to define arrays
 217 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 217 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
 221 | ERROR   | [x] Short array syntax must be used to define arrays
 223 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 226 | ERROR   | [x] Short array syntax must be used to define arrays
 228 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 228 | ERROR   | [x] Short array syntax must be used to define arrays
 228 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 231 | ERROR   | [x] Short array syntax must be used to define arrays
 235 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
 235 | ERROR   | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 239 | ERROR   | [x] Short array syntax must be used to define arrays
 243 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
 243 | ERROR   | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 246 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 249 | ERROR   | [x] Short array syntax must be used to define arrays
 250 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 251 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 252 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 253 | ERROR   | [x] Array indentation error, expected 6 spaces but found 8
 253 | ERROR   | [x] Short array syntax must be used to define arrays
 253 | ERROR   | [x] The first index in a multi-value array must be on a new line
 253 | ERROR   | [x] Short array syntax must be used to define arrays
 254 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
 254 | ERROR   | [x] Short array syntax must be used to define arrays
 254 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 254 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
 258 | ERROR   | [x] Short array syntax must be used to define arrays
 262 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
 262 | ERROR   | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 264 | ERROR   | [x] Short array syntax must be used to define arrays
 264 | ERROR   | [x] The first index in a multi-value array must be on a new line
 264 | ERROR   | [x] Short array syntax must be used to define arrays
 265 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 265 | ERROR   | [x] Short array syntax must be used to define arrays
 265 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 265 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
 284 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 292 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 330 | ERROR   | [x] Expected 1 blank line after function; 0 found
 331 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 57 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Plugin\Block\AmpGoogleAdsenseBlock.php
---------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AND 5 WARNINGS AFFECTING 19 LINES
---------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  2 | ERROR   | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
  3 | ERROR   | [x] Doc comment short description must end with a full stop
 16 | ERROR   | [x] Missing class doc comment
 20 | ERROR   | [x] Expected 1 blank line before function; 0 found
 23 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 26 | ERROR   | [x] Short array syntax must be used to define arrays
 27 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 45 | WARNING | [x] A comma should follow the last multiline array item. Found: $data_ad_slot
 46 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 47 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 61 | ERROR   | [x] Short array syntax must be used to define arrays
 64 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 68 | ERROR   | [x] Short array syntax must be used to define arrays
 71 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 75 | ERROR   | [x] Short array syntax must be used to define arrays
 78 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 92 | ERROR   | [x] Expected 1 blank line after function; 0 found
 93 | ERROR   | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Plugin\Block\AmpGoogleDoubleClickBlock.php
-------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AND 5 WARNINGS AFFECTING 19 LINES
-------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  2 | ERROR   | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
  3 | ERROR   | [x] Doc comment short description must end with a full stop
 16 | ERROR   | [x] Missing class doc comment
 20 | ERROR   | [x] Expected 1 blank line before function; 0 found
 23 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 26 | ERROR   | [x] Short array syntax must be used to define arrays
 27 | WARNING | [x] A comma should follow the last multiline array item. Found: )
 45 | WARNING | [x] A comma should follow the last multiline array item. Found: $data_slot
 46 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 47 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
 61 | ERROR   | [x] Short array syntax must be used to define arrays
 64 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 68 | ERROR   | [x] Short array syntax must be used to define arrays
 71 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 75 | ERROR   | [x] Short array syntax must be used to define arrays
 78 | ERROR   | [x] Use null coalesce operator instead of ternary operator.
 92 | ERROR   | [x] Expected 1 blank line after function; 0 found
 93 | ERROR   | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 19 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Plugin\Field\FieldFormatter\AmpIframeFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
 27 | ERROR | [x] Expected 1 blank line before function; 0 found
 28 | ERROR | [x] Short array syntax must be used to define arrays
 35 | ERROR | [x] Short array syntax must be used to define arrays
 46 | ERROR | [x] Expected 1 newline at end of file; 3 found
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Plugin\Field\FieldFormatter\AmpImageFormatter.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AND 7 WARNINGS AFFECTING 19 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  23 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  24 | ERROR   | [x] Expected 2 space(s) before asterisk; 3 found
  25 | ERROR   | [x] Expected 2 space(s) before asterisk; 3 found
  27 | ERROR   | [x] Short array syntax must be used to define arrays
  42 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  45 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  47 | ERROR   | [x] Short array syntax must be used to define arrays
  51 | WARNING | [x] 'TODO: figure out why amp_layout_height always shows.' should match the format '@todo Fix problem X here.'
  52 | ERROR   | [x] Short array syntax must be used to define arrays
  54 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  55 | ERROR   | [x] Short array syntax must be used to define arrays
  56 | ERROR   | [x] Short array syntax must be used to define arrays
  58 | ERROR   | [x] Short array syntax must be used to define arrays
  58 | WARNING | [x] A comma should follow the last multiline array item. Found: )
  58 | ERROR   | [x] Closing parenthesis of array declaration must be on a new line
  77 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  77 | ERROR   | [x] Short array syntax must be used to define arrays
  80 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
  80 | ERROR   | [x] Short array syntax must be used to define arrays
  99 | ERROR   | [x] Expected 1 blank line after function; 2 found
 117 | ERROR   | [x] Expected 1 blank line after function; 0 found
 118 | ERROR   | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Plugin\Field\FieldFormatter\AmpSummaryOrTrimmedFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 18 | ERROR | [x] There should be no white space after an opening "{"
 18 | ERROR | [x] There should be no white space before a closing "}"
 18 | ERROR | [x] Expected 1 newline at end of file; 3 found
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Plugin\Field\FieldFormatter\AmpTextFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
 27 | ERROR | [x] Expected 1 blank line before function; 0 found
 28 | ERROR | [x] Short array syntax must be used to define arrays
 35 | ERROR | [x] Short array syntax must be used to define arrays
 44 | ERROR | [x] Expected 1 blank line after function; 0 found
 45 | ERROR | [x] Expected 1 newline at end of file; 3 found
 45 | ERROR | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Plugin\Field\FieldFormatter\AmpTextTrimmedFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AND 2 WARNINGS AFFECTING 16 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
  7 | WARNING | [x] Unused use statement
  8 | WARNING | [x] Unused use statement
  8 | ERROR   | [x] Non-namespaced classes/interfaces/traits should not be referenced with use statements
 29 | ERROR   | [ ] Doc comment short description must end with a full stop
 29 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 31 | ERROR   | [x] Doc comment long description must start with a capital letter
 35 | ERROR   | [x] Expected 1 blank line before function; 0 found
 36 | ERROR   | [x] Short array syntax must be used to define arrays
 43 | ERROR   | [ ] The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines
 51 | ERROR   | [x] Short array syntax must be used to define arrays
 52 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 53 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 54 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 55 | ERROR   | [x] Array indentation error, expected 8 spaces but found 10
 68 | ERROR   | [x] Expected 1 blank line after function; 0 found
 69 | ERROR   | [x] Expected 1 newline at end of file; 3 found
 69 | ERROR   | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Plugin\Field\FieldFormatter\AmpVideoFormatter.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 4 WARNINGS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 27 | ERROR   | [x] Short array syntax must be used to define arrays
 39 | ERROR   | [x] Short array syntax must be used to define arrays
 41 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 46 | ERROR   | [x] Short array syntax must be used to define arrays
 48 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 64 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 64 | ERROR   | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 64 | ERROR   | [x] Short array syntax must be used to define arrays
 69 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 69 | ERROR   | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
 69 | ERROR   | [x] Short array syntax must be used to define arrays
 88 | ERROR   | [x] Expected 1 blank line after function; 0 found
 89 | ERROR   | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Render\AmpHtmlResponseAttachmentsProcessor.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
   6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Asset\AssetResolverInterface.
  93 | ERROR   | [x] list(...) is forbidden, use [...] instead.
  93 | WARNING | [ ] Unused variable $js_assets_footer.
 107 | ERROR   | [x] Doc comment long description must start with a capital letter
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Render\AmpHtmlResponseMarkupProcessor.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 19 ERRORS AND 2 WARNINGS AFFECTING 19 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  10 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ServiceProviderBase.
  15 | ERROR   | [x] Additional blank lines found at end of doc comment
  16 | ERROR   | [x] Expected 1 space before opening brace; found 2
  36 | ERROR   | [x] Data types in @var tags need to be fully namespaced
  47 | ERROR   | [ ] Missing short description in doc comment
  48 | ERROR   | [x] Data types in @var tags need to be fully namespaced
  52 | ERROR   | [ ] Missing short description in doc comment
  53 | ERROR   | [x] Data types in @var tags need to be fully namespaced
  57 | ERROR   | [ ] Missing short description in doc comment
  62 | ERROR   | [ ] Parameter $logger is not described in comment
  62 | ERROR   | [ ] Parameter $configFactoryInterface is not described in comment
  65 | ERROR   | [x] Data types in @param tags need to be fully namespaced
  68 | ERROR   | [x] Additional blank lines found at end of doc comment
  98 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
  98 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 105 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 113 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 120 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 128 | ERROR   | [x] Expected 1 blank line after function; 0 found
 129 | ERROR   | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Routing\AmpContext.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 34 ERRORS AND 3 WARNINGS AFFECTING 30 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
   6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
  11 | WARNING | [x] Unused use statement
  54 | ERROR   | [ ] Parameter $entityTypeInfo is not described in comment
  54 | ERROR   | [ ] Parameter $routeMatch is not described in comment
  61 | ERROR   | [ ] Doc comment for parameter $entity_type_info does not match actual variable name $adminContext
  63 | ERROR   | [ ] Doc comment for parameter $route_match does not match actual variable name $adminContext
  74 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
  74 | ERROR   | [x] Closing brace indented incorrectly; expected 2 spaces, found 1
  76 | ERROR   | [ ] Parameter $routeMatch is not described in comment
  79 | ERROR   | [ ] Doc comment for parameter $route_match does not match actual variable name $checkTheme
  83 | ERROR   | [x] Expected "bool" but found "boolean" for parameter type
  94 | WARNING | [ ] Unused variable $route_is_not_amp.
  98 | WARNING | [ ] Unused variable $route_is_amp.
 103 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 103 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 116 | ERROR   | [ ] Parameter $routeMatch is not described in comment
 119 | ERROR   | [ ] Doc comment for parameter $route_match does not match actual variable name $routeMatch
 122 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
 122 | ERROR   | [ ] Description for the @return value is missing
 133 | ERROR   | [ ] Parameter $routeMatch is not described in comment
 138 | ERROR   | [ ] Doc comment for parameter $route_match does not match actual variable name $routeMatch
 141 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
 141 | ERROR   | [ ] Description for the @return value is missing
 146 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 7
 155 | ERROR   | [ ] Parameter $routeMatch is not described in comment
 161 | ERROR   | [ ] Doc comment for parameter $route_match does not match actual variable name $routeMatch
 164 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
 164 | ERROR   | [ ] Description for the @return value is missing
 169 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 7
 177 | ERROR   | [ ] The $_GET super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->query->get('amp') instead
 183 | ERROR   | [ ] Parameter $routeMatch is not described in comment
 186 | ERROR   | [ ] Doc comment for parameter $route_match does not match actual variable name $routeMatch
 203 | ERROR   | [x] Parameter comment must end with a full stop
 205 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
 205 | ERROR   | [ ] Description for the @return value is missing
 208 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Service\AMPService.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 55 ERRORS AND 3 WARNINGS AFFECTING 52 LINES
------------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ServiceProviderBase.
 12 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 13 | ERROR   | [x] Expected 1 space before opening brace; found 2
 14 | WARNING | [ ] Line exceeds 80 characters; contains 124 characters
 15 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters
 15 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 16 | ERROR   | [x] You must use "/**" style comments for a member variable comment
 16 | ERROR   | [ ] Class property $library_names should use lowerCamel naming without underscores
 17 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 18 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 19 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 20 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 21 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 22 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 23 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 24 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 25 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 26 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 27 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 28 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 29 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 30 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 31 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 32 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 33 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 34 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 35 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 36 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 37 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 38 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 39 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 40 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 41 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 42 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 43 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 44 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 45 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 46 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 47 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 48 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 49 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 50 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 51 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 52 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 53 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 54 | ERROR   | [x] Array indentation error, expected 4 spaces but found 6
 54 | ERROR   | [x] Inline comments must start with a capital letter
 54 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 54 | ERROR   | [x] Comments may not appear after statements
 60 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 62 | ERROR   | [ ] Description for the @return value is missing
 62 | ERROR   | [x] Data types in @return tags need to be fully namespaced
 64 | ERROR   | [ ] Public method name "AMPService::createAMPConverter" is not in lowerCamel format
 69 | ERROR   | [x] Doc comment short description must end with a full stop
 77 | ERROR   | [x] Expected 1 space after FOREACH keyword; 0 found
 83 | ERROR   | [x] Expected 1 blank line after function; 0 found
 84 | ERROR   | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 51 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Theme\AmpNegotiator.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ServiceProviderBase.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\src\Utility\AmpQueryParameters.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
  8 | ERROR | [x] Doc comment short description must end with a full stop
 21 | ERROR | [x] Expected "bool" but found "boolean" for parameter type
 28 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 42 | ERROR | [x] Expected 1 blank line after function; 0 found
 43 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\tests\src\Functional\AmpTestBase.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 5 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  6 | WARNING | [x] Unused use statement
 61 | ERROR   | [ ] The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
 71 | WARNING | [x] A comma should follow the last multiline array item. Found: 'Article'
 82 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 89 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 97 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\amp\tests\src\Functional\AmpViewModeTest.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  7 | WARNING | [x] Unused use statement
  8 | WARNING | [x] Unused use statement
  9 | WARNING | [x] Unused use statement
  9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\amp\Functional\AmpTestBase.
 22 | ERROR   | [x] Expected 1 blank line before function; 2 found
 33 | WARNING | [ ] Unused variable $amp_context.
 43 | ERROR   | [ ] The array declaration extends to column 133 (the limit is 80). The array content should be split up over multiple lines
 66 | ERROR   | [x] Expected 1 blank line after function; 0 found
 67 | ERROR   | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

Time: 1.24 secs; Memory: 12MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml amp/
CommentFileSizeAuthor
#12 3104780-12.patch96.45 KBurvashi_vora
#10 3104780-10.patch54.89 KBurvashi_vora
#4 3104780-4.patch52.87 KBSahana _N

Issue fork amp-3104780

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ankushgautam76@gmail.com created an issue. See original summary.

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 at Material for Material commented
Title: Coding Standarad issue » Coding Standarad issues
Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
CreditAttribution: Webbeh at Georgia Institute of Technology commented
Title: Coding Standarad issues » Coding standard issues
Sahana _N’s picture

Sahana _N CreditAttribution: Sahana _N at Specbee commented
Status: Needs work » Needs review
FileSize
3104780-4.patch52.87 KB

Please review the patch.

Status: Needs review » Needs work

The last submitted patch, 4: 3104780-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Ankush_03’s picture

Ankush_03
Location Gurgaon, India 🇮🇳
CreditAttribution: Ankush_03 at Material for Material commented
Issue tags: +Drupal 9 compatibility
nikitagupta’s picture

nikitagupta CreditAttribution: nikitagupta at Material for Drupal India Association commented
Assigned: Unassigned » nikitagupta
nikitagupta’s picture

nikitagupta CreditAttribution: nikitagupta at Material for Drupal India Association commented
Assigned: nikitagupta » Unassigned
kkalashnikov’s picture

kkalashnikov CreditAttribution: kkalashnikov at Material for Drupal India Association commented
Issue tags: +DIACWMay2020
urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented
Status: Needs work » Needs review
FileSize
3104780-10.patch54.89 KB

Hi

I tried resolving coding standard errors by PHPCS. Please review the uploaded patch.

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
CreditAttribution: Webbeh at Georgia Institute of Technology commented

Can you please provide a diff between patch #4 and patch #10?

urvashi_vora’s picture

urvashi_vora CreditAttribution: urvashi_vora at Valuebound for Valuebound commented
FileSize
3104780-12.patch96.45 KB

Hi @webbeh

Here is the diff file between patch #4 and patch #10

sahal_va’s picture

sahal_va CreditAttribution: sahal_va at Axelerant commented
Status: Needs review » Needs work

Still there are coding standard errors after applying the patch with standard "DrupalPractice".
So changing to NW

phpcs --standard=Drupal,DrupalPractice

FILE: /app/web/modules/contrib/amp/amp.post_update.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 3 | ERROR | Missing short description in doc comment
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/amp.theme.inc
----------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------
  19 | ERROR   | Type hint "array" missing for $variables
  29 | WARNING | Unused variable $options.
  71 | ERROR   | Type hint "array" missing for $variables
 100 | ERROR   | Type hint "array" missing for $variables
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/AmpFormTrait.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 151 | ERROR | Parameter $layout is not described in comment
 177 | ERROR | Parameter $layout is not described in comment
 217 | ERROR | Parameter $layout is not described in comment
 244 | ERROR | Parameter $layout is not described in comment
----------------------------------------------------------------------


FILE: ...p/web/modules/contrib/amp/src/Asset/AmpCssCollectionRenderer.php
----------------------------------------------------------------------
FOUND 3 ERRORS AND 5 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
 127 | WARNING | [ ] Unused variable $urls.
 164 | ERROR   | [x] list(...) is forbidden, use [...] instead.
 164 | WARNING | [ ] Unused variable $query.
 205 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 208 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 211 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 338 | ERROR   | [ ] Type hint "array" missing for $matches
 338 | ERROR   | [ ] Public method name
     |         |     "AmpCssCollectionRenderer::rewriteFileURI" is
     |         |     not in lowerCamel format
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/Controller/AMPTestLibrary.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
 13 | WARNING | The class short comment should describe what the
    |         | class does and not simply repeat the class name
 42 | ERROR   | Description for the @return value is missing
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/Element/AmpAnalytics.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 15 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/Element/AmpSidebar.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 24 | WARNING | Unused variable $class.
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/Element/AmpSocialPost.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 164 | ERROR | Missing parameter type
 183 | ERROR | Parameter $provider is not described in comment
 186 | ERROR | Missing parameter type
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/EntityTypeInfo.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 110 | ERROR   | The array declaration extends to column 130 (the
     |         | limit is 80). The array content should be split up
     |         | over multiple lines
 112 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 113 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 114 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
----------------------------------------------------------------------


FILE: ...b/modules/contrib/amp/src/EventSubscriber/AmpEventSubscriber.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 55 | ERROR | [ ] The $_GET super global must not be accessed
    |       |     directly; inject the request_stack service and use
    |       |     $stack->getCurrentRequest()->query->get('_wrapper_format')
    |       |     instead
 55 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
 55 | ERROR | [ ] The $_GET super global must not be accessed
    |       |     directly; inject the request_stack service and use
    |       |     $stack->getCurrentRequest()->query->get('_wrapper_format')
    |       |     instead
 61 | ERROR | [ ] The $_GET super global must not be accessed
    |       |     directly; inject the request_stack service and use
    |       |     $stack->getCurrentRequest()->query->get('_wrapper_format')
    |       |     instead
 61 | ERROR | [ ] The $_GET super global must not be accessed
    |       |     directly; inject the request_stack service and use
    |       |     $stack->getCurrentRequest()->query->get('_wrapper_format')
    |       |     instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...pp/web/modules/contrib/amp/src/Form/AmpAnalyticsSettingsForm.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
----------------------------------------------------------------------
  34 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
  38 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
  45 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
  45 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
  64 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
  71 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
  71 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
  88 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 146 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 156 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/Form/AmpSettingsForm.php
----------------------------------------------------------------------
FOUND 16 ERRORS AND 17 WARNINGS AFFECTING 17 LINES
----------------------------------------------------------------------
  30 | ERROR   | Missing @var tag in member variable comment
 124 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 126 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 126 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 137 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 137 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 146 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 146 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 154 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 154 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 163 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 163 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 188 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 188 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 209 | ERROR   | The array declaration extends to column 91 (the
     |         | limit is 80). The array content should be split up
     |         | over multiple lines
 209 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 209 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 209 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 209 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 217 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 217 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 222 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 222 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 228 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 237 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 237 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 258 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 261 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 261 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 272 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 272 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
 274 | WARNING | Translatable strings must not begin or end with
     |         | white spaces, use placeholders with t() for
     |         | variables
 274 | ERROR   | Concatenating translatable strings is not allowed,
     |         | use placeholders instead and only one string literal
----------------------------------------------------------------------


FILE: ...dules/contrib/amp/src/Plugin/Block/AmpGoogleDoubleClickBlock.php
----------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------
  8 | ERROR | [ ] Doc comment is empty
 57 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
 67 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
 74 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
 81 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...web/modules/contrib/amp/src/Plugin/Block/AmpSocialShareBlock.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 74 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
 82 | ERROR | [x] Use null coalesce operator instead of ternary
    |       |     operator.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...contrib/amp/src/Plugin/Field/FieldFormatter/AmpImageCarousel.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 34 | WARNING | Unused private method getLayouts()
 76 | WARNING | t() calls should be avoided in classes, use
    |         | \Drupal\Core\StringTranslation\StringTranslationTrait
    |         | and $this->t() instead
 79 | WARNING | #options values usually have to run through t() for
    |         | translation
 80 | WARNING | #options values usually have to run through t() for
    |         | translation
----------------------------------------------------------------------


FILE: ...ontrib/amp/src/Plugin/Field/FieldFormatter/AmpImageFormatter.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 34 | WARNING | Unused private method getLayouts()
----------------------------------------------------------------------


FILE: ...b/amp/src/Plugin/Field/FieldFormatter/AmpSocialPostFormatter.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 37 | WARNING | Unused private method getLayouts()
 52 | WARNING | Unused private method getLibraries()
----------------------------------------------------------------------


FILE: ...ontrib/amp/src/Plugin/Field/FieldFormatter/AmpVideoFormatter.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 34 | WARNING | Unused private method getLayouts()
----------------------------------------------------------------------


FILE: ...les/contrib/amp/src/Plugin/views/style/AmpViewsCarouselStyle.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
  68 | WARNING | Unused private method getLayouts()
 121 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 124 | WARNING | #options values usually have to run through t() for
     |         | translation
 125 | WARNING | #options values usually have to run through t() for
     |         | translation
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/Render/AmpHtmlRenderer.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
  78 | ERROR   | [x] list(...) is forbidden, use [...] instead.
 151 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
 152 | WARNING | [ ] t() calls should be avoided in classes, use
     |         |     \Drupal\Core\StringTranslation\StringTranslationTrait
     |         |     and $this->t() instead
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...s/contrib/amp/src/Render/AmpHtmlResponseAttachmentsProcessor.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
  55 | ERROR   | [ ] Parameter $htmlResponseAttachmentsProcessor is
     |         |     not described in comment
 113 | ERROR   | [x] list(...) is forbidden, use [...] instead.
 113 | WARNING | [ ] Unused variable $js_assets_footer.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/Routing/AmpContext.php
----------------------------------------------------------------------
FOUND 21 ERRORS AND 3 WARNINGS AFFECTING 22 LINES
----------------------------------------------------------------------
  54 | ERROR   | Parameter $entityTypeInfo is not described in
     |         | comment
  54 | ERROR   | Parameter $routeMatch is not described in comment
  61 | ERROR   | Doc comment for parameter $entity_type_info does not
     |         | match actual variable name $adminContext
  63 | ERROR   | Doc comment for parameter $route_match does not
     |         | match actual variable name $adminContext
  76 | ERROR   | Parameter $routeMatch is not described in comment
  79 | ERROR   | Doc comment for parameter $route_match does not
     |         | match actual variable name $checkTheme
  95 | WARNING | Unused variable $route_is_not_amp.
  99 | WARNING | Unused variable $route_is_amp.
 117 | ERROR   | Parameter $routeMatch is not described in comment
 120 | ERROR   | Doc comment for parameter $route_match does not
     |         | match actual variable name $routeMatch
 123 | ERROR   | Description for the @return value is missing
 134 | ERROR   | Parameter $routeMatch is not described in comment
 139 | ERROR   | Doc comment for parameter $route_match does not
     |         | match actual variable name $routeMatch
 142 | ERROR   | Description for the @return value is missing
 157 | ERROR   | Parameter $routeMatch is not described in comment
 163 | ERROR   | Doc comment for parameter $route_match does not
     |         | match actual variable name $routeMatch
 166 | ERROR   | Description for the @return value is missing
 174 | WARNING | Line exceeds 80 characters; contains 95 characters
 176 | ERROR   | The $_GET super global must not be accessed
     |         | directly; inject the request_stack service and use
     |         | $stack->getCurrentRequest()->query->get('_wrapper_format')
     |         | instead
 176 | ERROR   | The $_GET super global must not be accessed
     |         | directly; inject the request_stack service and use
     |         | $stack->getCurrentRequest()->query->get('_wrapper_format')
     |         | instead
 177 | ERROR   | The $_GET super global must not be accessed
     |         | directly; inject the request_stack service and use
     |         | $stack->getCurrentRequest()->query->get('amp')
     |         | instead
 184 | ERROR   | Parameter $routeMatch is not described in comment
 187 | ERROR   | Doc comment for parameter $route_match does not
     |         | match actual variable name $routeMatch
 206 | ERROR   | Description for the @return value is missing
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/src/Service/AMPService.php
----------------------------------------------------------------------
FOUND 10 ERRORS AND 5 WARNINGS AFFECTING 15 LINES
----------------------------------------------------------------------
  19 | WARNING | [ ] The class short comment should describe what the
     |         |     class does and not simply repeat the class name
  52 | ERROR   | [ ] Missing @var tag in member variable comment
  57 | ERROR   | [ ] Missing @var tag in member variable comment
  87 | ERROR   | [ ] Public method name "AMPService::mapJSToNames" is
     |         |     not in lowerCamel format
  89 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 102 | ERROR   | [ ] Doc comment short description must be on a
     |         |     single line, further text should be a separate
     |         |     paragraph
 104 | ERROR   | [ ] Description for the @return value is missing
 106 | ERROR   | [ ] Public method name
     |         |     "AMPService::createAMPConverter" is not in
     |         |     lowerCamel format
 141 | WARNING | [ ] Unused variable $map.
 173 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 194 | WARNING | [ ] \Drupal calls should be avoided in classes, use
     |         |     dependency injection instead
 214 | ERROR   | [ ] Type hint "array" missing for $libraries
 219 | ERROR   | [x] list(...) is forbidden, use [...] instead.
 234 | ERROR   | [ ] Type hint "array" missing for $libraries
 240 | ERROR   | [ ] The array declaration extends to column 100 (the
     |         |     limit is 80). The array content should be split
     |         |     up over multiple lines
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/tests/src/Functional/AmpAdsense.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | ERROR | Class name doesn't match filename; expected "class
    |       | AmpAdsense"
----------------------------------------------------------------------


FILE: .../contrib/amp/tests/src/Functional/AmpFormatterMediaImageTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 56 | WARNING | Unused variable $media_type.
----------------------------------------------------------------------


FILE: ...dules/contrib/amp/tests/src/Functional/AmpFormatterVideoTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 69 | WARNING | Unused variable $file_system.
----------------------------------------------------------------------


FILE: ...app/web/modules/contrib/amp/tests/src/Functional/AmpTestBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 156 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 163 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
 196 | ERROR   | The array declaration extends to column 130 (the
     |         | limit is 80). The array content should be split up
     |         | over multiple lines
----------------------------------------------------------------------


FILE: /app/web/modules/contrib/amp/tests/src/Functional/AmpToolbar.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | ERROR | Class name doesn't match filename; expected "class
    |       | AmpToolbar"
----------------------------------------------------------------------


FILE: ...app/web/modules/contrib/amp/tests/src/Unit/AmpSocialPostTest.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
  90 | ERROR | Description for the @return value is missing
 149 | ERROR | Description for the @return value is missing
 220 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------
vishaljd’s picture

vishaljd CreditAttribution: vishaljd at Valuebound commented
Assigned: Unassigned » vishaljd
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Title: Coding standard issues » Fix the issues reported by phpcs
Issue tags: +Needs issue summary update

The issue summary needs to be updated, since https://pareview.sh is not anymore accessible. The issue summary needs to show what reported by phpcs and which arguments are passed to phpcs.

vishaljd opened merge request !12

vishaljd’s picture

vishaljd CreditAttribution: vishaljd at Valuebound commented
Assigned: vishaljd » Unassigned
Status: Needs work » Needs review

arpitk made their first commit to this issue’s fork.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Category: Bug report » Task
Status: Needs review » Needs work
Issue tags: +Coding standards

The issue summary does not yet show which command and which arguments have been used to get that report.

zkhan.aamir’s picture

zkhan.aamir CreditAttribution: zkhan.aamir at Specbee for Drupal India Association commented
Issue summary: View changes
Issue tags: -Needs issue summary update

Issue summary updated