Adjust to the changes introduced reorganizing Block items in the administration menu

Hello, good job @smulvih2, I've tested and the toolbar is working as intended; moving to RTBC.

I've applied the patch and taken a look. Unfortunately the approach has one fundamental flaw. If you click in the admin toolbar on content->blocks then the path of the page you are directed to shows /admin/structure/block/block-content and its breadcrumb home > administration > structure > block layout. Meaning the user is first in the top level menu item /admin/content but the page the user ends up is under /admin/structure. that is a potential source for confusion.
If you go to block types in the admin toolbar menu the second level nav item next to block types on the left is also blocks. it points to the same page you get to when clicking blocks under content. so two different menu items in two different sections (content & structure) pointing to the very same page.

In general I completely agree with the need and the effort to solve the problem caused by the current representation of blocks under the top level menu item structure. But I think that the problem should better be solved in Core. There are actually two issues that got momentum again two or three days ago, thanks to @smustgrave, solving that exact problem.

• #2862564: Move Custom block library to Content
• #2987964: Move custom block types admin link to admin/structure

When I was taking a look at the current state of those issues one of the problems was that there were some discrepancies with menu items that admin_toolbar probably hasn't created dynamically and therefore there was a disconnect with the changes the patches introduced.

for #2987964: Move custom block types admin link to admin/structure: the menu item custom block types got renamed to block types and moved one level up the hierarchy so it is on the same level like block layout, content types, media types and so on. but under block layouts there is still another menu item block types.

for #2862564: Move Custom block library to Content:the custom block library got moved over to content. in yesterdays ux meeting #3316853: Drupal Usability Meeting 2022-10-28 there was also the idea and discussion to change the naming of custom block library and custom blocks (that isn't reflected in #2862564: Move Custom block library to Content yet). on /admin/content the custom blocks tab is placed between content and comments. but in admin toolbar custom blocks is placed between comments and files.

there was an agreement to open an issue about the matter in the admin_toolbar issue queue. @smustgrave suggested to open an issue and postpone it until the two issues are landed in Core. so i went into the admin_toolbar issue queue tonight. that's where i've noticed the issue here.

The question now is how you would like to proceed? Would you prefer that i open a new issue for the necessary changes those linked issues in Core entail and let credits be moved over from this issue, or better rescope this issue or go with another option you would have in mind? Just wanted to avoid double work for anyone involved nor make any decisions over anyones head.

Thanks @smulvih2! I'll remove the related issue and set the issue as child of the overall meta issue reorganizing the block items in the administration theme. cuz the admin_toolbar issue not only applies to the "moving the custom block library to content" but also to "block types" and "block layout". making it the child of the meta would cover everything.

Aside that i think the title would have to reworded to reflect the new scope as well as an update to the issue summary is need. for the moment i would say to add the two paragraphs from #8 to the proposed resolution section with the note that it might entail more changes as soon as the the move of block layout gets implemented as well.

and i am not sure about the correct form. but if an issue gets postponed blocked by one or more other issues would it have [P-1] prepended?

I think this is now only postponed on #3318112: [PP1] Move "Block layout" from Structure to Appearance and possibly #3318549: Rename Custom Block terminology in the admin UI.

thanks for updating the issue aaron! this issue has definitely to be placed after #3318549: Rename Custom Block terminology in the admin UI until the micro copy (and the h1s in particular) is agreed on. i was already thinking about adding an update to the issue here yesterday after the "moving the block library to content" issue has landed but i have struggled picking the right PP level. but it feels like PP-2 is the correct pick.

Thanks @rkoller. In terms of the "PP-X" level, the way I approach it is it should be the number of issues that this issue is directly postponed on, in this case 2 issues, even though one of them is postponed on another issue that doesn't really matter for this issue, otherwise it just ends up being a bit hard to track what is postponed on what.

Just a heads up. The first alpha of Drupal 10.1 is getting close (scheduled for the 24th of april). The last two issues (#3318112: [PP1] Move "Block layout" from Structure to Appearance & #3318549: Rename Custom Block terminology in the admin UI) currently blocking this issue should hopefully getting finalized and being committed in the upcoming days.

#3318549: Rename Custom Block terminology in the admin UI got in today so only one blocking issue left.

We might already start discussing how to approach the necessary changes. how about the following.

Content:
the cleanest option might be like already suggested in the issue summary
https://www.drupal.org/files/issues/2022-10-26/Screenshot%20from%202022-...
it just looks odd having a single menu item under blocks and then under that several block types (depending on the number of block types created). the only
necessary change to the screenshot, the label for the add menu item shouldnt be Add custom block but Add content block.

Structure:
the menu item block types under structure is already displayed correctly. the only detail i would suggest to change is adding a Add block type menu item that the available options are consistent with for example content types.

Appearance:
at the moment the block layout menu item under appearance still has the add custom block, block types, and custom block library submenu items. removing those three would be the logical step. but i wonder if it would make sense to make the secondary nav tabs for block layout available as menu items instead like done for the settings menu item under appearance.
the only problem, for settings there is the default global settings tab that is reached when the parent settings menu item is clicked while you see the child menu items for claro and olivero. but for block layout you would reach olivero when clicking block layout menu item and you would only have claro as the sole child menu item. sort of suboptimal. :/

I am moving this issue to Needs work now. Drupal 10.1 RC1 is out and #3318112: [PP1] Move "Block layout" from Structure to Appearance got postponed on #2755613: Restructure the admin interface Information Architecture today after it was hanging in RTBC for quite a while. That way this issue should focus only on the first two points in #18 (with a small addition for the point about structure i've missed before):

Content:
the cleanest option might be like already suggested in the issue summary
https://www.drupal.org/files/issues/2022-10-26/Screenshot%20from%202022-...
it just looks odd having a single menu item under blocks and then under that several block types (depending on the number of block types created). the only
necessary change to the screenshot, the label for the add menu item shouldnt be Add custom block but Add content block.

Structure:

• The menu item block types under structure is already displayed correctly. the only detail i would suggest to change is adding a Add block type menu item that the available options are consistent with for example content types.
• The sub menu items for the menu item Block Layout under structure would have to be removed.

In regards of the Block Layout move a new issue could be opened as soon as there is a final consensus about the new location.

" the label for the add menu item shouldnt be Add custom block but Add content block."
The text is actually just "Blocks."

At least this one is easy. The text mentioned is in the module currently and being removed.
This is the new layout in the patch:

Patch from #6 is really helpful. I though i was loosing my mind because i couldn't find these "new links" after the changes in 10.1 Thank you!

Applied changes from #6 to the fork.

The branch has some JS issues like $(...).once is not a functionwhich is causing the "Admin Toolbar quick search" to stop working, tested on Drupal 10.1.7.