Problem/Motivation

In #2862564: Move Custom block library to Content Custom block library menu section has been moved to Content .

Currently blocks library is not available in content menu links while using admin toolbar module.
Issue-3393220.png

Steps to reproduce

Before 2862564
before-2862564

After 2862564
after-2862564

Proposed resolution

Add menu link to block content under content menu in a similar way where other content entity links resides

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 Afterpatch_10.0.1.png24.75 KBkanchan bhogade
#9 Afterpatch_10.0.png23.88 KBkanchan bhogade
#9 Beforepatch.png27.88 KBkanchan bhogade
#8 afterPatch64.png24.95 KBasawari
#8 beforePatch64.png23.91 KBasawari
#6 3393220-6.patch1.59 KBroshni27
#6 after10.1.png36.48 KBroshni27
#6 after10.0.png34.63 KBroshni27
#6 before10.0.png33.77 KBroshni27
#2 Issue-3393220.png207.37 KBbhanu951
after-2862564.png34.86 KBbhanu951
before-2862564.png95.4 KBbhanu951

Issue fork admin_toolbar-3393220

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Bhanu951 created an issue. See original summary.

bhanu951’s picture

bhanu951 commented
Issue summary: View changes
StatusFileSize
new Issue-3393220.png207.37 KB

Bhanu951 opened merge request !64

bhanu951’s picture

bhanu951 commented
Status: Active » Needs review

Screenshot after fix.

Only local images are allowed.

sakthi_dev’s picture

sakthi_dev commented
Status: Needs review » Needs work

HI @bhanu951, as Custom Block Library is moved from Structure to Content from 10.1.x only. So, this will affect sites running in 10.0.x . I think it is better to remove links adding from admin_toolbar and create a menu.links in block_content of Core.

Or can we have a separate release with this changes which supports from 10.1.x.

@bhanu951 or anyone please suggest the best approach here.

roshni27’s picture

roshni27 commented
Status: Needs work » Needs review
StatusFileSize
new before10.0.png33.77 KB
new after10.0.png34.63 KB
new after10.1.png36.48 KB
new 3393220-6.patch1.59 KB

I agree with you, Sakthi. I have provide a patch and a screenshot for reference. Kindly review.

bwaindwain’s picture

bwaindwain commented
Related issues: +#3317639: Adjust to the changes introduced reorganizing Block items in the administration menu
asawari’s picture

asawari commented
StatusFileSize
new beforePatch64.png23.91 KB
new afterPatch64.png24.95 KB

Verified the issue on Drupal 10.2 version.
The patch is applied successfully and the fix is visible after applying the patch.But not changing the status for code review and for more reviews.

- Downloaded Admin Toolbar module to reproduce the issue.
Attaching before and after screenshots for the reference.

kanchan bhogade’s picture

kanchan bhogade commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Beforepatch.png27.88 KB
new Afterpatch_10.0.png23.88 KB
new Afterpatch_10.0.1.png24.75 KB

Hi
Tested MR !64 on Drupal 10 and 10.0.1 version
The patch was applied successfully...

Test Result:
The block content is added under the Content menu.

Attaching screenshots
RTBC+1

Moving to RTBC

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Closed (outdated)
dydave’s picture

dydave commented
Related issues: +#3393220: Add menu link to block content under content menu

dydave closed merge request !64

dydave’s picture

dydave commented
Related issues: -#3393220: Add menu link to block content under content menu +#3462559: Link to "Block" content overview page not displayed